Issue #21533 has been updated by nobu (Nobuyoshi Nakada). matheusrich (Matheus Richard) wrote in #note-2:
@nobu (Nobuyoshi Nakada) totally fair questioning. In fact, my initial idea was to propose Time#morning? (hour between 6...12) but I wasn't sure that would be true for all cultures.
It varies by cultures.
I'd be happy to introduce any other methods like daytime?/nighttime?, but I think those are prone to bikeshedding for what day/night/morning means.
Agree. We would need methods to calculate the sunrise/sunset times for a specified date and location.
Am/pm are clearly defined and might be enough most of the time?
Cleary defined -- probably yes. Enough most of the time -- depends on cultures probably. In any case, I'm not against (neutral or slightly positive) this proposal itself, as wrote previously. ---------------------------------------- Feature #21533: Introduce `Time#am?` and `Time#pm?` https://bugs.ruby-lang.org/issues/21533#change-114240 * Author: matheusrich (Matheus Richard) * Status: Open ---------------------------------------- This proposal adds two predicate methods to `Time`: ```ruby Time.utc(2000, 1, 1, 11, 59, 59).am? # => true Time.utc(2000, 1, 1, 12, 0, 0).pm? # => true ``` * `am?` returns true when the hour is less than 12. * `pm?` returns true when the hour is 12 or greater. These methods provide a clear and expressive way to branch logic based on time of day. For example: ```ruby def reminder_deferral_options options = [] options << ["Later today", "later_today"] if Time.now.am? options << ["Tomorrow morning", "tomorrow_morning"] options << ["Pick a date/time…", "custom"] options end ``` This is a common pattern in applications involving reminders and scheduling. The method names are intuitive, and the semantics are well understood. The implementation is in [this Pull Request](https://github.com/ruby/ruby/pull/14133). -- https://bugs.ruby-lang.org/