Issue #21618 has been updated by Earlopain (Earlopain _).
I think they are exactly the same, and if it's not the case that's a bug we can fix in Prism.
It's already a non-trivial amount of effort to provide major/minor support. Taking patch into account is unreasonable in my eyes. Accepting X.Y.Z as an input is just for convenience.
BTW do you have a link for that bug?
It was 3.3.0: https://bugs.ruby-lang.org/issues/20090
My guess is changing the default here would fix more issues than cause incompatibilities.
I don't think changing the default would be much of an improvement. You can't tell what people really want. I would prefer no default at all but that ship has sailed.
IOW, I think they are theoretical concerns.
They are. With ripper they were none, which is mostly what I am saying. Prism is otherwise better in every way. For now, I will just update places to use `RUBY_VERSION` since that is clearly more correct that not passing anything at all. I don't think there would be much discussion if it were trivial to implement. It's ok to reject based on that. `RUBY_VERSION` gets you 99% there but it would be nice if it could be 100%. ---------------------------------------- Bug #21618: Allow to use the build-in prism version to parse code https://bugs.ruby-lang.org/issues/21618#change-114754 * Author: Earlopain (Earlopain _) * Status: Open * Backport: 3.2: UNKNOWN, 3.3: UNKNOWN, 3.4: UNKNOWN ---------------------------------------- Prism is a multi-version parser, which is a great feature. If one calls `Prism.parse("foo")`, it will always use the latest version prism knows about. This may or may not be the version that is currently executing. This is problematic when one wants to introspect code the same way that the currently running ruby version would. Consider that some syntax will be disallowed in the next ruby version. I would have to specify the ruby version I want to parse as in order to not run into syntax errors: `Prism.parse("foo", version: RUBY_VERSION)`. But doing so is not feasable because `prism` is distributed out of sync with ruby itself. If the user already has prism in their lockfile, the user may run a prism version that doesn't yet know about lets say ruby 4.0 and thus raise. Similarly, it may parse as an older patch version that has subtle behaviour differences. `ripper` does not have this issue because it is always tied to the ruby version and it is not distributed as a gem, so what the user has will always be exactly what ruby shipped with. I wish for a similar API that utilizes the prism version bundled with ruby itself. Libraries like `rails` have moved from ripper to prism because of its superior developer experience but it risks breaking in unexpected ways with new `prism` versions that know about more recent syntax. `error_highlight` for example also suffers from the same defect. It seems like prism currently has 34 methods that optionally take a version (per the rbi file). Many of these are trivial helper methods like `Prism.parse_success?` (does the parse result have any errors?). I would be happy with supporting only the minimal functions like `Prism.parse` and `Prism.parse_file`. Currently I don't have a use-case for any of the other methods. Pretty much just functions to mirror `RubyVM::InstructionSequence.compile_file` and `RubyVM::InstructionSequence.compile`. It would be optimal if I would be able to transparently call `Prism.parse("foo", version: "current")` (or maybe even have an unspecified version mean the build-in prism version) but I am not sure how feasable that is since I'm pretty sure logic for this would have to live in ruby itself. @kddnewton does this feature request make sense? Do you have any other ideas/inputs? -- https://bugs.ruby-lang.org/