Issue #17473 has been updated by Eregon (Benoit Daloze). hsbt (Hiroshi SHIBATA) wrote in #note-24:
I have merged https://github.com/ruby/pathname/pull/53, it is clearly better for the maintenance of the gem at least.
I reverted that. Please don't merge without consensus. At least, no one strongly against migrate C to Ruby in Dev Meetings.
The transition from C to Ruby should be done gradually, in reviewable chunks.
That PR is actually easy to review as explained in its description, it restores pathname.rb as it used to be and includes all changes to pathname.rb since then, see https://github.com/ruby/pathname/pull/53/files/3736eab91f783cb087f873b99c25f.... IOW, it only adds code in pathname.rb and removes code in pathname.c, and then has separate commits for all other changes. Making multiple smaller PRs does not make sense, especially since the Ruby code is just the one from before the migration to C. I remade the PR as https://github.com/ruby/pathname/pull/57, please review it and share your concerns there. What is the plan for the code in the gem and the code in core? Will they be sync'd, how? From what I have seen changes in core have been done seemingly without caring about the gem, so it seemed the intention was to not sync but effectively fork? We also cannot make the gem empty in general as the gem needs to keep working on Ruby 3.4 and older at least. ---------------------------------------- Feature #17473: Make Pathname to embedded class of Ruby https://bugs.ruby-lang.org/issues/17473#change-114077 * Author: hsbt (Hiroshi SHIBATA) * Status: Closed * Assignee: akr (Akira Tanaka) ---------------------------------------- pathname is one of most useful utility class of Ruby. I'm happy to use Pathname without require it. Any thought? -- https://bugs.ruby-lang.org/