Issue #21654 has been updated by Dan0042 (Daniel DeLorme). mame (Yusuke Endoh) wrote in #note-13:
My concern is that the expectation to "if it's at all possible to raise early" is a slippery slope with no clear boundary.
I don't think it's slippery at all. There's a very clear difference between "infinite" and "very large but finite". I didn't say "if it's at all possible to raise early" in any situation, this is specifically about infinity. If we were in a situation where it's hard to determine if something will run infinitely, then sure there's no helping it. But I don't think that's the case here. tenderlovemaking (Aaron Patterson) wrote in #note-10:
If I write an infinite loop, I expect it to loop infinitely, even if I wrote the infinite loop by mistake. Calling `to_a` or `to_set` on an infinite range is iterating infinitely.
If I write something like `loop{ ary << 42 }` I also expect it to loop infinitely and consume all memory. Because I **wrote** that loop. But in the case of `infinite_range.to_a` I **did not** write any loop. The loop happens in ruby internally. I expect ruby to perform reasonable validation on its inputs. This should raise an exception for the same reason that `42 / 0` raises ZeroDivisionError. ---------------------------------------- Bug #21654: Set#new calls extra methods compared to previous versions https://bugs.ruby-lang.org/issues/21654#change-115015 * Author: tenderlovemaking (Aaron Patterson) * Status: Open * ruby -v: ruby 3.5.0dev (2025-10-24T15:50:47Z master a9f24aaccb) +PRISM [arm64-darwin25] * Backport: 3.2: UNKNOWN, 3.3: UNKNOWN, 3.4: UNKNOWN ---------------------------------------- I'm trying to test Ruby 3.5.0 with our Rails application and we've found that `Set.new` is now causing extra database queries to happen. The changes in d4020dd5faf call "size" on enumerable objects that are passed to the `new` method, and this causes extra "COUNT" queries to happen with ActiveRecord associations. For example: ```ruby Set.new(some_activerecord_association) ``` Previously, the above code would only do one query by iterating over the association. Now it issues two queries, a count query, and then the normal query for results. Since d4020dd5faf is dealing with endless ranges, I would like to narrow the scope from all Enumerable objects to just Ranges. Unfortunately, I noticed we have a test like this: ```ruby assert_raise(ArgumentError) { Set.new(1.upto(Float::INFINITY)) } ``` I'm not sure how we can handle such a case without testing `size`. -- https://bugs.ruby-lang.org/