Issue #20929 has been updated by YO4 (Yoshinao Muramatsu). We have changed Time#zone encoding test code to not consider internal_encoding at 78762b5, but a document of Encoding.default_internal explicitly stated that Time#zone was affected by it. Do we need to reconsider? Github PR#12409 is the change for Time#zone to respect Encoding.default_internal. [78762b5](https://github.com/ruby/ruby/commit/78762b52185aa80ee55c0d49b495aceed863dce2) [Document(3.3)](https://docs.ruby-lang.org/en/3.3/Encoding.html#method-c-default_internal) [Document(master)](https://docs.ruby-lang.org/en/master/Encoding.html#method-c-default_internal) [Github PR#12409](https://github.com/ruby/ruby/pull/12409) ---------------------------------------- Bug #20929: TestTime have an assertion different from current implementation. https://bugs.ruby-lang.org/issues/20929#change-111119 * Author: YO4 (Yoshinao Muramatsu) * Status: Closed * Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- test/ruby/test_time.rb have following assersion function. ```ruby def assert_zone_encoding(time) zone = time.zone assert_predicate(zone, :valid_encoding?) if zone.ascii_only? assert_equal(Encoding::US_ASCII, zone.encoding) else enc = Encoding.default_internal || Encoding.find('locale') assert_equal(enc, zone.encoding) end end ``` In current implementation, Time#zone are returned in US_ASCII or locale encoding, which does not seem to take into account the default_internal. ``` C:\>ruby -e "puts Time.now.zone" 東京 (標準時) C:\>ruby -e "puts Time.now.zone.encoding" Windows-31J C:\>ruby -EWindows-31J:UTF-8 -e "puts Time.now.zone" 東京 (標準時) C:\>ruby -EWindows-31J:UTF-8 -e "puts Time.now.zone.encoding" Windows-31J ``` -- https://bugs.ruby-lang.org/