Issue #20309 has been updated by rubyFeedback (robert heiler).

ruby -run is one of cool feature of Ruby. Should we avoid uninstalling un gem?

I think -run is kind of neat; it's a bit like a mini-DSL for the commandline. (Having said that, I actually do not use it myself; I instead use a custom executable that calls methods in other .rb files, so I kind of have the same or similar functionality available without needing to use special commandline flags; and lots of aliases.) ---------------------------------------- Feature #20309: Bundled gems for Ruby 3.5 https://bugs.ruby-lang.org/issues/20309#change-107032 * Author: hsbt (Hiroshi SHIBATA) * Status: Assigned * Assignee: hsbt (Hiroshi SHIBATA) ---------------------------------------- I propose migrate the following default gems to bundled gems at Ruby 3.5. So, It means users will get warnings if users try to load them. * ostruct * irb * reline * readline (wrapper file for readline-ext and reline) * io-console * logger * fiddle * pstore * open-uri * yaml (wrapper file for psych) * win32ole I have a plan to migrate the following default gems too. But I need to more feedback from other committers about them. * rdoc * We need to change build task like download rdoc gem before document generation. * or We make document generation is optional from Ruby 3.5 * We explicitly separate `make install` and `make install-doc` * un * `ruby -run` is one of cool feature of Ruby. Should we avoid uninstalling `un` gem? * singleton * This is famous design pattern. Should we enforce users add them to their Gemfile? * forwadable * `reline` needs to add forwardable their `runtime_dependency` after migration. * weakref * I'm not sure how impact after migrating bundled gems. * fcntl * Should we integrate these constants into ruby core? I would like to migrate `ipaddr` and `uri` too. But these are used by webrick that is mock server for our test suite. We need to rewrite `webrick` with `TCPSocker` or extract `ipaddr` and `uri` dependency from `webrick` Other default gems depend on our build process or other libraries deeply. I will update this proposal if I could extract them from default gems. -- https://bugs.ruby-lang.org/

Issue #20309 has been updated by Eregon (Benoit Daloze). hsbt (Hiroshi SHIBATA) wrote:

* ostruct * I make ostruct as optional on json at https://github.com/flori/json/pull/565

+1 since ostruct is already kind of deprecated.

* irb * We need to consider how works `binding.irb` after Ruby 3.5.

Will that break `binding.irb` under `bundle exec`? If so that seems a major problem. I would think it would break it if `binding.irb` is implemented as e.g. `gem "irb"; require "irb"; binding.irb`.

* yaml (wrapper file for psych) * syck is retired today. I'm not sure what people uses `psych` directly, not `yaml`.

`psych` seems to be a default gem (and I guess will remain as so as a dependency of rubygems). If so, what is the advantage to make `yaml` a bundled gem? It's a [trivial wrapper](https://github.com/ruby/ruby/blob/master/lib/yaml.rb) so I don't see advantage to make bundled instead of default gem, only overhead (adding `gem "yaml"` in Gemfiles which has no value as this code almost never changes) and troubles. BTW I think most programs use `require "yaml"` instead of `require "psych"` and I think that's better as it is, psych is kind of an implementation detail, people want to load/dump YAML. It seems busy unproductive work to replace `require "yaml"` by `require "psych"` or to add `gem "yaml"` in Gemfiles, so I am very much against making `yaml` a bundled gem.

* readline (wrapper file for readline-ext and reline)

Is the intention to have people do `require "reline"` instead of `require "readline"`? It seems weird if people add `gem "readline"` to solve this, when `gem "reline"` would make much more sense. It's a [trivial wrapper](https://github.com/ruby/ruby/blob/master/lib/readline.rb), so I think making it a bundled gem creates more problems/overhead than it solves.

* un * `ruby -run` is one of cool feature of Ruby. Should we avoid uninstalling `un` gem?

`ruby -run` would still work if `un` is a bundled gem, so I think that's OK. Maybe RubyGems should ask confirmation/extra warning when uninstalling a bundled gem.

* singleton * This is famous design pattern. Should we enforce users add them to their Gemfile?

IMO not worth it, it's pretty [trivial code](https://github.com/ruby/ruby/blob/master/lib/singleton.rb) and too much overhead to ask users to add to Gemfile for something so basic.

* weakref * I'm not sure how impact after migrating bundled gems.

[weakref](https://github.com/ruby/ruby/blob/master/lib/weakref.rb) is very tightly bound to implementation details, such as `::ObjectSpace::WeakMap.new` on CRuby. The implementation is completely different on JRuby and TruffleRuby. It will cause problems to make this a bundled gem for alternative Ruby implementations. So I think it is not worth to make this a bundled gem. Also, that file is tiny and trivial, and had [very few changes](https://github.com/ruby/ruby/commits/master/lib/weakref.rb).

* fcntl * Should we integrate these constants into ruby core?

It seems low-level stuff so I think being behind a `require` is in general good. But between core and bundled gem I would prefer core. ---------------------------------------- Feature #20309: Bundled gems for Ruby 3.5 https://bugs.ruby-lang.org/issues/20309#change-107043 * Author: hsbt (Hiroshi SHIBATA) * Status: Assigned * Assignee: hsbt (Hiroshi SHIBATA) ---------------------------------------- I propose migrate the following default gems to bundled gems at Ruby 3.5. So, It means users will get warnings if users try to load them. * ostruct * I make ostruct as optional on json at https://github.com/flori/json/pull/565 * irb * We need to consider how works `binding.irb` after Ruby 3.5. * reline * readline (wrapper file for readline-ext and reline) * io-console * logger * fiddle * pstore * open-uri * yaml (wrapper file for psych) * syck is retired today. I'm not sure what people uses `psych` directly, not `yaml`. * win32ole I have a plan to migrate the following default gems too. But I need to more feedback from other committers about them. * rdoc * We need to change build task like download rdoc gem before document generation. * or We make document generation is optional from Ruby 3.5 * We explicitly separate `make install` and `make install-doc` * un * `ruby -run` is one of cool feature of Ruby. Should we avoid uninstalling `un` gem? * singleton * This is famous design pattern. Should we enforce users add them to their Gemfile? * forwadable * `reline` needs to add forwardable their `runtime_dependency` after migration. * weakref * I'm not sure how impact after migrating bundled gems. * fcntl * Should we integrate these constants into ruby core? I would like to migrate `ipaddr` and `uri` too. But these are used by webrick that is mock server for our test suite. We need to rewrite `webrick` with `TCPSocker` or extract `ipaddr` and `uri` dependency from `webrick` Other default gems depend on our build process or other libraries deeply. I will update this proposal if I could extract them from default gems. -- https://bugs.ruby-lang.org/

Issue #20309 has been updated by jeremyevans0 (Jeremy Evans). Eregon (Benoit Daloze) wrote in #note-6:

hsbt (Hiroshi SHIBATA) wrote:

...

* singleton * This is famous design pattern. Should we enforce users add them to their Gemfile?

IMO not worth it, it's pretty [trivial code](https://github.com/ruby/ruby/blob/master/lib/singleton.rb) and too much overhead to ask users to add to Gemfile for something so basic.

On the other hand, it's almost always better to use a normal constant with a singleton object than the `singleton` library. `singleton`'s only advantage is you can delay initialization, and if you want that, you can use `autoload` for the file that defines the constant. Instead of: ```ruby class Klass include Singleton # define methods end Klass.instance ``` Use: ```ruby CONSTANT = Object.new CONSTANT.singleton_class.class_eval do # define methods end ``` I think we should encourage users to use the singleton object support built into Ruby core, as opposed to a separate library that accomplishes mostly the same thing. I think the main advantage of the `singleton` library over standard Ruby is that it supports marshalling, but I'm not sure how common is the need to marshal singleton objects. I'm in favor of moving the `singleton` library to bundled gems mainly to discourage users from using it. ---------------------------------------- Feature #20309: Bundled gems for Ruby 3.5 https://bugs.ruby-lang.org/issues/20309#change-107051 * Author: hsbt (Hiroshi SHIBATA) * Status: Assigned * Assignee: hsbt (Hiroshi SHIBATA) ---------------------------------------- I propose migrate the following default gems to bundled gems at Ruby 3.5. So, It means users will get warnings if users try to load them. * ostruct * I make ostruct as optional on json at https://github.com/flori/json/pull/565 * irb * We need to consider how works `binding.irb` after Ruby 3.5. * reline * readline (wrapper file for readline-ext and reline) * io-console * logger * fiddle * pstore * open-uri * yaml (wrapper file for psych) * syck is retired today. I'm not sure what people uses `psych` directly, not `yaml`. * win32ole I have a plan to migrate the following default gems too. But I need to more feedback from other committers about them. * rdoc * We need to change build task like download rdoc gem before document generation. * or We make document generation is optional from Ruby 3.5 * We explicitly separate `make install` and `make install-doc` * un * `ruby -run` is one of cool feature of Ruby. Should we avoid uninstalling `un` gem? * singleton * This is famous design pattern. Should we enforce users add them to their Gemfile? * forwadable * `reline` needs to add forwardable their `runtime_dependency` after migration. * weakref * I'm not sure how impact after migrating bundled gems. * fcntl * Should we integrate these constants into ruby core? I would like to migrate `ipaddr` and `uri` too. But these are used by webrick that is mock server for our test suite. We need to rewrite `webrick` with `TCPSocker` or extract `ipaddr` and `uri` dependency from `webrick` Other default gems depend on our build process or other libraries deeply. I will update this proposal if I could extract them from default gems. -- https://bugs.ruby-lang.org/

Issue #20309 has been updated by Eregon (Benoit Daloze). Also something I remembered now is YJIT does not compile singleton methods, except singleton methods of modules and classes. So then that replacement can also be significantly slower. ---------------------------------------- Feature #20309: Bundled gems for Ruby 3.5 https://bugs.ruby-lang.org/issues/20309#change-107055 * Author: hsbt (Hiroshi SHIBATA) * Status: Assigned * Assignee: hsbt (Hiroshi SHIBATA) ---------------------------------------- I propose migrate the following default gems to bundled gems at Ruby 3.5. So, It means users will get warnings if users try to load them. * ostruct * I make ostruct as optional on json at https://github.com/flori/json/pull/565 * irb * We need to consider how works `binding.irb` after Ruby 3.5. * reline * readline (wrapper file for readline-ext and reline) * io-console * logger * fiddle * pstore * open-uri * yaml (wrapper file for psych) * syck is retired today. I'm not sure what people uses `psych` directly, not `yaml`. * win32ole I have a plan to migrate the following default gems too. But I need to more feedback from other committers about them. * rdoc * We need to change build task like download rdoc gem before document generation. * or We make document generation is optional from Ruby 3.5 * We explicitly separate `make install` and `make install-doc` * un * `ruby -run` is one of cool feature of Ruby. Should we avoid uninstalling `un` gem? * singleton * This is famous design pattern. Should we enforce users add them to their Gemfile? * forwadable * `reline` needs to add forwardable their `runtime_dependency` after migration. * weakref * I'm not sure how impact after migrating bundled gems. * fcntl * Should we integrate these constants into ruby core? I would like to migrate `ipaddr` and `uri` too. But these are used by webrick that is mock server for our test suite. We need to rewrite `webrick` with `TCPSocker` or extract `ipaddr` and `uri` dependency from `webrick` Other default gems depend on our build process or other libraries deeply. I will update this proposal if I could extract them from default gems. -- https://bugs.ruby-lang.org/

Issue #20309 has been updated by Eregon (Benoit Daloze). @hsbt What about [yaml](https://github.com/ruby/yaml/blob/master/lib/yaml.rb) and [readline](https://github.com/ruby/readline/blob/master/lib/readline.rb)? I think these are not worth moving to bundled gems, i.e. the gains are (AFAIK) very small while the costs and confusion are high. I think so because the code for these 2 trivial "loaders/wrappers" (see links above) almost never changes (so the overhead of keeping them in sync is basically 0, probably 0 security issues in that code, etc). There seems to be no value to use track `readline` 0.0.4 vs `readline` 0.0.5 in a Gemfile.lock for instance, as the only likely changes would be to adapt to some incompatible change in Ruby, and then that's useless since the right version would be shipped with Ruby. The main problem there/my main concern is the cost, many people would need to add `gem "readline"` or `gem "yaml"` to their Gemfile for Ruby 3.5, and gain basically nothing from it, so it would be almost pure overhead. Also depending on `gem "yaml"` alone is not a good idea, because it doesn't mean any specific major version of `psych`. So one needs `gem "psych"` anyway, and the `gem "yaml"` is redundant. To try to quantify that I looked at * https://rubygems.org/gems/readline/reverse_dependencies: only 5 gems depend on readline right now. Yet there are 371+1158 matches for `gem-codesearch 'require "readline"'`+`gem-codesearch "require 'readline'"`. All these gems would need to add `gem "readline"`, for no gain. * https://rubygems.org/gems/psych/reverse_dependencies vs https://rubygems.org/gems/yaml/reverse_dependencies. There are about 18x (54M/3M) as much downloads for `psych` than `yaml`. RubyGems.org doesn't show a total count for reverse dependencies but it seems clear few gems depend on `yaml`, much much more depend on `psych`. All the gems depending on `psych` and not `yaml` would need changes. One more thing, as far as I can see, `psych` is a default gem. Having `yaml` as a bundled gem while `psych` is a default gem would lead to an awkward situation that when run under bundler and not adding either to the Gemfile, one can `require "psych"` but cannot `require "yaml"`. So they could use `Psych` in code but not `YAML` which feels a wrong limitation (people might just do YAML=Psych themselves as a workaround, but then that could cause warnings). So it seems clear `yaml` shouldn't become bundled gem before `psych` at least. And I think psych cannot become a bundled gem because RubyGems needs it. ---------------------------------------- Feature #20309: Bundled gems for Ruby 3.5 https://bugs.ruby-lang.org/issues/20309#change-107248 * Author: hsbt (Hiroshi SHIBATA) * Status: Assigned * Assignee: hsbt (Hiroshi SHIBATA) ---------------------------------------- I propose migrate the following default gems to bundled gems at Ruby 3.5. So, It means users will get warnings if users try to load them. (Update with 2024/03/14) * ostruct * I make ostruct as optional on json at https://github.com/flori/json/pull/565 * logger * activesupport needs to add logger to its dependency same as bigdecimal, drb or etc. * fiddle * pstore * win32ole I have a plan to migrate the following default gems too. But I need to more feedback from other committers about them. * irb * We need to consider how works `binding.irb` after Ruby 3.5. * I consider to use `irb` without Gemfile. * reline * readline (wrapper file for readline-ext and reline) * io-console * rubygems uses that. Should we make optional that? * open-uri * yaml (wrapper file for psych) * syck is retired today. I'm not sure what people uses `psych` directly, not `yaml`. * rdoc * We need to change build task like download rdoc gem before document generation. * extract `make doc` from `make all` and invoke `make doc` before `make install`. * or We make document generation is optional from Ruby 3.5 * We explicitly separate `make install` and `make install-doc` * un * `ruby -run` is one of cool feature of Ruby. Should we avoid uninstalling `un` gem? * mkmf uses `ruby -run` for that. I need to investigate that. * singleton * This is famous design pattern. Should we enforce users add them to their Gemfile? * forwadable * `reline` needs to add forwardable their `runtime_dependency` after migration. * weakref * I'm not sure how impact after migrating bundled gems. * fcntl * Should we integrate these constants into ruby core? I would like to migrate `ipaddr` and `uri` too. But these are used by webrick that is mock server for our test suite. We need to rewrite `webrick` with `TCPSocker` or extract `ipaddr` and `uri` dependency from `webrick` Other default gems depend on our build process or other libraries deeply. I will update this proposal if I could extract them from default gems. -- https://bugs.ruby-lang.org/

Issue #20309 has been updated by Eregon (Benoit Daloze). OK, thank you. I wanted to make sure my concern on that is clear. At least it seems useful to have some data and extra details on it (the last paragraph). ---------------------------------------- Feature #20309: Bundled gems for Ruby 3.5 https://bugs.ruby-lang.org/issues/20309#change-107266 * Author: hsbt (Hiroshi SHIBATA) * Status: Assigned * Assignee: hsbt (Hiroshi SHIBATA) ---------------------------------------- I propose migrate the following default gems to bundled gems at Ruby 3.5. So, It means users will get warnings if users try to load them. (Update with 2024/03/14) * ostruct * I make ostruct as optional on json at https://github.com/flori/json/pull/565 * logger * activesupport needs to add logger to its dependency same as bigdecimal, drb or etc. * fiddle * pstore * win32ole I have a plan to migrate the following default gems too. But I need to more feedback from other committers about them. * irb * We need to consider how works `binding.irb` after Ruby 3.5. * I consider to use `irb` without Gemfile. * reline * readline (wrapper file for readline-ext and reline) * io-console * rubygems uses that. Should we make optional that? * open-uri * yaml (wrapper file for psych) * syck is retired today. I'm not sure what people uses `psych` directly, not `yaml`. * rdoc * We need to change build task like download rdoc gem before document generation. * extract `make doc` from `make all` and invoke `make doc` before `make install`. * or We make document generation is optional from Ruby 3.5 * We explicitly separate `make install` and `make install-doc` * un * `ruby -run` is one of cool feature of Ruby. Should we avoid uninstalling `un` gem? * mkmf uses `ruby -run` for that. I need to investigate that. * singleton * This is famous design pattern. Should we enforce users add them to their Gemfile? * forwadable * `reline` needs to add forwardable their `runtime_dependency` after migration. * weakref * I'm not sure how impact after migrating bundled gems. * fcntl * Should we integrate these constants into ruby core? I would like to migrate `ipaddr` and `uri` too. But these are used by webrick that is mock server for our test suite. We need to rewrite `webrick` with `TCPSocker` or extract `ipaddr` and `uri` dependency from `webrick` Other default gems depend on our build process or other libraries deeply. I will update this proposal if I could extract them from default gems. -- https://bugs.ruby-lang.org/

Issue #20309 has been updated by Eregon (Benoit Daloze). I wonder if making `win32ole` a bundled gem is a good idea. From what I have seen the consequence of such changes seems in most cases to encourage gems to drop the dependency on the newly-bundled gem. That may be good for e.g. ostruct which is kind of self-deprecated (due to horrible performance and messy semantics). But it may be bad for `win32ole`, because the alternatives may be slower or less reliable, e.g. see the discussion [here](https://github.com/ruby-concurrency/concurrent-ruby/pull/1053) where it's all too easy to regress from 60ms to 1s. I don't think many gems will consider adding `win32ole` as a dependency, because it looks very weird for usages of the gem on non-Windows. Even though the gem does seem to install OK on non-Windows, when installing CRuby on non-Windows, win32ole has never been installed as a default gem, so it looks unexpected to even install that gem. ---------------------------------------- Feature #20309: Bundled gems for Ruby 3.5 https://bugs.ruby-lang.org/issues/20309#change-108760 * Author: hsbt (Hiroshi SHIBATA) * Status: Assigned * Assignee: hsbt (Hiroshi SHIBATA) ---------------------------------------- I propose migrate the following default gems to bundled gems at Ruby 3.5. So, It means users will get warnings if users try to load them. (Update with 2024/03/14, 2024/06/05) * rdoc(done) * We need to change build task like download rdoc gem before document generation. * extract `make doc` from `make all` and invoke `make doc` before `make install`. * done for Ruby 3.4 * or We make document generation is optional from Ruby 3.5 * We explicitly separate `make install` and `make install-doc` * ostruct(done) * I make ostruct as optional on json at https://github.com/flori/json/pull/565 * pstore(done) * win32ole(done) * logger(done) * activesupport needs to add logger to its dependency same as bigdecimal, drb or etc. * fiddle(done) I have a plan to migrate the following default gems too. But I need to more feedback from other committers about them. * irb * We need to consider how works `binding.irb` after Ruby 3.5. * I consider to use `irb` without Gemfile. * reline * readline (wrapper file for readline-ext and reline) * io-console * rubygems uses that. Should we make optional that? * open-uri * yaml (wrapper file for psych) * syck is retired today. I'm not sure what people uses `psych` directly, not `yaml`. * un * `ruby -run` is one of cool feature of Ruby. Should we avoid uninstalling `un` gem? * mkmf uses `ruby -run` for that. I need to investigate that. * singleton * This is famous design pattern. Should we enforce users add them to their Gemfile? * forwadable * `reline` needs to add forwardable their `runtime_dependency` after migration. * weakref * I'm not sure how impact after migrating bundled gems. * fcntl * Should we integrate these constants into ruby core? I would like to migrate `ipaddr` and `uri` too. But these are used by webrick that is mock server for our test suite. We need to rewrite `webrick` with `TCPSocker` or extract `ipaddr` and `uri` dependency from `webrick` Other default gems depend on our build process or other libraries deeply. I will update this proposal if I could extract them from default gems. -- https://bugs.ruby-lang.org/

Issue #20309 has been updated by Earlopain (A S). I guess I can share my opinion here. There definitely is a benefit in bundling some gems, both from a ruby maintainer and security perspective. But with things like `benchmark`, `forwardable`, `singleton`, (or `base64`, `mutex_m` from the previous issue) I am hardpressed to actually include these into the dependency graph. Many libraries depend on them, and usually the usage is trivial. For `base64`, it's just a different, though less beautifully named method invocation (if you don't use the url-safe variants). `singleton` and `forwardable` are what I would consider syntactic sugar. I'm not going to add a dependency just for that, I will instead forgoe the small ergonomics I'd gain and go with the manual solution. Note this is purely from a library perspective. End consumers are free to do what they want but if I can do the same thing myself in maybe 1 or 2 lines more I'm just going to do that. From PRs I've opened against other projects, maintainers tend to agree. Adding a dependency just for that usually isn't justifiable. ---------------------------------------- Feature #20309: Bundled gems for Ruby 3.5 https://bugs.ruby-lang.org/issues/20309#change-109568 * Author: hsbt (Hiroshi SHIBATA) * Status: Assigned * Assignee: hsbt (Hiroshi SHIBATA) ---------------------------------------- I propose migrate the following default gems to bundled gems at Ruby 3.5. So, It means users will get warnings if users try to load them. (Update with 2024/03/14, 2024/06/05) * rdoc(done) * We need to change build task like download rdoc gem before document generation. * extract `make doc` from `make all` and invoke `make doc` before `make install`. * done for Ruby 3.4 * or We make document generation is optional from Ruby 3.5 * We explicitly separate `make install` and `make install-doc` * ostruct(done) * I make ostruct as optional on json at https://github.com/flori/json/pull/565 * pstore(done) * win32ole(done) * logger(done) * activesupport needs to add logger to its dependency same as bigdecimal, drb or etc. * fiddle(done) * benchmark I have a plan to migrate the following default gems too. But I need to more feedback from other committers about them. * irb * We need to consider how works `binding.irb` after Ruby 3.5. * I consider to use `irb` without Gemfile. * reline * readline (wrapper file for readline-ext and reline) * io-console * rubygems uses that. Should we make optional that? * open-uri * yaml (wrapper file for psych) * syck is retired today. I'm not sure what people uses `psych` directly, not `yaml`. * un * `ruby -run` is one of cool feature of Ruby. Should we avoid uninstalling `un` gem? * mkmf uses `ruby -run` for that. I need to investigate that. * singleton * This is famous design pattern. Should we enforce users add them to their Gemfile? * forwadable * `reline` needs to add forwardable their `runtime_dependency` after migration. * weakref * I'm not sure how impact after migrating bundled gems. * fcntl * Should we integrate these constants into ruby core? I would like to migrate `ipaddr` and `uri` too. But these are used by webrick that is mock server for our test suite. We need to rewrite `webrick` with `TCPSocker` or extract `ipaddr` and `uri` dependency from `webrick` Other default gems depend on our build process or other libraries deeply. I will update this proposal if I could extract them from default gems. -- https://bugs.ruby-lang.org/

Issue #20309 has been updated by ima1zumi (Mari Imaizumi). Does this change mean that even if Ruby is installed, the irb command will no longer be available? If that is the case, I oppose it for the following reasons: - Existing learning materials will no longer work as-is, causing confusion for beginners. - IRB would need to be reinstalled every time Ruby is reinstalled. I believe removing IRB would significantly disadvantage users. ---------------------------------------- Feature #20309: Bundled gems for Ruby 3.5 https://bugs.ruby-lang.org/issues/20309#change-109672 * Author: hsbt (Hiroshi SHIBATA) * Status: Assigned * Assignee: hsbt (Hiroshi SHIBATA) ---------------------------------------- I propose migrate the following default gems to bundled gems at Ruby 3.5. So, It means users will get warnings if users try to load them. (Update with 2024/03/14, 2024/06/05, 2024/09/06) * rdoc(done) * We need to change build task like download rdoc gem before document generation. * extract `make doc` from `make all` and invoke `make doc` before `make install`. * done for Ruby 3.4 * or We make document generation is optional from Ruby 3.5 * We explicitly separate `make install` and `make install-doc` * ostruct(done) * I make ostruct as optional on json at https://github.com/flori/json/pull/565 * pstore(done) * win32ole(done) * logger(done) * activesupport needs to add logger to its dependency same as bigdecimal, drb or etc. * fiddle(done) * benchmark * irb * We need to consider how works `binding.irb` after Ruby 3.5. * I consider to use `irb` without Gemfile. * reline * readline (wrapper file for readline-ext and reline) I have a plan to migrate the following default gems too. But I need to more feedback from other committers about them. * io-console * rubygems uses that. Should we make optional that? * open-uri * yaml (wrapper file for psych) * syck is retired today. I'm not sure what people uses `psych` directly, not `yaml`. * un * `ruby -run` is one of cool feature of Ruby. Should we avoid uninstalling `un` gem? * mkmf uses `ruby -run` for that. I need to investigate that. * singleton * This is famous design pattern. Should we enforce users add them to their Gemfile? * forwadable * `reline` needs to add forwardable their `runtime_dependency` after migration. * weakref * I'm not sure how impact after migrating bundled gems. * fcntl * Should we integrate these constants into ruby core? I would like to migrate `ipaddr` and `uri` too. But these are used by webrick that is mock server for our test suite. We need to rewrite `webrick` with `TCPSocker` or extract `ipaddr` and `uri` dependency from `webrick` Other default gems depend on our build process or other libraries deeply. I will update this proposal if I could extract them from default gems. -- https://bugs.ruby-lang.org/

Issue #20309 has been updated by ima1zumi (Mari Imaizumi).

No. irb is available as bundled gems.

Sorry, I misunderstood. ---------------------------------------- Feature #20309: Bundled gems for Ruby 3.5 https://bugs.ruby-lang.org/issues/20309#change-109688 * Author: hsbt (Hiroshi SHIBATA) * Status: Assigned * Assignee: hsbt (Hiroshi SHIBATA) ---------------------------------------- I propose migrate the following default gems to bundled gems at Ruby 3.5. So, It means users will get warnings if users try to load them. (Update with 2024/03/14, 2024/06/05, 2024/09/06) * rdoc(done) * We need to change build task like download rdoc gem before document generation. * extract `make doc` from `make all` and invoke `make doc` before `make install`. * done for Ruby 3.4 * or We make document generation is optional from Ruby 3.5 * We explicitly separate `make install` and `make install-doc` * ostruct(done) * I make ostruct as optional on json at https://github.com/flori/json/pull/565 * pstore(done) * win32ole(done) * logger(done) * activesupport needs to add logger to its dependency same as bigdecimal, drb or etc. * fiddle(done) * benchmark * irb * We need to consider how works `binding.irb` after Ruby 3.5. * I consider to use `irb` without Gemfile. * reline * readline (wrapper file for readline-ext and reline) I have a plan to migrate the following default gems too. But I need to more feedback from other committers about them. * io-console * rubygems uses that. Should we make optional that? * open-uri * yaml (wrapper file for psych) * syck is retired today. I'm not sure what people uses `psych` directly, not `yaml`. * un * `ruby -run` is one of cool feature of Ruby. Should we avoid uninstalling `un` gem? * mkmf uses `ruby -run` for that. I need to investigate that. * singleton * This is famous design pattern. Should we enforce users add them to their Gemfile? * forwadable * `reline` needs to add forwardable their `runtime_dependency` after migration. * weakref * I'm not sure how impact after migrating bundled gems. * fcntl * Should we integrate these constants into ruby core? I would like to migrate `ipaddr` and `uri` too. But these are used by webrick that is mock server for our test suite. We need to rewrite `webrick` with `TCPSocker` or extract `ipaddr` and `uri` dependency from `webrick` Other default gems depend on our build process or other libraries deeply. I will update this proposal if I could extract them from default gems. -- https://bugs.ruby-lang.org/

Issue #20309 has been updated by Eregon (Benoit Daloze). There is an additional issue with making fiddle a bundled gem: it means any usage now must have libffi headers available or it will fail to install. Before, it would just work because fiddle would have been built when CRuby was built. Seen in https://github.com/ffi/ffi/actions/runs/10881406447/job/30190385022?pr=1119: ``` extconf.rb:78:in `<main>': missing libffi. Please install libffi or use --with-libffi-source-dir with libffi source location. (RuntimeError) ``` From https://github.com/ffi/ffi/pull/1119 ---------------------------------------- Feature #20309: Bundled gems for Ruby 3.5 https://bugs.ruby-lang.org/issues/20309#change-109794 * Author: hsbt (Hiroshi SHIBATA) * Status: Assigned * Assignee: hsbt (Hiroshi SHIBATA) ---------------------------------------- I propose migrate the following default gems to bundled gems at Ruby 3.5. So, It means users will get warnings if users try to load them. (Update with 2024/03/14, 2024/06/05, 2024/09/06) * rdoc(done) * We need to change build task like download rdoc gem before document generation. * extract `make doc` from `make all` and invoke `make doc` before `make install`. * done for Ruby 3.4 * or We make document generation is optional from Ruby 3.5 * We explicitly separate `make install` and `make install-doc` * ostruct(done) * I make ostruct as optional on json at https://github.com/flori/json/pull/565 * pstore(done) * win32ole(done) * logger(done) * activesupport needs to add logger to its dependency same as bigdecimal, drb or etc. * fiddle(done) * benchmark * irb * We need to consider how works `binding.irb` after Ruby 3.5. * I consider to use `irb` without Gemfile. * reline * readline (wrapper file for readline-ext and reline) I have a plan to migrate the following default gems too. But I need to more feedback from other committers about them. * io-console * rubygems uses that. Should we make optional that? * open-uri * yaml (wrapper file for psych) * syck is retired today. I'm not sure what people uses `psych` directly, not `yaml`. * un * `ruby -run` is one of cool feature of Ruby. Should we avoid uninstalling `un` gem? * mkmf uses `ruby -run` for that. I need to investigate that. * singleton * This is famous design pattern. Should we enforce users add them to their Gemfile? * forwadable * `reline` needs to add forwardable their `runtime_dependency` after migration. * weakref * I'm not sure how impact after migrating bundled gems. * fcntl * Should we integrate these constants into ruby core? I would like to migrate `ipaddr` and `uri` too. But these are used by webrick that is mock server for our test suite. We need to rewrite `webrick` with `TCPSocker` or extract `ipaddr` and `uri` dependency from `webrick` Other default gems depend on our build process or other libraries deeply. I will update this proposal if I could extract them from default gems. -- https://bugs.ruby-lang.org/

Issue #20309 has been updated by hsbt (Hiroshi SHIBATA).

The fact that we want binding.irb to work regardless of being in a bundle exec context or not feels like a sign that irb should probably stay as a default gem?

I don't think so. Bundler should provide that feature for like `debug`, `stackprof` and `irb`. I and @mame discussed about that. We sometimes need to use that tools without updating Gemfile and its lockfile. ---------------------------------------- Feature #20309: Bundled gems for Ruby 3.5 https://bugs.ruby-lang.org/issues/20309#change-109816 * Author: hsbt (Hiroshi SHIBATA) * Status: Assigned * Assignee: hsbt (Hiroshi SHIBATA) ---------------------------------------- I propose migrate the following default gems to bundled gems at Ruby 3.5. So, It means users will get warnings if users try to load them. (Update with 2024/03/14, 2024/06/05, 2024/09/06) * rdoc(done) * We need to change build task like download rdoc gem before document generation. * extract `make doc` from `make all` and invoke `make doc` before `make install`. * done for Ruby 3.4 * or We make document generation is optional from Ruby 3.5 * We explicitly separate `make install` and `make install-doc` * ostruct(done) * I make ostruct as optional on json at https://github.com/flori/json/pull/565 * pstore(done) * win32ole(done) * logger(done) * activesupport needs to add logger to its dependency same as bigdecimal, drb or etc. * fiddle(done) * benchmark * irb * We need to consider how works `binding.irb` after Ruby 3.5. * I consider to use `irb` without Gemfile. * reline * readline (wrapper file for readline-ext and reline) I have a plan to migrate the following default gems too. But I need to more feedback from other committers about them. * io-console * rubygems uses that. Should we make optional that? * open-uri * yaml (wrapper file for psych) * syck is retired today. I'm not sure what people uses `psych` directly, not `yaml`. * un * `ruby -run` is one of cool feature of Ruby. Should we avoid uninstalling `un` gem? * mkmf uses `ruby -run` for that. I need to investigate that. * singleton * This is famous design pattern. Should we enforce users add them to their Gemfile? * forwadable * `reline` needs to add forwardable their `runtime_dependency` after migration. * weakref * I'm not sure how impact after migrating bundled gems. * fcntl * Should we integrate these constants into ruby core? I would like to migrate `ipaddr` and `uri` too. But these are used by webrick that is mock server for our test suite. We need to rewrite `webrick` with `TCPSocker` or extract `ipaddr` and `uri` dependency from `webrick` Other default gems depend on our build process or other libraries deeply. I will update this proposal if I could extract them from default gems. -- https://bugs.ruby-lang.org/

Issue #20309 has been updated by Eregon (Benoit Daloze). vo.x (Vit Ondruch) wrote in #note-35:

I don't think it is bad idea to start using `bundle install --local`, i.e. use gems which are already available on the system. And on top of that, stop using Bundler in containers for runtime in production use.

Do you mean `--prefer-local`? I don't think `--local` would work in general since that does not attempt to connect to rubygems.org at all. From the docs it's not clear if either of them would reuse bundled gems: ``` --local Do not attempt to connect to rubygems.org. Instead, Bundler will use the gems already present in Rubygems' cache or in vendor/cache. Note that if an appropriate platform-specific gem exists on rubygems.org it will not be found. --prefer-local Force using locally installed gems, or gems already present in Rubygems' cache or in vendor/cache, when resolving, even if newer versions are available remotely. Only attempt to connect to rubygems.org for gems that are not present locally. ``` + the version would need to match the bundled gem version in the Gemfile.lock, which I'm not sure there is any easy way to do that. But it would be nice, yeah, for Bundler to have a way to reuse bundled & default gems when possible, at resolution (`bundle lock`) and install time. ---------------------------------------- Feature #20309: Bundled gems for Ruby 3.5 https://bugs.ruby-lang.org/issues/20309#change-109819 * Author: hsbt (Hiroshi SHIBATA) * Status: Assigned * Assignee: hsbt (Hiroshi SHIBATA) ---------------------------------------- I propose migrate the following default gems to bundled gems at Ruby 3.5. So, It means users will get warnings if users try to load them. (Update with 2024/03/14, 2024/06/05, 2024/09/06) * rdoc(done) * We need to change build task like download rdoc gem before document generation. * extract `make doc` from `make all` and invoke `make doc` before `make install`. * done for Ruby 3.4 * or We make document generation is optional from Ruby 3.5 * We explicitly separate `make install` and `make install-doc` * ostruct(done) * I make ostruct as optional on json at https://github.com/flori/json/pull/565 * pstore(done) * win32ole(done) * logger(done) * activesupport needs to add logger to its dependency same as bigdecimal, drb or etc. * fiddle(done) * benchmark * irb * We need to consider how works `binding.irb` after Ruby 3.5. * I consider to use `irb` without Gemfile. * reline * readline (wrapper file for readline-ext and reline) I have a plan to migrate the following default gems too. But I need to more feedback from other committers about them. * io-console * rubygems uses that. Should we make optional that? * open-uri * yaml (wrapper file for psych) * syck is retired today. I'm not sure what people uses `psych` directly, not `yaml`. * un * `ruby -run` is one of cool feature of Ruby. Should we avoid uninstalling `un` gem? * mkmf uses `ruby -run` for that. I need to investigate that. * singleton * This is famous design pattern. Should we enforce users add them to their Gemfile? * forwadable * `reline` needs to add forwardable their `runtime_dependency` after migration. * weakref * I'm not sure how impact after migrating bundled gems. * fcntl * Should we integrate these constants into ruby core? I would like to migrate `ipaddr` and `uri` too. But these are used by webrick that is mock server for our test suite. We need to rewrite `webrick` with `TCPSocker` or extract `ipaddr` and `uri` dependency from `webrick` Other default gems depend on our build process or other libraries deeply. I will update this proposal if I could extract them from default gems. -- https://bugs.ruby-lang.org/

Issue #20309 has been updated by hsbt (Hiroshi SHIBATA). Status changed from Assigned to Closed I migrated all of target gems to bundled gems in master branch. @k0kubun FYI: I added workaround to load fiddle from bundled gems at rjit.rb now. https://github.com/ruby/ruby/blob/master/rjit.rb#L33 This workaround should be removed from rjit.rb. I will do that until final release or Ruby 3.5. ---------------------------------------- Feature #20309: Bundled gems for Ruby 3.5 https://bugs.ruby-lang.org/issues/20309#change-111763 * Author: hsbt (Hiroshi SHIBATA) * Status: Closed * Assignee: hsbt (Hiroshi SHIBATA) ---------------------------------------- I propose migrate the following default gems to bundled gems at Ruby 3.5. So, It means users will get warnings if users try to load them. (Update with 2024/03/14, 2024/06/05, 2024/09/06) * rdoc(done) * We need to change build task like download rdoc gem before document generation. * extract `make doc` from `make all` and invoke `make doc` before `make install`. * done for Ruby 3.4 * or We make document generation is optional from Ruby 3.5 * We explicitly separate `make install` and `make install-doc` * ostruct(done) * I make ostruct as optional on json at https://github.com/flori/json/pull/565 * pstore(done) * win32ole(done) * logger(done) * activesupport needs to add logger to its dependency same as bigdecimal, drb or etc. * fiddle(done) * benchmark * irb * We need to consider how works `binding.irb` after Ruby 3.5. * I consider to use `irb` without Gemfile. * reline * readline (wrapper file for readline-ext and reline) I have a plan to migrate the following default gems too. But I need to more feedback from other committers about them. * io-console * rubygems uses that. Should we make optional that? * open-uri * yaml (wrapper file for psych) * syck is retired today. I'm not sure what people uses `psych` directly, not `yaml`. * un * `ruby -run` is one of cool feature of Ruby. Should we avoid uninstalling `un` gem? * mkmf uses `ruby -run` for that. I need to investigate that. * singleton * This is famous design pattern. Should we enforce users add them to their Gemfile? * forwadable * `reline` needs to add forwardable their `runtime_dependency` after migration. * weakref * I'm not sure how impact after migrating bundled gems. * fcntl * Should we integrate these constants into ruby core? I would like to migrate `ipaddr` and `uri` too. But these are used by webrick that is mock server for our test suite. We need to rewrite `webrick` with `TCPSocker` or extract `ipaddr` and `uri` dependency from `webrick` Other default gems depend on our build process or other libraries deeply. I will update this proposal if I could extract them from default gems. -- https://bugs.ruby-lang.org/