[ruby-core:113332] [Ruby master Bug#19616] Remove ext/readline from Ruby 3.3

Issue #19616 has been reported by hsbt (Hiroshi SHIBATA). ---------------------------------------- Bug #19616: Remove ext/readline from Ruby 3.3 https://bugs.ruby-lang.org/issues/19616 * Author: hsbt (Hiroshi SHIBATA) * Status: Open * Priority: Normal * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- We still bundled ext/readline that is GNU Readline wrapper. But we already have reline written by pure Ruby. It's time to remove it from Ruby releases. Motivation: * We can skip to install readline or libedit for testing ruby language. * I hope to reduce external dependencies from the perspective of ruby-build maintainer. If users hope to use ext/readline, they can install it with `gem install readline-ext`. -- https://bugs.ruby-lang.org/

Issue #19616 has been updated by Eregon (Benoit Daloze). I suspect a fair amount of code still uses `Readline.readline`. Would it make sense if we had a `readline.rb` which is just `require "reline"; Readline = Reline`? Then also we would no longer need to maintain https://github.com/ruby/readline-ext anymore. A big part of my concern here is other Ruby implementations like JRuby and TruffleRuby have their own implementations of Readline (using JLine). It would be great if we can drop them rather than keep maintaining them, but we can only do so if the readline-ext gem is not used much in practice. Hence if readline-ext would just reuse reline, then we can truly drop the dependency on libreadline and don't need to maintain code linking to it at all anymore (neither the C extension and neither Readline-JLine). ---------------------------------------- Bug #19616: Remove ext/readline from Ruby 3.3 https://bugs.ruby-lang.org/issues/19616#change-102894 * Author: hsbt (Hiroshi SHIBATA) * Status: Open * Priority: Normal * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- We still bundled ext/readline that is GNU Readline wrapper. But we already have reline written by pure Ruby. It's time to remove it from Ruby releases. Motivation: * We can skip to install readline or libedit for testing ruby language. * I hope to reduce external dependencies from the perspective of ruby-build maintainer. If users hope to use ext/readline, they can install it with `gem install readline-ext`. -- https://bugs.ruby-lang.org/

Issue #19616 has been updated by hsbt (Hiroshi SHIBATA).
Would it make sense if we had a readline.rb which is just require "reline"; Readline = Reline?
We already have it: https://github.com/ruby/readline/blob/master/lib/readline.rb ---------------------------------------- Feature #19616: Remove ext/readline from Ruby 3.3 https://bugs.ruby-lang.org/issues/19616#change-102896 * Author: hsbt (Hiroshi SHIBATA) * Status: Open * Priority: Normal ---------------------------------------- We still bundled ext/readline that is GNU Readline wrapper. But we already have reline written by pure Ruby. It's time to remove it from Ruby releases. Motivation: * We can skip to install readline or libedit for testing ruby language. * I hope to reduce external dependencies from the perspective of ruby-build maintainer. If users hope to use ext/readline, they can install it with `gem install readline-ext`. -- https://bugs.ruby-lang.org/

Issue #19616 has been updated by Eregon (Benoit Daloze). Oh this is great, I missed it. +1 from me. ---------------------------------------- Feature #19616: Remove ext/readline from Ruby 3.3 https://bugs.ruby-lang.org/issues/19616#change-102902 * Author: hsbt (Hiroshi SHIBATA) * Status: Open * Priority: Normal ---------------------------------------- We still bundled ext/readline that is GNU Readline wrapper. But we already have reline written by pure Ruby. It's time to remove it from Ruby releases. Motivation: * We can skip to install readline or libedit for testing ruby language. * I hope to reduce external dependencies from the perspective of ruby-build maintainer. If users hope to use ext/readline, they can install it with `gem install readline-ext`. -- https://bugs.ruby-lang.org/

Issue #19616 has been updated by hsbt (Hiroshi SHIBATA). https://github.com/ruby/ruby/pull/7781 ---------------------------------------- Feature #19616: Remove ext/readline from Ruby 3.3 https://bugs.ruby-lang.org/issues/19616#change-102959 * Author: hsbt (Hiroshi SHIBATA) * Status: Open * Priority: Normal ---------------------------------------- We still bundled ext/readline that is GNU Readline wrapper. But we already have reline written by pure Ruby. It's time to remove it from Ruby releases. Motivation: * We can skip to install readline or libedit for testing ruby language. * I hope to reduce external dependencies from the perspective of ruby-build maintainer. If users hope to use ext/readline, they can install it with `gem install readline-ext`. -- https://bugs.ruby-lang.org/

Issue #19616 has been updated by hsbt (Hiroshi SHIBATA). Status changed from Open to Closed I removed `ext/readline` at https://github.com/ruby/ruby/commit/59fd67fc3d405e529e038172e769ff20a8fb5535 Welcome comments for migrating to `reline` if you have concern. ---------------------------------------- Feature #19616: Remove ext/readline from Ruby 3.3 https://bugs.ruby-lang.org/issues/19616#change-102997 * Author: hsbt (Hiroshi SHIBATA) * Status: Closed * Priority: Normal ---------------------------------------- We still bundled ext/readline that is GNU Readline wrapper. But we already have reline written by pure Ruby. It's time to remove it from Ruby releases. Motivation: * We can skip to install readline or libedit for testing ruby language. * I hope to reduce external dependencies from the perspective of ruby-build maintainer. If users hope to use ext/readline, they can install it with `gem install readline-ext`. -- https://bugs.ruby-lang.org/

Issue #19616 has been updated by Eregon (Benoit Daloze). I noticed Rails's Gemfile added a dependency to readline-ext in https://github.com/rails/rails/commit/a6e0b0acb2d1e85a8f90bdf956e7549bcad468... due to some incompatibility. I filed https://github.com/ruby/reline/issues/546 to hopefully resolve that incompatibility. ---------------------------------------- Feature #19616: Remove ext/readline from Ruby 3.3 https://bugs.ruby-lang.org/issues/19616#change-103380 * Author: hsbt (Hiroshi SHIBATA) * Status: Closed * Priority: Normal ---------------------------------------- We still bundled ext/readline that is GNU Readline wrapper. But we already have reline written by pure Ruby. It's time to remove it from Ruby releases. Motivation: * We can skip to install readline or libedit for testing ruby language. * I hope to reduce external dependencies from the perspective of ruby-build maintainer. If users hope to use ext/readline, they can install it with `gem install readline-ext`. -- https://bugs.ruby-lang.org/
participants (3)
-
Eregon (Benoit Daloze)
-
Eregon (Benoit Daloze)
-
hsbt (Hiroshi SHIBATA)