[ruby-core:127537] [Ruby Feature#14915] Deprecate String#crypt
Issue #14915 has been updated by yahonda (Yasuo Honda). One thing has changed since this ticket was closed in 2019: `crypt(3)` is no longer always available when Ruby is built on Linux. * glibc removed libcrypt in 2.39 ( https://sourceware.org/git/?p=glibc.git;a=commit;h=e6e3c666880847ad908692087... ). It is now provided by libxcrypt, a separate library. * On Debian 14 and Ubuntu 26.04, its development files (`libcrypt-dev`) are no longer installed together with `libc6-dev`, as reported in #note-55 and #note-57. Ruby has replaced a missing `crypt` with the DES-only `missing/crypt.c` since the initial revision of the repository ( https://github.com/ruby/ruby/blob/76fe737ef34e8e9de561cb7a25ec33b14c7ab937/c... ). This fallback did not happen on Linux in 2019. Now it does, and the same code silently returns a different result. ```ruby "secret".crypt("$6$saltsalt$") # built with libcrypt-dev => "$6$saltsalt$TVLlQcbp..." (SHA-512) # built without libcrypt-dev => "$6/iozuRTIzwY" (DES) ``` For comparison, OpenBSD 8.0 still has `crypt(3)`, but it supports only bcrypt, so Ruby 4.0.9 there raises `Errno::EINVAL` for this call. ---------------------------------------- Feature #14915: Deprecate String#crypt https://bugs.ruby-lang.org/issues/14915#change-120012 * Author: jeremyevans0 (Jeremy Evans) * Status: Rejected ---------------------------------------- This method is system and implementation dependent, and the portable usage mentioned in the documentation is not truly portable (doesn't work on OpenBSD) and insecure as it uses DES. For systems that lack a crypt(3) implementation, Ruby will happily substitute a version that only supports DES. It's 2018, using DES should be avoided if at all possible. The only internal usage of String#crypt in Ruby is in Webrick, where it uses DES for basic authentication with an htpasswd file. That could and should be changed to use a more secure hash by default (bcrypt since that's the most secure htpasswd format), or at least allow the user to customize Webrick's authentication. I expect there are few if any users actively using Webrick's htpasswd support. This moves the String#crypt implementation to the string/crypt extension, but leaves the String#crypt core method. The core method prints a deprecation warning, then loads the string/crypt extension. The string/crypt extension undefines the String#crypt core method, then defines the previous implementation. Because extensions use extconf.rb instead of configure for their configuration, this ports the related configure.ac code to extconf.rb. I'm not sure that is done correctly and works on all platforms, it will need testing. For systems that lack a crypt(3) implementation, this modifies the fallback code to only define crypt_r, since that is the only function that String#crypt will call in that case. While the patch just deprecates String#crypt, I think we should plan to remove support from ruby: 2.6: core method deprecated 2.7: core method removed, string/crypt extension ships with ruby 2.8: string/crypt extension moves to external gem, not shipped ---Files-------------------------------- 0001-Deprecate-String-crypt-move-implementation-to-string.patch (20.5 KB) 0001-Deprecate-String-crypt.patch (7.48 KB) 0001-Deprecate-String-crypt.patch (7.35 KB) 0001-Deprecate-String-crypt.patch (7.43 KB) deprecate-string-crypt.patch (6.7 KB) -- https://bugs.ruby-lang.org/
participants (1)
-
yahonda (Yasuo Honda)