Issue #19839 has been updated by baweaver (Brandon Weaver). I've made several helpers for this exact same problem, as well as a `Range#merge` in the past. I would very much be in favor of this change. Example usage from an interview problem, though I have some internal usecases which have done similar: https://gist.github.com/baweaver/5dbca4296db0651de41267c2c1267c68 The idea for this was to bold targeted segments of a `String` like: ```ruby Emboldener.new(text: "aaabbcc", targets: ["aaa","aab","bc"]).run ``` ...and have intersections merged. Granted this also brings up an interesting follow-up potential of merging ranges and if they happen to be left or right biased: ```ruby private def merge_range(a, b) return Range.new(a.begin, b.end) if a.cover?(b.begin) return Range.new(b.begin, a.end) if b.cover?(a.begin) nil end ``` In any case the `overlap?` method would be very handy to me for a number of use-cases. ---------------------------------------- Feature #19839: Need a method to check if two ranges overlap https://bugs.ruby-lang.org/issues/19839#change-104151 * Author: shouichi (Shouichi KAMIYA) * Status: Open * Priority: Normal ---------------------------------------- It would be convenient to have a method that checks if two ranges overlap. For example, ``` (0..10).overlap?(5..15) #=> true (0..10).overlap?(20..30) #=> false ``` -- https://bugs.ruby-lang.org/

Issue #19839 has been updated by shouichi (Shouichi KAMIYA). Thank you for your feedback.

I've made several helpers for this exact same problem, as well as a `Range#merge` in the past.

Yes, `Range` class can have methods such as `Range#merge` but I wanted to start small and see what happens.

What do you expect when it is called with a non-Range object, `TypeError`, same as cover? or something else?

Yes. Raising TypeError seems correct. I'm going to fix the PR. ---------------------------------------- Feature #19839: Need a method to check if two ranges overlap https://bugs.ruby-lang.org/issues/19839#change-104154 * Author: shouichi (Shouichi KAMIYA) * Status: Open * Priority: Normal ---------------------------------------- It would be convenient to have a method that checks if two ranges overlap. For example, ``` (0..10).overlap?(5..15) #=> true (0..10).overlap?(20..30) #=> false ``` -- https://bugs.ruby-lang.org/

Issue #19839 has been updated by hsbt (Hiroshi SHIBATA). Status changed from Open to Feedback ActiveSupport already have `overlaps?` method. * https://api.rubyonrails.org/classes/Range.html#method-i-overlaps-3F * https://github.com/rails/rails/blob/main/activesupport/lib/active_support/co... Is it enough for your use-case? ---------------------------------------- Feature #19839: Need a method to check if two ranges overlap https://bugs.ruby-lang.org/issues/19839#change-104519 * Author: shouichi (Shouichi KAMIYA) * Status: Feedback * Priority: Normal ---------------------------------------- It would be convenient to have a method that checks if two ranges overlap. For example, ``` (0..10).overlap?(5..15) #=> true (0..10).overlap?(20..30) #=> false ``` -- https://bugs.ruby-lang.org/

Issue #19839 has been updated by hsbt (Hiroshi SHIBATA). Status changed from Feedback to Open Thanks. Basically, we didn't add new methods from ActiveSupport without performance reason. Can you describe why we should add `overlap?` to ruby core? ---------------------------------------- Feature #19839: Need a method to check if two ranges overlap https://bugs.ruby-lang.org/issues/19839#change-104528 * Author: shouichi (Shouichi KAMIYA) * Status: Open * Priority: Normal ---------------------------------------- It would be convenient to have a method that checks if two ranges overlap. For example, ``` (0..10).overlap?(5..15) #=> true (0..10).overlap?(20..30) #=> false ``` -- https://bugs.ruby-lang.org/

Issue #19839 has been updated by baweaver (Brandon Weaver). I believe there are a few reasons for this addition. The core one I see often in justifications is precedence in existing Ruby, such as: **Combinations** These cases have clear precedent for iterable / enumerable types: * `Array#concat` - Merging two Arrays * `Hash#merge` - Merging two Hashes * `Set#union` - Merging two Sets (or Enumerable on other end) **Inclusions** Interestingly not as common are patterns like `Enumerable#include?(other_enumerable)` versus the very common `Enumerable#include?(single_item)` so we have a lot of "unnamed" approximations: * `Array` - `(array_two - array_one).empty?` or `array_one.intersection(array_two).any?` * `Hash` - `(hash_two.keys - hash_one.keys).empty?` ...which are not very performant, and I would bet are common patterns in non-Rails code. It also raises a potential for `Hash#intersection` and how that might work with same keys with different values. **Overlaps** For these two cases I would also almost consider `overlaps?`, which is synonymous to `intersection(other).any?` from `Array`: ```ruby [1, 2, 3].overlaps?([2, 3]) # true { a: 1, b: 2 }.overlaps?(a: 3, b: 5) # true? key vs value is complicated here (1..10).overlaps?(5..15) # true ``` ---- Point being I would argue there is a (minor) performance win potential here for existing code, it feels very much in the spirit of Ruby of creating a name for a common operation. ---------------------------------------- Feature #19839: Need a method to check if two ranges overlap https://bugs.ruby-lang.org/issues/19839#change-104552 * Author: shouichi (Shouichi KAMIYA) * Status: Open * Priority: Normal ---------------------------------------- It would be convenient to have a method that checks if two ranges overlap. For example, ``` (0..10).overlap?(5..15) #=> true (0..10).overlap?(20..30) #=> false ``` -- https://bugs.ruby-lang.org/

Issue #19839 has been updated by ko1 (Koichi Sasada). I'm not sure what `(n...n)` but on AS definition, the following code returns true. ```ruby p (1..2).overlap?(2...2) #=> true p (2..2).overlap?(2...2) #=> true p (2...2).overlap?(2...2) #=> true ``` is it intentional? ---------------------------------------- Feature #19839: Need a method to check if two ranges overlap https://bugs.ruby-lang.org/issues/19839#change-104582 * Author: shouichi (Shouichi KAMIYA) * Status: Open * Priority: Normal ---------------------------------------- It would be convenient to have a method that checks if two ranges overlap. For example, ``` (0..10).overlap?(5..15) #=> true (0..10).overlap?(20..30) #=> false ``` -- https://bugs.ruby-lang.org/

Issue #19839 has been updated by sawa (Tsuyoshi Sawada). I think the analogy for `range1.overlap?(range2)` in mathematics is `interval1 ∩ interval2 ≠ ∅`, which does not hold when either `interval1` or `interval2` is an empty interval. Hence, I think that, when either `range1` or `range2` is an empty range (e.g., `2...2`, `2..1`), `range1.overlap?(range2)` should return `false`. Instead of adopting the AS #note-5 definition, ```rb def overlap?(other) other.begin == self.begin || cover?(other.begin) || other.cover?(self.begin) end ``` I propose to define it as equivalent to: ```rb def overlap?(other) return false if none? or other.none? other.begin == self.begin || cover?(other.begin) || other.cover?(self.begin) end ``` ---------------------------------------- Feature #19839: Need a method to check if two ranges overlap https://bugs.ruby-lang.org/issues/19839#change-104585 * Author: shouichi (Shouichi KAMIYA) * Status: Open * Priority: Normal ---------------------------------------- It would be convenient to have a method that checks if two ranges overlap. For example, ``` (0..10).overlap?(5..15) #=> true (0..10).overlap?(20..30) #=> false ``` -- https://bugs.ruby-lang.org/

Issue #19839 has been updated by shouichi (Shouichi KAMIYA). I opened a PR about a month ago but should I close it...? https://github.com/ruby/ruby/pull/8242 ---------------------------------------- Feature #19839: Need a method to check if two ranges overlap https://bugs.ruby-lang.org/issues/19839#change-104617 * Author: shouichi (Shouichi KAMIYA) * Status: Open * Priority: Normal ---------------------------------------- It would be convenient to have a method that checks if two ranges overlap. For example, ``` (0..10).overlap?(5..15) #=> true (0..10).overlap?(20..30) #=> false ``` -- https://bugs.ruby-lang.org/

Issue #19839 has been updated by akr (Akira Tanaka). I found another corner case. ``` % ./ruby -e 'r = (...-Float::INFINITY); p r.overlap?(r)' true % ./ruby -e 'r = (...[]); p r.overlap?(r)' true % ./ruby -e 'r = (...""); p r.overlap?(r)' true % ./ruby -e 'r = (...true); p r.overlap?(r)' true % ./ruby -e 'r = (...false); p r.overlap?(r)' true % ./ruby -e 'r = (...Object.new); p r.overlap?(r)' true % ./ruby -v ruby 3.3.0dev (2023-09-16T22:27:04Z master cd67c0d204) [x86_64-linux] ``` They are `(...MINIMUM)` where MINIMUM is a value that there is no value less than that. `(...MINIMUM)` is empty because (1) it doesn't contain MINIMUM itself because `...` is used (exclude_end is true) and (2) it doesn't contain other values because there is no value less than MINIMUM. But `(...MINIMUM).overlap?(...MINIMUM)` returns true as shown above. It means Ruby says there is a value contained in (...MINIMUM). It is invalid. Note that true, false, and `Object.new` has `<=>` method defined by Kernel. It determines self is equal to itself and other objects are not comparable. Thus, they can be considered as minimum values (and maximum values). I think this problem is difficult to solve. We have no clean way to detect minimum values. Some options: (1) introduce some protocol to detect minimum values such as `minimum?` method. (2) hard code minimum values of builtin classes in `Range#overlap?` and use `minimum?` for user-defined classes. (3) document this limitation. ---------------------------------------- Feature #19839: Need a method to check if two ranges overlap https://bugs.ruby-lang.org/issues/19839#change-104645 * Author: shouichi (Shouichi Kamiya) * Status: Closed * Priority: Normal ---------------------------------------- It would be convenient to have a method that checks if two ranges overlap. For example, ``` (0..10).overlap?(5..15) #=> true (0..10).overlap?(20..30) #=> false ``` -- https://bugs.ruby-lang.org/

Issue #19839 has been updated by nobu (Nobuyoshi Nakada). shouichi (Shouichi Kamiya) wrote in #note-19:

Shouldn't `none?` handle empty ranges? Currently, it raises an error.

```

...

(...-Float::INFINITY).none? (irb):1:in `each': can't iterate from NilClass (TypeError)

If `none?` handles empty ranges, then `overlap?` can return false when one of the ranges is empty.

It's for `nil`, that means begin-less range. ---------------------------------------- Feature #19839: Need a method to check if two ranges overlap https://bugs.ruby-lang.org/issues/19839#change-104657 * Author: shouichi (Shouichi Kamiya) * Status: Closed * Priority: Normal ---------------------------------------- It would be convenient to have a method that checks if two ranges overlap. For example, ``` (0..10).overlap?(5..15) #=> true (0..10).overlap?(20..30) #=> false ``` -- https://bugs.ruby-lang.org/

Issue #19839 has been updated by akr (Akira Tanaka). `Range` has two semantics: succ-based and cover-based. `none?` is succ-based because it is implemented in `Enumerable` which uses `each` method which uses `succ` in Range. `overlap?` is cover-based. It uses comparison (<=>). The two semantics sometimes cause inconsistent behavior. It is difficult to make them consistent completely. ---------------------------------------- Feature #19839: Need a method to check if two ranges overlap https://bugs.ruby-lang.org/issues/19839#change-104665 * Author: shouichi (Shouichi Kamiya) * Status: Closed * Priority: Normal ---------------------------------------- It would be convenient to have a method that checks if two ranges overlap. For example, ``` (0..10).overlap?(5..15) #=> true (0..10).overlap?(20..30) #=> false ``` -- https://bugs.ruby-lang.org/

Issue #19839 has been updated by mame (Yusuke Endoh). This method is going to have an incompatibility with `Range#overlap?` that ActiveSupport has been provided. Is it OK? I'd like to confirm with the Rails developers just to be sure. ---------------------------------------- Feature #19839: Need a method to check if two ranges overlap https://bugs.ruby-lang.org/issues/19839#change-104703 * Author: shouichi (Shouichi Kamiya) * Status: Closed * Priority: Normal ---------------------------------------- It would be convenient to have a method that checks if two ranges overlap. For example, ``` (0..10).overlap?(5..15) #=> true (0..10).overlap?(20..30) #=> false ``` -- https://bugs.ruby-lang.org/

Issue #19839 has been updated by rafaelfranca (Rafael França). Thank you for checking with us. I believe the difference when the ranges are empty is acceptable. I don't think it was intentional in the Active Support implementation. ---------------------------------------- Feature #19839: Need a method to check if two ranges overlap https://bugs.ruby-lang.org/issues/19839#change-104712 * Author: shouichi (Shouichi Kamiya) * Status: Closed * Priority: Normal ---------------------------------------- It would be convenient to have a method that checks if two ranges overlap. For example, ``` (0..10).overlap?(5..15) #=> true (0..10).overlap?(20..30) #=> false ``` -- https://bugs.ruby-lang.org/