[ruby-core:119488] [Ruby master Bug#20790] Syntax acceptance of `*x = p rescue p 1` is different between parse.y and prism

Issue #20790 has been reported by tompng (tomoya ishida). ---------------------------------------- Bug #20790: Syntax acceptance of `*x = p rescue p 1` is different between parse.y and prism https://bugs.ruby-lang.org/issues/20790 * Author: tompng (tomoya ishida) * Status: Open * ruby -v: ruby 3.4.0dev (2024-10-09T03:27:05Z master ed11a244dd) +PRISM [x86_64-linux] * Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- ~~~ruby *x = p rescue p 1 # syntax error in prism *x = p 1 rescue p 1 # both syntax ok x = p rescue p 1 # both syntax error x = p 1 rescue p 1 # both syntax ok ~~~ Which is correct? If `*x = p rescue p 1` is syntax valid, should `x = p rescue p 1` also be syntax valid? -- https://bugs.ruby-lang.org/

Issue #20790 has been updated by mame (Yusuke Endoh). Discussed at the dev meeting. Here is matz's preference. ```ruby # current parse.y behavior # matz's preference *x = p rescue p 1 # (*x = p) rescue (p 1) # *x = (p rescue (p 1)) *x = p 1 rescue p 1 # (*x = p 1) rescue (p 1) # *x = ((p 1) rescue (p 1)) a, b = p rescue p # a, b = (p rescue p) # as is x = p rescue p # x = (p rescue p) # as is x = p rescue p 1 # x = (p rescue p) 1 (ERROR) # x = (p rescue p 1) x = p 1 rescue p 1 # x = ((p 1) rescue (p 1)) # as is ``` @yui-knk @kddnewton What do you think? ---------------------------------------- Bug #20790: Syntax acceptance of `*x = p rescue p 1` is different between parse.y and prism https://bugs.ruby-lang.org/issues/20790#change-110487 * Author: tompng (tomoya ishida) * Status: Open * ruby -v: ruby 3.4.0dev (2024-10-09T03:27:05Z master ed11a244dd) +PRISM [x86_64-linux] * Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- ~~~ruby *x = p rescue p 1 # syntax error in prism *x = p 1 rescue p 1 # both syntax ok x = p rescue p 1 # both syntax error x = p 1 rescue p 1 # both syntax ok ~~~ Which is correct? If `*x = p rescue p 1` is syntax valid, should `x = p rescue p 1` also be syntax valid? -- https://bugs.ruby-lang.org/

Issue #20790 has been updated by kddnewton (Kevin Newton). That makes sense to me, we can make that work. ---------------------------------------- Bug #20790: Syntax acceptance of `*x = p rescue p 1` is different between parse.y and prism https://bugs.ruby-lang.org/issues/20790#change-110535 * Author: tompng (tomoya ishida) * Status: Open * ruby -v: ruby 3.4.0dev (2024-10-09T03:27:05Z master ed11a244dd) +PRISM [x86_64-linux] * Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- ~~~ruby *x = p rescue p 1 # syntax error in prism *x = p 1 rescue p 1 # both syntax ok x = p rescue p 1 # both syntax error x = p 1 rescue p 1 # both syntax ok ~~~ Which is correct? If `*x = p rescue p 1` is syntax valid, should `x = p rescue p 1` also be syntax valid? -- https://bugs.ruby-lang.org/

Issue #20790 has been updated by ydah (Yudai Takada). I checked if it is feasible with parse.y: https://github.com/ydah/ruby/commit/50100c136ac4bbe379b2c360994b739227610e17 I have been able to confirm that the following are feasible with the modifications shown above. ```ruby # current parse.y behavior # matz's preference *x = p rescue p 1 # (*x = p) rescue (p 1) # *x = (p rescue (p 1)) *x = p 1 rescue p 1 # (*x = p 1) rescue (p 1) # *x = ((p 1) rescue (p 1)) a, b = p rescue p # a, b = (p rescue p) # as is x = p rescue p # x = (p rescue p) # as is x = p 1 rescue p 1 # x = ((p 1) rescue (p 1)) # as is ``` The following are still under investigation for feasibility. ```ruby # current parse.y behavior # matz's preference x = p rescue p 1 # x = (p rescue p) 1 (ERROR) # x = (p rescue p 1) ``` ---------------------------------------- Bug #20790: Syntax acceptance of `*x = p rescue p 1` is different between parse.y and prism https://bugs.ruby-lang.org/issues/20790#change-110745 * Author: tompng (tomoya ishida) * Status: Open * ruby -v: ruby 3.4.0dev (2024-10-09T03:27:05Z master ed11a244dd) +PRISM [x86_64-linux] * Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- ~~~ruby *x = p rescue p 1 # syntax error in prism *x = p 1 rescue p 1 # both syntax ok x = p rescue p 1 # both syntax error x = p 1 rescue p 1 # both syntax ok ~~~ Which is correct? If `*x = p rescue p 1` is syntax valid, should `x = p rescue p 1` also be syntax valid? -- https://bugs.ruby-lang.org/
participants (4)
-
kddnewton (Kevin Newton)
-
mame (Yusuke Endoh)
-
tompng (tomoya ishida)
-
ydah (Yudai Takada)