[ruby-core:111812] [Ruby master Bug#19340] Ruby master 'make install' not installing rbs gem
Issue #19340 has been reported by MSP-Greg (Greg L). ---------------------------------------- Bug #19340: Ruby master 'make install' not installing rbs gem https://bugs.ruby-lang.org/issues/19340 * Author: MSP-Greg (Greg L) * Status: Open * Priority: Normal * ruby -v: ruby 3.3.0dev (2023-01-14T11:30:19Z master 1ddeb7473d) * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- Last three daily builds of ruby-dev-builder have not included the rbs gem. See https://github.com/ruby/ruby-dev-builder/actions/runs/3919887598/jobs/670117... ruby/ruby PR https://github.com/ruby/ruby/pull/7114 ruby/ruby-dev-builder PR https://github.com/ruby/ruby-dev-builder/pull/2 checks all bin files work Added a patch to ruby-loco for it, so its builds are ok. -- https://bugs.ruby-lang.org/
Issue #19340 has been updated by hsbt (Hiroshi SHIBATA). I couldn't reproduce it. And What should we install their versions? 1. rbs of eab5367add3469b3f614e663ba43a3debc62420a(not 3.0.0.dev.1) 2. 3.0.0.dev.1 3. rbs-2.8.3 4. Nothing, We skip to install rbs because there is no tested version yet. I'm +1 to 3 or 1. But I also prefer to use 4 with skip message. ---------------------------------------- Bug #19340: Ruby master 'make install' not installing rbs gem https://bugs.ruby-lang.org/issues/19340#change-101229 * Author: MSP-Greg (Greg L) * Status: Open * Priority: Normal * ruby -v: ruby 3.3.0dev (2023-01-14T11:30:19Z master 1ddeb7473d) * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- Last three daily builds of ruby-dev-builder have not included the rbs gem. See https://github.com/ruby/ruby-dev-builder/actions/runs/3919887598/jobs/670117... ruby/ruby PR https://github.com/ruby/ruby/pull/7114 ruby/ruby-dev-builder PR https://github.com/ruby/ruby-dev-builder/pull/2 checks all bin files work Added a patch to ruby-loco for it, so its builds are ok. -- https://bugs.ruby-lang.org/
Issue #19340 has been updated by MSP-Greg (Greg L). From the ruby-loco log, which has the Ruby PR applied: ``` Copying rbs@eab5367add3469b3f614e663ba43a3debc62420a to rbs-3.0.0.dev.1 From https://github.com/ruby/rbs * branch eab5367add3469b3f614e663ba43a3debc62420a -> FETCH_HEAD HEAD is now at eab5367a Merge pull request #1207 from ruby/single-process-stdlibtest Copied gems/src/rbs ``` It is pulling the code from the commit and installing it as rbs-3.0.0.dev.1. I checked the code in the most recent ruby-loco build, and it includes the changes in rbs@eab5367 to `Rakefile`. So, using the line in PR 7114 works as expected... ---------------------------------------- Bug #19340: Ruby master 'make install' not installing rbs gem https://bugs.ruby-lang.org/issues/19340#change-101230 * Author: MSP-Greg (Greg L) * Status: Open * Priority: Normal * ruby -v: ruby 3.3.0dev (2023-01-14T11:30:19Z master 1ddeb7473d) * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- Last three daily builds of ruby-dev-builder have not included the rbs gem. See https://github.com/ruby/ruby-dev-builder/actions/runs/3919887598/jobs/670117... ruby/ruby PR https://github.com/ruby/ruby/pull/7114 ruby/ruby-dev-builder PR https://github.com/ruby/ruby-dev-builder/pull/2 checks all bin files work Added a patch to ruby-loco for it, so its builds are ok. -- https://bugs.ruby-lang.org/
Issue #19340 has been updated by hsbt (Hiroshi SHIBATA). We discuss this issue with @mame @nobu @ko1 and @soutaro. The current build-system of bundled gems is very complex. We decide to the following specification for building the bundled gems. When we provide this `bundled_gems` file: ``` foo 0.1.2 https:// bar 0.2.3 https://... abc (abcd uses bar-0.2.4) buzz 0.2.4 https://... xyz (xyz uses buzz-0.2.4) ``` 1. We fetch and install foo-0.1.2. 2. `make` process will raise error bar-0.2.3 and `abc` ref of bar repository. Because their versions are inconsistency. So, we couldn't specify installed version. 3. `make install` uses buzz-0.2.4 build from xyz ref of buzz repository. It's different from buzz-0.2.4 strictly. It's for only development snapshot version. ---------------------------------------- Bug #19340: Ruby master 'make install' not installing rbs gem https://bugs.ruby-lang.org/issues/19340#change-101282 * Author: MSP-Greg (Greg L) * Status: Open * Priority: Normal * ruby -v: ruby 3.3.0dev (2023-01-14T11:30:19Z master 1ddeb7473d) * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- Last three daily builds of ruby-dev-builder have not included the rbs gem. See https://github.com/ruby/ruby-dev-builder/actions/runs/3919887598/jobs/670117... ruby/ruby PR https://github.com/ruby/ruby/pull/7114 ruby/ruby-dev-builder PR https://github.com/ruby/ruby-dev-builder/pull/2 checks all bin files work Added a patch to ruby-loco for it, so its builds are ok. -- https://bugs.ruby-lang.org/
Issue #19340 has been updated by MSP-Greg (Greg L). The particular issue with rbs has been fixed with https://github.com/ruby/ruby/pull/7143
The current build-system of bundled gems is very complex
Agreed. Several recent commits show updates to it. Given issues with whether one wants a released gem or a commit (or release tag) from the bundled gem's repo, and also dependencies between bundled gems, etc, things can get really messy. I would think that using the head commit from almost all bundled gems would be the best option, but that is difficult re dependencies, pre-release versions, etc. It also places a burden on the maintainers of them. Ok to close. Thanks. ---------------------------------------- Bug #19340: Ruby master 'make install' not installing rbs gem https://bugs.ruby-lang.org/issues/19340#change-101303 * Author: MSP-Greg (Greg L) * Status: Open * Priority: Normal * ruby -v: ruby 3.3.0dev (2023-01-14T11:30:19Z master 1ddeb7473d) * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- Last three daily builds of ruby-dev-builder have not included the rbs gem. See https://github.com/ruby/ruby-dev-builder/actions/runs/3919887598/jobs/670117... ruby/ruby PR https://github.com/ruby/ruby/pull/7114 ruby/ruby-dev-builder PR https://github.com/ruby/ruby-dev-builder/pull/2 checks all bin files work Added a patch to ruby-loco for it, so its builds are ok. -- https://bugs.ruby-lang.org/
Issue #19340 has been updated by hsbt (Hiroshi SHIBATA). Note, related PRs are: * https://github.com/ruby/ruby/pull/7146 * https://github.com/ruby/ruby/pull/7347 ---------------------------------------- Bug #19340: Ruby master 'make install' not installing rbs gem https://bugs.ruby-lang.org/issues/19340#change-102197 * Author: MSP-Greg (Greg L) * Status: Closed * Priority: Normal * ruby -v: ruby 3.3.0dev (2023-01-14T11:30:19Z master 1ddeb7473d) * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- Last three daily builds of ruby-dev-builder have not included the rbs gem. See https://github.com/ruby/ruby-dev-builder/actions/runs/3919887598/jobs/670117... ruby/ruby PR https://github.com/ruby/ruby/pull/7114 ruby/ruby-dev-builder PR https://github.com/ruby/ruby-dev-builder/pull/2 checks all bin files work Added a patch to ruby-loco for it, so its builds are ok. -- https://bugs.ruby-lang.org/
Issue #19340 has been updated by hsbt (Hiroshi SHIBATA). Assignee set to hsbt (Hiroshi SHIBATA) ---------------------------------------- Bug #19340: Ruby master 'make install' not installing rbs gem https://bugs.ruby-lang.org/issues/19340#change-102198 * Author: MSP-Greg (Greg L) * Status: Closed * Priority: Normal * Assignee: hsbt (Hiroshi SHIBATA) * ruby -v: ruby 3.3.0dev (2023-01-14T11:30:19Z master 1ddeb7473d) * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- Last three daily builds of ruby-dev-builder have not included the rbs gem. See https://github.com/ruby/ruby-dev-builder/actions/runs/3919887598/jobs/670117... ruby/ruby PR https://github.com/ruby/ruby/pull/7114 ruby/ruby-dev-builder PR https://github.com/ruby/ruby-dev-builder/pull/2 checks all bin files work Added a patch to ruby-loco for it, so its builds are ok. -- https://bugs.ruby-lang.org/
Issue #19340 has been updated by hsbt (Hiroshi SHIBATA). In last weekend, all of Ruby CI results are failed like http://rubyci.s3.amazonaws.com/ubuntu/ruby-master/log/20230305T001003Z.fail.... It caused by minitest-5.18.0 release and our gem build logic missed to checkout specified revision. I fixed them at https://github.com/ruby/ruby/pull/7475 ---------------------------------------- Bug #19340: Ruby master 'make install' not installing rbs gem https://bugs.ruby-lang.org/issues/19340#change-102200 * Author: MSP-Greg (Greg L) * Status: Closed * Priority: Normal * Assignee: hsbt (Hiroshi SHIBATA) * ruby -v: ruby 3.3.0dev (2023-01-14T11:30:19Z master 1ddeb7473d) * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- Last three daily builds of ruby-dev-builder have not included the rbs gem. See https://github.com/ruby/ruby-dev-builder/actions/runs/3919887598/jobs/670117... ruby/ruby PR https://github.com/ruby/ruby/pull/7114 ruby/ruby-dev-builder PR https://github.com/ruby/ruby-dev-builder/pull/2 checks all bin files work Added a patch to ruby-loco for it, so its builds are ok. -- https://bugs.ruby-lang.org/
participants (3)
-
hsbt (Hiroshi SHIBATA) -
hsbt (Hiroshi SHIBATA) -
MSP-Greg (Greg L)