[ruby-core:112536] [Ruby master Feature#19457] Some improvements to test-all suite
Issue #19457 has been reported by luke-gru (Luke Gruber). ---------------------------------------- Feature #19457: Some improvements to test-all suite https://bugs.ruby-lang.org/issues/19457 * Author: luke-gru (Luke Gruber) * Status: Open * Priority: Normal ---------------------------------------- Hi, I've been making some improvements to this suite in a branch of my own and came up with a list of changes I think are good but I would like input from developers. 1) Currently test-all with -j option does not show errors/failures immediately, it waits until end. Additionaly it doesn't really show them at end, it only shows after it retries the tests in current process. I made changes to make it show immediately and have a summary before the retry. 2) If timeout occurs in -j mode (default 180 sec), the worker process is terminated but no new worker is added to replace it. I added this. 3) If a timeout occurs in -j mode, it is not reported immediately. I made it do so. 4) I added -no-leakchecker flag. I use this often when I don't want any output of DRB tests because I get lots of leakchecker reports from this for some reason. 5) when filtering test name with --name option, you can give regexp like /test_hash/ but it can also match class name like !/DRbTest/. You can't give //i flag so you need to get case exactly right for the class names. I added //i flag functionality for positive and negative regexps. 6) Fixed colorization of failures/skips. 7) I added test suite (test class) GC in serial (no -j) mode. After a test class finishes the constant is removed and references deleted. It saves quite a bit of memory in my tests so far. Motivation to reduce memory and reduce full GC pause time. I have all these changes in a single branch. If any of these changes interest you, let me know and I will try to isolate them in a single commit and make a PR. -- https://bugs.ruby-lang.org/
Issue #19457 has been updated by nobu (Nobuyoshi Nakada). Interesting, patches are welcome. ---------------------------------------- Feature #19457: Some improvements to test-all suite https://bugs.ruby-lang.org/issues/19457#change-101986 * Author: luke-gru (Luke Gruber) * Status: Open * Priority: Normal ---------------------------------------- Hi, I've been making some improvements to this suite in a branch of my own and came up with a list of changes I think are good but I would like input from developers. 1) Currently test-all with -j option does not show errors/failures immediately, it waits until end. Additionaly it doesn't really show them at end, it only shows after it retries the tests in current process. I made changes to make it show immediately and have a summary before the retry. 2) If timeout occurs in -j mode (default 180 sec), the worker process is terminated but no new worker is added to replace it. I added this. 3) If a timeout occurs in -j mode, it is not reported immediately. I made it do so. 4) I added -no-leakchecker flag. I use this often when I don't want any output of DRB tests because I get lots of leakchecker reports from this for some reason. 5) when filtering test name with --name option, you can give regexp like /test_hash/ but it can also match class name like !/DRbTest/. You can't give //i flag so you need to get case exactly right for the class names. I added //i flag functionality for positive and negative regexps. 6) Fixed colorization of failures/skips. 7) I added test suite (test class) GC in serial (no -j) mode. After a test class finishes the constant is removed and references deleted. It saves quite a bit of memory in my tests so far. Motivation to reduce memory and reduce full GC pause time. I have all these changes in a single branch. If any of these changes interest you, let me know and I will try to isolate them in a single commit and make a PR. -- https://bugs.ruby-lang.org/
Issue #19457 has been updated by luke-gru (Luke Gruber). I've created some PRs related to this, and now regret opening an issue for this. Since I cannot close it, can someone close please? Thanks! ---------------------------------------- Feature #19457: Some improvements to test-all suite https://bugs.ruby-lang.org/issues/19457#change-102309 * Author: luke-gru (Luke Gruber) * Status: Open * Priority: Normal ---------------------------------------- Hi, I've been making some improvements to this suite in a branch of my own and came up with a list of changes I think are good but I would like input from developers. 1) Currently test-all with -j option does not show errors/failures immediately, it waits until end. Additionaly it doesn't really show them at end, it only shows after it retries the tests in current process. I made changes to make it show immediately and have a summary before the retry. 2) If timeout occurs in -j mode (default 180 sec), the worker process is terminated but no new worker is added to replace it. I added this. 3) If a timeout occurs in -j mode, it is not reported immediately. I made it do so. 4) I added -no-leakchecker flag. I use this often when I don't want any output of DRB tests because I get lots of leakchecker reports from this for some reason. 5) when filtering test name with --name option, you can give regexp like /test_hash/ but it can also match class name like !/DRbTest/. You can't give //i flag so you need to get case exactly right for the class names. I added //i flag functionality for positive and negative regexps. 6) Fixed colorization of failures/skips. 7) I added test suite (test class) GC in serial (no -j) mode. After a test class finishes the constant is removed and references deleted. It saves quite a bit of memory in my tests so far. Motivation to reduce memory and reduce full GC pause time. I have all these changes in a single branch. If any of these changes interest you, let me know and I will try to isolate them in a single commit and make a PR. -- https://bugs.ruby-lang.org/
participants (3)
-
luke-gru (Luke Gruber) -
luke-gru (Luke Gruber) -
nobu (Nobuyoshi Nakada)