Issue #20679 has been updated by jeremyevans0 (Jeremy Evans). Thanks for the report. I will revert and then try to work on a fix. ---------------------------------------- Bug #20679: Rails CI errors since abc04e898b627ab37fa9dd5e330f239768778d8b https://bugs.ruby-lang.org/issues/20679#change-109438 * Author: yahonda (Yasuo Honda) * Status: Open * Assignee: jeremyevans0 (Jeremy Evans) * ruby -v: ruby 3.4.0dev (2024-08-15T18:33:13Z :detached: 2c6e16eb51) [x86_64-linux] * Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- Rails CI against Ruby master branch gets failed since abc04e898b627ab37fa9dd5e330f239768778d8b ### Steps to reproduce ``` git clone https://github.com/rails/rails cd rails/railties bundle install bin/test test/application/rendering_test.rb:39 ``` ### Expected behavior It should pass as 2c6e16eb51 does. ``` $ ruby -v ruby 3.4.0dev (2024-08-15T18:33:13Z :detached: 2c6e16eb51) [x86_64-linux] $ bin/test test/application/rendering_test.rb:39 /home/yahonda/.rbenv/versions/trunk/lib/ruby/gems/3.4.0+0/gems/json-2.7.1/lib/json/common.rb:3: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. You can add ostruct to your Gemfile or gemspec to silence this warning. /home/yahonda/.rbenv/versions/trunk/lib/ruby/gems/3.4.0+0/gems/json-2.7.1/lib/json/common.rb:3: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. You can add ostruct to your Gemfile or gemspec to silence this warning. Run options: --seed 50444 # Running: . Finished in 1.554218s, 0.6434 runs/s, 1.2868 assertions/s. 1 runs, 2 assertions, 0 failures, 0 errors, 0 skips $ ``` ### Actual behavior It gets `NoMethodError: undefined method '[]' for nil`. ``` $ ruby -v ruby 3.4.0dev (2024-08-15T20:00:09Z :detached: abc04e898b) [x86_64-linux] $ bin/test test/application/rendering_test.rb:39 /home/yahonda/.rbenv/versions/trunk/lib/ruby/gems/3.4.0+0/gems/json-2.7.1/lib/json/common.rb:3: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. You can add ostruct to your Gemfile or gemspec to silence this warning. /home/yahonda/.rbenv/versions/trunk/lib/ruby/gems/3.4.0+0/gems/json-2.7.1/lib/json/common.rb:3: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. You can add ostruct to your Gemfile or gemspec to silence this warning. Run options: --seed 53551 # Running: E Error: ApplicationTests::RenderingTest#test_Unknown_format_falls_back_to_HTML_template: NoMethodError: undefined method '[]' for nil /home/yahonda/.rbenv/versions/trunk/lib/ruby/gems/3.4.0+0/gems/rack-test-2.1.0/lib/rack/test.rb:275:in 'Rack::Test::Session#parse_uri' /home/yahonda/.rbenv/versions/trunk/lib/ruby/gems/3.4.0+0/gems/rack-test-2.1.0/lib/rack/test.rb:161:in 'Rack::Test::Session#custom_request' /home/yahonda/.rbenv/versions/trunk/lib/ruby/gems/3.4.0+0/gems/rack-test-2.1.0/lib/rack/test.rb:112:in 'Rack::Test::Session#get' /home/yahonda/.rbenv/versions/trunk/lib/ruby/3.4.0+0/forwardable.rb:240:in 'Rack::Test::Methods#get' test/application/rendering_test.rb:39:in 'block in <class:RenderingTest>' bin/test test/application/rendering_test.rb:19 Finished in 1.499265s, 0.6670 runs/s, 0.0000 assertions/s. 1 runs, 0 assertions, 0 failures, 1 errors, 0 skips $ ``` -- https://bugs.ruby-lang.org/

Issue #20679 has been updated by jeremyevans0 (Jeremy Evans). jeremyevans0 (Jeremy Evans) wrote in #note-3:

Definitely related to the `ruby2_keywords` optimization. I'll keep digging to find the root cause. I'll leave this open until I have a working fix.

I submitted a pull request for the fix: https://github.com/ruby/ruby/pull/11409 Root cause was when I extracted a function, I missed the use of a local variable after the extraction. This wasn't caught because the same variable existed in a higher scope.

Rails hits this through use of forwardable in rack-test. We should also consider switching forwardable to use generic argument forwarding (`...`) instead of `ruby2_keywords` when using Ruby 2.7+. It's simpler, and faster on Ruby 3.4 as generic argument forwarding is now allocationless.

I submitted a pull request to change forwardable to use generic argument forwarding: https://github.com/ruby/forwardable/pull/34 ---------------------------------------- Bug #20679: Rails CI errors since abc04e898b627ab37fa9dd5e330f239768778d8b https://bugs.ruby-lang.org/issues/20679#change-109466 * Author: yahonda (Yasuo Honda) * Status: Open * Assignee: jeremyevans0 (Jeremy Evans) * ruby -v: ruby 3.4.0dev (2024-08-15T18:33:13Z :detached: 2c6e16eb51) [x86_64-linux] * Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- Rails CI against Ruby master branch gets failed since abc04e898b627ab37fa9dd5e330f239768778d8b ### Steps to reproduce ``` git clone https://github.com/rails/rails cd rails/railties bundle install bin/test test/application/rendering_test.rb:39 ``` ### Expected behavior It should pass as 2c6e16eb51 does. ``` $ ruby -v ruby 3.4.0dev (2024-08-15T18:33:13Z :detached: 2c6e16eb51) [x86_64-linux] $ bin/test test/application/rendering_test.rb:39 /home/yahonda/.rbenv/versions/trunk/lib/ruby/gems/3.4.0+0/gems/json-2.7.1/lib/json/common.rb:3: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. You can add ostruct to your Gemfile or gemspec to silence this warning. /home/yahonda/.rbenv/versions/trunk/lib/ruby/gems/3.4.0+0/gems/json-2.7.1/lib/json/common.rb:3: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. You can add ostruct to your Gemfile or gemspec to silence this warning. Run options: --seed 50444 # Running: . Finished in 1.554218s, 0.6434 runs/s, 1.2868 assertions/s. 1 runs, 2 assertions, 0 failures, 0 errors, 0 skips $ ``` ### Actual behavior It gets `NoMethodError: undefined method '[]' for nil`. ``` $ ruby -v ruby 3.4.0dev (2024-08-15T20:00:09Z :detached: abc04e898b) [x86_64-linux] $ bin/test test/application/rendering_test.rb:39 /home/yahonda/.rbenv/versions/trunk/lib/ruby/gems/3.4.0+0/gems/json-2.7.1/lib/json/common.rb:3: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. You can add ostruct to your Gemfile or gemspec to silence this warning. /home/yahonda/.rbenv/versions/trunk/lib/ruby/gems/3.4.0+0/gems/json-2.7.1/lib/json/common.rb:3: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. You can add ostruct to your Gemfile or gemspec to silence this warning. Run options: --seed 53551 # Running: E Error: ApplicationTests::RenderingTest#test_Unknown_format_falls_back_to_HTML_template: NoMethodError: undefined method '[]' for nil /home/yahonda/.rbenv/versions/trunk/lib/ruby/gems/3.4.0+0/gems/rack-test-2.1.0/lib/rack/test.rb:275:in 'Rack::Test::Session#parse_uri' /home/yahonda/.rbenv/versions/trunk/lib/ruby/gems/3.4.0+0/gems/rack-test-2.1.0/lib/rack/test.rb:161:in 'Rack::Test::Session#custom_request' /home/yahonda/.rbenv/versions/trunk/lib/ruby/gems/3.4.0+0/gems/rack-test-2.1.0/lib/rack/test.rb:112:in 'Rack::Test::Session#get' /home/yahonda/.rbenv/versions/trunk/lib/ruby/3.4.0+0/forwardable.rb:240:in 'Rack::Test::Methods#get' test/application/rendering_test.rb:39:in 'block in <class:RenderingTest>' bin/test test/application/rendering_test.rb:19 Finished in 1.499265s, 0.6670 runs/s, 0.0000 assertions/s. 1 runs, 0 assertions, 0 failures, 1 errors, 0 skips $ ``` -- https://bugs.ruby-lang.org/