[ruby-core:118173] [Ruby master Misc#20524] mswin and gmp
Issue #20524 has been reported by MSP-Greg (Greg L). ---------------------------------------- Misc #20524: mswin and gmp https://bugs.ruby-lang.org/issues/20524 * Author: MSP-Greg (Greg L) * Status: Open ---------------------------------------- Currently, the `vcpkg.json` file exists, and it can be used to specify what MSFT/vcpkg packages to install, and also a repo commit, which will determine the what package versions are used. The file lists the gmp package. 1. To use the gmp package in mswin, `win32/configure.bat` shows an option of `--with-gmp`. This option is not used in the `windows.yml` workflow file, nor is it mentioned in `doc/windows.md`. 2. When using the option, the build fails when compiling `bignum.c`, as it can’t find `gmp.h`. It appears the vcpkg include folder is not being passed to `cl`? So, it seems a few things are amiss. `gmp` was added a long time ago. With current mswin builds, will `gmp` improve `Bignum`’s performance? Is that unknown? If there are benchmarks to determine this, I could certainly run them… -- https://bugs.ruby-lang.org/
Issue #20524 has been updated by nagachika (Tomoyuki Chikanaga). Backport changed from 3.1: REQUIRED, 3.2: REQUIRED, 3.3: REQUIRED to 3.1: WONTFIX, 3.2: WONTFIX, 3.3: REQUIRED I think this is a kind of new feature of ruby build system. I won't backport it to 3.2 branch. It's up to kokubun-san for 3.3 branch. ---------------------------------------- Bug #20524: mswin and gmp https://bugs.ruby-lang.org/issues/20524#change-108746 * Author: MSP-Greg (Greg L) * Status: Closed * Backport: 3.1: WONTFIX, 3.2: WONTFIX, 3.3: REQUIRED ---------------------------------------- Currently, the `vcpkg.json` file exists, and it can be used to specify what MSFT/vcpkg packages to install, and also a repo commit, which will determine the what package versions are used. The file lists the gmp package. 1. To use the gmp package in mswin, `win32/configure.bat` shows an option of `--with-gmp`. This option is not used in the `windows.yml` workflow file, nor is it mentioned in `doc/windows.md`. 2. When using the option, the build fails when compiling `bignum.c`, as it can’t find `gmp.h`. It appears the vcpkg include folder is not being passed to `cl`? So, it seems a few things are amiss. `gmp` was added a long time ago. With current mswin builds, will `gmp` improve `Bignum`’s performance? Is that unknown? If there are benchmarks to determine this, I could certainly run them… -- https://bugs.ruby-lang.org/
Issue #20524 has been updated by k0kubun (Takashi Kokubun). Tracker changed from Bug to Feature Backport deleted (3.1: WONTFIX, 3.2: WONTFIX, 3.3: REQUIRED) seems like a new feature to me too. I won't backport it to 3.3. ---------------------------------------- Feature #20524: mswin and gmp https://bugs.ruby-lang.org/issues/20524#change-108799 * Author: MSP-Greg (Greg L) * Status: Closed ---------------------------------------- Currently, the `vcpkg.json` file exists, and it can be used to specify what MSFT/vcpkg packages to install, and also a repo commit, which will determine the what package versions are used. The file lists the gmp package. 1. To use the gmp package in mswin, `win32/configure.bat` shows an option of `--with-gmp`. This option is not used in the `windows.yml` workflow file, nor is it mentioned in `doc/windows.md`. 2. When using the option, the build fails when compiling `bignum.c`, as it can’t find `gmp.h`. It appears the vcpkg include folder is not being passed to `cl`? So, it seems a few things are amiss. `gmp` was added a long time ago. With current mswin builds, will `gmp` improve `Bignum`’s performance? Is that unknown? If there are benchmarks to determine this, I could certainly run them… -- https://bugs.ruby-lang.org/
participants (3)
-
k0kubun (Takashi Kokubun) -
MSP-Greg (Greg L)
-
nagachika (Tomoyuki Chikanaga)