[ruby-dev:52109] [Ruby master Bug#20633] compile error at vm_insnhelper.c when HAVE_DECL_ATOMIC_SIGNAL_FENCE is 0

2 Sep 2024

      Issue #20633 has been updated by ivoanjo (Ivo Anjo).

Hey @k0kubun I don't think 66312ad913d67bfd3c2c83b174eabf537f5def84 is related to this one? 👀

(Although I think this could be closed, as the fix + both backports have landed)

----------------------------------------
Bug #20633: compile error at vm_insnhelper.c when HAVE_DECL_ATOMIC_SIGNAL_FENCE is 0
https://bugs.ruby-lang.org/issues/20633#change-109574

* Author: kimuraw (Wataru Kimura)
* Status: Closed
* Backport: 3.2: DONE, 3.3: DONE
----------------------------------------
木村といいます。

最近導入された、vm_insnhelper.c 中での atomic_signal_fence()の呼び出し[1]が
config.hで ”#define HAVE_DECL_ATOMIC_SIGNAL_FENCE 0” のときコンパイルエラーになります。

おそらくコードの意図と異なると思うのでパッチ送ります。

```
compiling array.c
compiling vm.c
In file included from vm.c:514:
./vm_insnhelper.c:400:5: warning: implicit declaration of function 'atomic_signal_fence' is invalid in C99 [-Wimplicit-function-declaration]
    atomic_signal_fence(memory_order_seq_cst);
    ^
./vm_insnhelper.c:400:25: error: use of undeclared identifier 'memory_order_seq_cst'
    atomic_signal_fence(memory_order_seq_cst);
                        ^
1 warning and 1 error generated.
```

[1] Add explicit compiler fence when pushing frames to ensure safe profiling
https://github.com/ruby/ruby/commit/64fef3b870a8ed8147654531aef4c065d8a730c6

---Files--------------------------------
patch-vm_insnhelper.c.diff (535 Bytes)

-- 
https://bugs.ruby-lang.org/