Issue #22518 has been updated by k0kubun (Takashi Kokubun). Backport changed from 3.3: REQUIRED, 3.4: DONE, 4.0: REQUIRED to 3.3: REQUIRED, 3.4: DONE, 4.0: DONE ruby_4_0 commit:b4b3650232e550b418e66b9140fba41a4526aecb merged revision(s) commit:9deaec155c201ac11342adbd416bfeba42031d27. ---------------------------------------- Bug #22518: String#unpack("m") computes the buffer size with an overflowing multiplication https://bugs.ruby-lang.org/issues/22518#change-119987 * Author: mame (Yusuke Endoh) * Status: Closed * Backport: 3.3: REQUIRED, 3.4: DONE, 4.0: DONE ---------------------------------------- `(send - s + 3) * 3 / 4` overflows where long is 32-bit: an input of about 700 MB is rejected, and an input of about 1.4 GB makes it allocate a buffer too small. ```ruby # On a platform where long is 32-bit (tested with a 32-bit build, gcc -m32): ("A" * 1_450_000_000).unpack1("m").bytesize # expected: 1087500000 # actual: [BUG] probable buffer overflow: 1087500000 for 13758178 ("A" * 800_000_000).unpack1("m").bytesize # expected: 600000000 # actual: negative string size (or size too big) (ArgumentError) ``` -- https://bugs.ruby-lang.org/