Issue #22085 has been updated by byroot (Jean Boussier).
keep the warning for underflow. What do you think?
I understand where you are coming from, but my opinion is the same for both warnings, they're not actionable. Granted, these are verbose warnings, so mostly intended for development and test, but if I want to test that my program handles underflow input correctly, I now need to suppress warnings for that test case. Which is what brought me to open this issue, as I was trying to test `JSON.parse` handling of overflow/underflow: ```ruby NUMBERS.each do |number| assert_equal Float(number), JSON.parse(number) end ``` My opinion is that when user input in concerns, it's best to either raise loudly, or say nothing, similar to `"not-a-number".to_i` or `Integer("not-a-umber")`. ---------------------------------------- Feature #22085: `String#to_f` and `Kernel#Float` shouldn't issue out of range warnings https://bugs.ruby-lang.org/issues/22085#change-117546 * Author: byroot (Jean Boussier) * Status: Open ---------------------------------------- Ruby issue warnings when parsing out of range floats, e.g.: ``` $ ruby -We '1e184467440737095516160.to_s' -e:1: warning: Float 1e184467440737095516... out of range ``` This makes a lot of sense for float literals parsed by the Ruby parser. However I'm not convinced it makes sense when parsing user input or third party data: ```ruby
'1e184467440737095516160'.to_f (irb):1: warning: Float 1e184467440737095516... out of range => Infinity Float('1e184467440737095516160') <internal:kernel>:196: warning: Float 1e184467440737095516... out of range => Infinity
As these warnings aren't really actionable in most cases.
So I think `String#to_f` and `Kernel#Float` shouldn't issue out of range warnings.
--
https://bugs.ruby-lang.org/