Issue #21795 has been updated by Eregon (Benoit Daloze). kddnewton (Kevin Newton) wrote in #note-21:
Further evidence that the ABI version is good: since the beginning of 2024, we would only have had to bump the ABI version twice.
How did you determine this? As shown in #note-13, `node_id` is incompatible between prism 1.2.0 and 1.9.0. So we need to consider the order of nodes and their `node_id`, not just added/renamed/removed fields. The ABI approach won't work for a number of cases (whenever the ABI/node_id differ), and I don't think it's acceptable for usages of this new API to only work when ABI is exactly the same. For example, `error_highlight` should work whether the loaded prism gem ABI matches that or not. It cannot work with an old prism gem not able to parse RUBY_VERSION, but it should work in all other cases. ---------------------------------------- Feature #21795: Methods for retrieving ASTs https://bugs.ruby-lang.org/issues/21795#change-117120 * Author: kddnewton (Kevin Newton) * Status: Open ---------------------------------------- I would like to propose a handful of methods for retrieving ASTs from various objects that correspond to locations in code. This includes: * Proc#ast * Method#ast * UnboundMethod#ast * Thread::Backtrace::Location#ast * TracePoint#ast (on call/return events) The purpose of this is to make tooling easier to write and maintain. Specifically, this would be able to be used in irb, power_assert, error_highlight, and various other tools both in core and not that make use of source code. There have been many previous discussions of retrieving node_id, source_location, source, etc. All of these use cases are covered by returning the AST for some entity. In this case node_id becomes an implementation detail, invisible to the user. Source location can be derived from the information on the AST itself. Similarly, source can be derived from the AST. Internally, I do not think we have to store any more information than we already do (since we have node_id for the first four of these, it becomes rather trivial). For TracePoint we can have a larger discussion about it, but I think it should not be too much work. In terms of implementation, the only caveat I would put is that if the ISEQ were compiled through the old parser/compiler, this should return `nil`, as the node ids do not match up and we do not want to further propagate the RubyVM::AST API. The reason I am opening up this ticket with 5 different methods requested in it is to get approval first for the direction, then I can open individual tickets or just PRs for each method. I believe this feature would ease the maintenance burden of many core libraries, and unify otherwise disparate efforts to achieve the same thing. -- https://bugs.ruby-lang.org/