[ruby-core:124956] [Ruby Misc#21949] timeout gem maintainer
Issue #21949 has been reported by Eregon (Benoit Daloze). ---------------------------------------- Misc #21949: timeout gem maintainer https://bugs.ruby-lang.org/issues/21949 * Author: Eregon (Benoit Daloze) * Status: Open ---------------------------------------- The timeout has currently [no official active maintainers](https://github.com/ruby/ruby/blob/master/doc/maintainers.md). I would like to propose myself as maintainer of the [timeout](https://github.com/ruby/timeout) gem. I basically rewrote the implementation in https://github.com/ruby/timeout/pull/15 and acted as a maintainer since then by reviewing PRs and replying to issues. I also recently solved all open issues except https://github.com/ruby/timeout/issues/52 (where I have a draft PR to try to solve it and need more time to validate the fix). Among other [recent active contributors](https://github.com/ruby/timeout/graphs/contributors) I see @nobu, would you like to be maintainer of timeout as well? -- https://bugs.ruby-lang.org/
Issue #21949 has been updated by hsbt (Hiroshi SHIBATA). Status changed from Open to Rejected This is already rejected by Matz at https://github.com/ruby/ruby/pull/15424#issuecomment-3640875676 Discussing with multiple people means that it is not good for a single implementation maintainer to make the decision alone. ---------------------------------------- Misc #21949: timeout gem maintainer https://bugs.ruby-lang.org/issues/21949#change-116642 * Author: Eregon (Benoit Daloze) * Status: Rejected ---------------------------------------- The timeout gem has currently [no official active maintainers](https://github.com/ruby/ruby/blob/master/doc/maintainers.md). I would like to propose myself as maintainer of the [timeout](https://github.com/ruby/timeout) gem. I basically rewrote the implementation in https://github.com/ruby/timeout/pull/15 and acted as a maintainer since then by reviewing PRs and replying to issues. I also recently solved all open issues except https://github.com/ruby/timeout/issues/52 (where I have a draft PR to try to solve it and need more time to validate the fix). Among other [recent active contributors](https://github.com/ruby/timeout/graphs/contributors) I see @nobu, would you like to be maintainer of timeout as well? -- https://bugs.ruby-lang.org/
Issue #21949 has been updated by Eregon (Benoit Daloze). hsbt (Hiroshi SHIBATA) wrote in #note-2:
This is already rejected by Matz at https://github.com/ruby/ruby/pull/15424#issuecomment-3640875676
Matz said:
For timeout gem, the remaining issues are too difficult for a single person, IMO.
Hence why this proposal is to have both me and @nobu as maintainers (if @nobu is interested). @matz doesn't that address your concern?
Discussing with multiple people means that it is not good for a single implementation maintainer to make the decision alone.
I don't understand what is meant here, could you clarify? Other gems have multiple maintainers, and there seems to be no problem with it. Are you saying having no maintainers (or effectively "all Ruby committers but none is recognized as maintainer") is better than having multiple maintainers? ---------------------------------------- Misc #21949: timeout gem maintainer https://bugs.ruby-lang.org/issues/21949#change-116643 * Author: Eregon (Benoit Daloze) * Status: Rejected ---------------------------------------- The timeout gem has currently [no official active maintainers](https://github.com/ruby/ruby/blob/master/doc/maintainers.md). I would like to propose myself as maintainer of the [timeout](https://github.com/ruby/timeout) gem. I basically rewrote the implementation in https://github.com/ruby/timeout/pull/15 and acted as a maintainer since then by reviewing PRs and replying to issues. I also recently solved all open issues except https://github.com/ruby/timeout/issues/52 (where I have a draft PR to try to solve it and need more time to validate the fix). Among other [recent active contributors](https://github.com/ruby/timeout/graphs/contributors) I see @nobu, would you like to be maintainer of timeout as well? -- https://bugs.ruby-lang.org/
Issue #21949 has been updated by Eregon (Benoit Daloze). Status changed from Rejected to Open The timeout gem has no maintainer currently, so let's at least discuss this. ---------------------------------------- Misc #21949: timeout gem maintainer https://bugs.ruby-lang.org/issues/21949#change-116644 * Author: Eregon (Benoit Daloze) * Status: Open ---------------------------------------- The timeout gem has currently [no official active maintainers](https://github.com/ruby/ruby/blob/master/doc/maintainers.md). I would like to propose myself as maintainer of the [timeout](https://github.com/ruby/timeout) gem. I basically rewrote the implementation in https://github.com/ruby/timeout/pull/15 and acted as a maintainer since then by reviewing PRs and replying to issues. I also recently solved all open issues except https://github.com/ruby/timeout/issues/52 (where I have a draft PR to try to solve it and need more time to validate the fix). Among other [recent active contributors](https://github.com/ruby/timeout/graphs/contributors) I see @nobu, would you like to be maintainer of timeout as well? -- https://bugs.ruby-lang.org/
Issue #21949 has been updated by hsbt (Hiroshi SHIBATA). Status changed from Open to Rejected The fact that Matz is the maintainer means that development is done in agreement with the committers. Also, it would be very rude to say "there is no maintainer" when there is a maintainer's name. ---------------------------------------- Misc #21949: timeout gem maintainers https://bugs.ruby-lang.org/issues/21949#change-116648 * Author: Eregon (Benoit Daloze) * Status: Rejected ---------------------------------------- The timeout gem has currently [no official active maintainers](https://github.com/ruby/ruby/blob/master/doc/maintainers.md). I would like to propose myself and @nobu (see below) as maintainers of the [timeout](https://github.com/ruby/timeout) gem. I basically rewrote the implementation in https://github.com/ruby/timeout/pull/15 and acted as a maintainer since then by reviewing PRs and replying to issues. I also recently solved all open issues except https://github.com/ruby/timeout/issues/52 (where I have a draft PR to try to solve it and need more time to validate the fix). Among other [recent active contributors](https://github.com/ruby/timeout/graphs/contributors) I see @nobu, would you like to be maintainer of timeout as well? -- https://bugs.ruby-lang.org/
Issue #21949 has been updated by Eregon (Benoit Daloze). Status changed from Rejected to Open Let me explain my perspective on this: * I contributed significantly to ruby/timeout by [rewriting the implementation to be a lot faster](https://github.com/ruby/timeout/pull/15). * I already acted as a de-facto maintainer by reviewing PRs, triaging and fixing reported issues (some tricky issues which were opened for years). * I think this deserves recognition as being an official maintainer of the `timeout` gem (if not, what are the requirements for it?). * I am happy to have other maintainers for the gem. I think all maintainers should have non-trivial contributions to the gem. Also regarding:
For timeout gem, the remaining issues are too difficult for a single person, IMO.
I solved these issues (except one, where there is a draft PR), so I have shown it is not too difficult for one person to solve these issues. There might more meaning to this than the direct meaning though, which I guess matz would prefer to have multiple maintainers, hence the proposal of having me and @nobu as maintainers. ---------------------------------------- Misc #21949: timeout gem maintainers https://bugs.ruby-lang.org/issues/21949#change-116649 * Author: Eregon (Benoit Daloze) * Status: Open ---------------------------------------- The timeout gem has currently [no official active maintainers](https://github.com/ruby/ruby/blob/master/doc/maintainers.md). I would like to propose myself and @nobu (see below) as maintainers of the [timeout](https://github.com/ruby/timeout) gem. I basically rewrote the implementation in https://github.com/ruby/timeout/pull/15 and acted as a maintainer since then by reviewing PRs and replying to issues. I also recently solved all open issues except https://github.com/ruby/timeout/issues/52 (where I have a draft PR to try to solve it and need more time to validate the fix). Among other [recent active contributors](https://github.com/ruby/timeout/graphs/contributors) I see @nobu, would you like to be maintainer of timeout as well? -- https://bugs.ruby-lang.org/
Issue #21949 has been updated by Eregon (Benoit Daloze). hsbt (Hiroshi SHIBATA) wrote in #note-7:
The fact that Matz is the maintainer means that development is done in agreement with the committers.
I see, that was/is unclear to me, notably because development of `timeout` happens on GitHub (not on this issue tracker) and does not seem to require much consensus. What is the difference in practice with gems listed [here](https://github.com/ruby/ruby/blob/master/doc/maintainers.md) as "No maintainer"? Some other libs like `socket` have `API change needs matz's approval`, which is clear (and means API changes need an approved ticket on this tracker from matz).
Also, it would be very rude to say "there is no maintainer" when there is a maintainer's name.
I didn't say that, I said in the first sentence:
The timeout gem has currently no official active maintainers
And this is true in the literal sense, matz himself is not actively maintaining ruby/timeout. To be extra clear, I mean no disrespect to matz or anyone else. --- I feel your quick reject without much explanations is rude, though. Especially when from my POV I think I have addressed matz's concerns. It feels to me like you're trying to prevent to have a conversation on this. ---------------------------------------- Misc #21949: timeout gem maintainers https://bugs.ruby-lang.org/issues/21949#change-116650 * Author: Eregon (Benoit Daloze) * Status: Open ---------------------------------------- The timeout gem has currently [no official active maintainers](https://github.com/ruby/ruby/blob/master/doc/maintainers.md). I would like to propose myself and @nobu (see below) as maintainers of the [timeout](https://github.com/ruby/timeout) gem. I basically rewrote the implementation in https://github.com/ruby/timeout/pull/15 and acted as a maintainer since then by reviewing PRs and replying to issues. I also recently solved all open issues except https://github.com/ruby/timeout/issues/52 (where I have a draft PR to try to solve it and need more time to validate the fix). Among other [recent active contributors](https://github.com/ruby/timeout/graphs/contributors) I see @nobu, would you like to be maintainer of timeout as well? -- https://bugs.ruby-lang.org/
Issue #21949 has been updated by Eregon (Benoit Daloze). I think some misunderstanding here is I interpret `matz` being listed as the maintainer of `timeout` as matz historically wrote and maintained `lib/timeout.rb`, and some special meaning. ---------------------------------------- Misc #21949: timeout gem maintainers https://bugs.ruby-lang.org/issues/21949#change-116651 * Author: Eregon (Benoit Daloze) * Status: Open ---------------------------------------- The timeout gem has currently [no official active maintainers](https://github.com/ruby/ruby/blob/master/doc/maintainers.md). I would like to propose myself and @nobu (see below) as maintainers of the [timeout](https://github.com/ruby/timeout) gem. I basically rewrote the implementation in https://github.com/ruby/timeout/pull/15 and acted as a maintainer since then by reviewing PRs and replying to issues. I also recently solved all open issues except https://github.com/ruby/timeout/issues/52 (where I have a draft PR to try to solve it and need more time to validate the fix). Among other [recent active contributors](https://github.com/ruby/timeout/graphs/contributors) I see @nobu, would you like to be maintainer of timeout as well? -- https://bugs.ruby-lang.org/
Issue #21949 has been updated by Eregon (Benoit Daloze). hsbt (Hiroshi SHIBATA) wrote in #note-7:
Also, it would be very rude to say "there is no maintainer" when there is a maintainer's name.
Ah I see, you mean https://bugs.ruby-lang.org/issues/21949#note-4 I think from the context of this issue and the "currently" it means rather clearly "no official active maintainers". But if it has been understood differently, I apologize about that. ---------------------------------------- Misc #21949: timeout gem maintainers https://bugs.ruby-lang.org/issues/21949#change-116652 * Author: Eregon (Benoit Daloze) * Status: Open ---------------------------------------- The timeout gem has currently [no official active maintainers](https://github.com/ruby/ruby/blob/master/doc/maintainers.md). I would like to propose myself and @nobu (see below) as maintainers of the [timeout](https://github.com/ruby/timeout) gem. I basically rewrote the implementation in https://github.com/ruby/timeout/pull/15 and acted as a maintainer since then by reviewing PRs and replying to issues. I also recently solved all open issues except https://github.com/ruby/timeout/issues/52 (where I have a draft PR to try to solve it and need more time to validate the fix). Among other [recent active contributors](https://github.com/ruby/timeout/graphs/contributors) I see @nobu, would you like to be maintainer of timeout as well? -- https://bugs.ruby-lang.org/
participants (2)
-
Eregon (Benoit Daloze) -
hsbt (Hiroshi SHIBATA)