[ruby-core:113994] [Ruby master Feature#19742] Introduce `Module#anonymous?`

Issue #19742 has been updated by ioquatix (Samuel Williams). I'm not that different, except Anonymous to me means you don't have a name [that resolves to self]. If the module has a name that resolves to itself, it is not anonymous. I would say a lot of the rails code should be rewritten just to check `name` itself, e.g. ``` @mailer_name ||= anonymous? ? "anonymous" : name.underscore # becomes @mailer_name ||= name&.underscore || "anonymous" @controller_name ||= (name.demodulize.delete_suffix("Controller").underscore unless anonymous?) # becomes @controller_name ||= (name ? name.demodulize.delete_suffix("Controller").underscore : nil) ``` I think this is much more direct and I don't think Rails should monkey patch Module in this way. ---------------------------------------- Feature #19742: Introduce `Module#anonymous?` https://bugs.ruby-lang.org/issues/19742#change-103652 * Author: ioquatix (Samuel Williams) * Status: Open * Priority: Normal ---------------------------------------- As a follow-on <from https://bugs.ruby-lang.org/issues/19521>gt;, I'd like propose we introduce `Module#anonymous?`. In some situations, like logging/formatting, serialisation/deserialization, debugging or meta-programming, we might like to know if a class is a proper constant or not. However, this brings about some other issues which might need to be discussed. After assigning a constant, then removing it, the internal state of Ruby still believes that the class name is permanent, even thought it's no longer true. e.g. ``` m = Module.new m.anonymous? # true M = m m.anonyomous # false Object.send(:remove_const, :M) M # uninitialized constant M (NameError) m.anonymous? # false ``` Because RCLASS data structure is not updated after the constant is removed, internally the state still has a "permanent class name". I want to use this proposal to discuss this issue and whether there is anything we should do about such behaviour (or even if it's desirable). Proposed PR: https://github.com/ruby/ruby/pull/7966 cc @fxn -- https://bugs.ruby-lang.org/