Issue #20451 has been updated by nobu (Nobuyoshi Nakada).
Backport changed from 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN to 3.0:
UNKNOWN, 3.1: REQUIRED, 3.2: DONTNEED, 3.3: DONTNEED
It seems a4ad6bd9aac564e93219284c912b26a72f9e82fc is missing.
----------------------------------------
Bug #20451: Bad Ruby 3.1.5 backport causes fiddle to fail to build
https://bugs.ruby-lang.org/issues/20451#change-108155
* Author: Bo98 (Bo Anderson)
* Status: Open
* ruby -v: 3.1.5p252
* Backport: 3.0: UNKNOWN, 3.1: REQUIRED, 3.2: DONTNEED, 3.3: DONTNEED
----------------------------------------
Ruby 3.1.5 shipped with the following backport:
https://github.com/ruby/ruby/commit/84f2aabd272a54e79979795d2d405090704a1d07
However this backport directly breaks the build:
```
closure.c:279:60: error: use of undeclared identifier 'data'
result = ffi_prep_closure(pcl, cif, callback, (void *)(data->self));
^
```
The original commit (
https://github.com/ruby/fiddle/commit/2530496602) was updating the
second branch to match the change in the first branch a couple lines up. However that
change in the other branch does not exist in Ruby 3.1. The commit in question requires a
previous commit of
https://github.com/ruby/fiddle/commit/81a8a56239973ab7559229830a449d201955b….
The backport should either be reverted or an other commit should also be backported. Note
that these commits were in a series of many commits made to fix an upstream issue
https://github.com/ruby/fiddle/issues/102 so I cannot vouch whether or not the two commits
are sufficient to fix the originally reported issue.
--
https://bugs.ruby-lang.org/