December 2022 - ruby-core - ml.ruby-lang.org

[ruby-core:111287] [Ruby master Bug#19235] StringIO.new(encoding: "ext_enc:int_enc") doesn't set external encoding
by andrykonchin (Andrew Konchin) 28 Jan '23

28 Jan '23

Issue #19235 has been reported by andrykonchin (Andrew Konchin). ---------------------------------------- Bug #19235: StringIO.new(encoding: "ext_enc:int_enc") doesn't set external encoding https://bugs.ruby-lang.org/issues/19235 * Author: andrykonchin (Andrew Konchin) * Status: Open * Priority: Normal * ruby -v: 3.1.2 * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN ---------------------------------------- I noticed a divergence between IO `:encoding` option documentation and StringIO's behaviour: ```ruby io = StringIO.new('', 'w', encoding: 'utf-8:ISO-8859-1') io.external_encoding # => #<Encoding:ISO-8859-1> ``` The IO class behaves in expected way: ```ruby f = File.open("test.txt", 'w', encoding: 'UTF-8:ISO-8859-1') f.external_encoding # => #<Encoding:UTF-8> ``` -- https://bugs.ruby-lang.org/

2 3

[ruby-core:111529] [Ruby master Bug#19289] RbConfig::CONFIG["STRIP"] should keep `rb_abi_version` and `rb_abi_version` should always be part of Ruby
by Eregon (Benoit Daloze) 25 Jan '23

25 Jan '23

Issue #19289 has been reported by Eregon (Benoit Daloze). ---------------------------------------- Bug #19289: RbConfig::CONFIG["STRIP"] should keep `rb_abi_version` and `rb_abi_version` should always be part of Ruby https://bugs.ruby-lang.org/issues/19289 * Author: Eregon (Benoit Daloze) * Status: Open * Priority: Normal * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- From https://github.com/grpc/grpc/pull/31970 and https://github.com/redis-rb/redis-client/issues/58 First, I think we could add `-K rb_abi_version` to `RbConfig::CONFIG["STRIP"]` so it's automatically kept if `RbConfig::CONFIG["STRIP"]` is used (and that should be used if one strips any native extension). Second, I think it would be much better if the symbol is kept also for releases. The check could be kept too for safety (e.g., it can detect Ruby 3.3.0 gems used by Ruby 3.2.0), the value of `rb_abi_version` would just be the same as `RbConfig::CONFIG["ruby_version"]`, i.e., 3.2.0 for Ruby 3.2.x. Any difference between dev and release builds is a risk of not properly testing the release, and there is proof here that removing the symbol in releases causes troubles. Doing both of these would avoid complex and brittle logic upstream as in grpc and redis-client to deal with the new symbol. cc @nobu @peterzhu2118 -- https://bugs.ruby-lang.org/

4 7

[ruby-core:111356] [Ruby master Misc#19247] Ruby 3.2 documentation problems tracker
by zverok (Victor Shepelev) 22 Jan '23

22 Jan '23

Issue #19247 has been reported by zverok (Victor Shepelev). ---------------------------------------- Misc #19247: Ruby 3.2 documentation problems tracker https://bugs.ruby-lang.org/issues/19247 * Author: zverok (Victor Shepelev) * Status: Open * Priority: Normal * Assignee: zverok (Victor Shepelev) ---------------------------------------- Bugs and problems: * [Fiber](https://docs.ruby-lang.org/en/master/Fiber.html): * Formatting glitches for `::[]`, `::[]=`, `::storage`, `::storage=` (no references to companion methods) * Also there are some rendering glitches in Fiber, due to RDoc update? (Source didn't change) * After renaming SchedulerInterface to Scheduler, reference to it from Fiber are lost * [FiberScheduler](https://docs.ruby-lang.org/en/master/Fiber/Scheduler.html) has no docs for new method `#io_select` * [SyntaxError](https://docs.ruby-lang.org/en/master/SyntaxError.html): new attribute `#path` wrongly rendered * [RubyVM::AbstractSyntaxTree](https://docs.ruby-lang.org/en/master/RubyVM/Abs…: `error_tolerant:` and `keep_tokens:` options aren't documented or mentioned in the docs * [Set](https://docs.ruby-lang.org/en/master/Set.html): docs still start with `require 'set'` :) * [Struct](https://docs.ruby-lang.org/en/master/Struct.html): no mention of the changed requirement about keyword initialization. * [Time#deconstruct_keys](https://docs.ruby-lang.org/en/master/Time.html#metho… instead of listing keys refers to "the same as returned by to_h", which we decided not to implement, my bad! * [UnboundMethod#==](https://docs.ruby-lang.org/en/master/UnboundMethod.html#m… says that methods are equal if are bound to the same object :) (shares docs with `Method`?..) * [GC::latest_gc_info](https://docs.ruby-lang.org/en/master/GC.html#method-c-l… rendering glitch (old probably). It also lacks any docs about the structure of the hash returned. * [ObjectSpace.dump_all](https://docs.ruby-lang.org/en/master/ObjectSpace.html… and several companion methods are weirdly documented as instance methods (RDoc glitch, doubtfully easy to fix) Things that could be improved: * [Module#undefined_instance_methods](https://docs.ruby-lang.org/en/master/Mod… is not really helpful :) * [Refinement#refined_class](https://docs.ruby-lang.org/en/master/Refinement.h… can use better explanation/example? * [Thread::each_caller_location](https://docs.ruby-lang.org/en/master/Thread.h… can use an example? (Also wrongly referred as instance method in [NEWS](https://docs.ruby-lang.org/en/master/NEWS_md.html#label-Core+classes+…) I'll try to work on those ASAP. -- https://bugs.ruby-lang.org/

1 5

[ruby-core:111522] [Ruby master Bug#19286] What should kwargs' arity be?
by matsuda (Akira Matsuda) 20 Jan '23

20 Jan '23

Issue #19286 has been reported by matsuda (Akira Matsuda). ---------------------------------------- Bug #19286: What should kwargs' arity be? https://bugs.ruby-lang.org/issues/19286 * Author: matsuda (Akira Matsuda) * Status: Open * Priority: Normal * ruby -v: ruby 3.3.0dev (2022-12-28T16:43:05Z master cada537040) +YJIT [arm64-darwin21] * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- Hello, guys. It's time for a quick Ruby quiz. Q: What is this method's arity? def f(a:, b:) end It requires two arguments, hence it should be 2? Or if we call this method with one argument, the error message says "wrong number of arguments (given 1, expected 0; required keywords: a, b) (ArgumentError)", which means the arity is 0, maybe? A: The answer is, $ all-ruby -e 'p method(def f(a:, b:) end).arity' ruby-2.1.0-preview1 0 ... ruby-2.1.0 0 ruby-2.1.1 -1 ruby-2.1.2 1 ... ruby-3.1.0 1 it's been 1 since 2.1.2. But why 1? Why not 2 nor 0? I asked this question to the ruby-core people, and ko1's answer was that even he has no idea what the number 1 means. ![](random_-_ruby-lang_-_Slack.png) So I thought it'd be worth asking this question here. ---Files-------------------------------- random_-_ruby-lang_-_Slack.png (40.1 KB) -- https://bugs.ruby-lang.org/

5 5

[ruby-core:111308] [Ruby master Bug#19237] Hash default_proc is not thread-safe to lazy-initialize value for a given key
by Eregon (Benoit Daloze) 20 Jan '23

20 Jan '23

Issue #19237 has been reported by Eregon (Benoit Daloze). ---------------------------------------- Bug #19237: Hash default_proc is not thread-safe to lazy-initialize value for a given key https://bugs.ruby-lang.org/issues/19237 * Author: Eregon (Benoit Daloze) * Status: Open * Priority: Normal * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN ---------------------------------------- ```ruby 1000.times do h = Hash.new do |hash, key| # Note, with [] instead of Array.new below is seems to work # but then e.g. anything else in this block like Thread.pass also breaks it hash[key] = Array.new end go = false threads = 100.times.map do Thread.new do Thread.pass until go h[:na] << true end end go = true threads.each(&:join) raise "Expected 100 elements but was #{h[:na].size}" if h[:na].size != 100 end ``` gives (in 3 runs): ``` concurrent_hash_default_proc.rb:17:in `block in <main>': Expected 100 elements but was 1 (RuntimeError) concurrent_hash_default_proc.rb:17:in `block in <main>': Expected 100 elements but was 3 (RuntimeError) concurrent_hash_default_proc.rb:17:in `block in <main>': Expected 100 elements but was 2 (RuntimeError) ``` So what happens is the same Hash entry gets assigned multiple times, which feels quite unexpected and cause fairly surprising bugs (e.g. elements "disappearing" etc). Any thoughts on how to solve that in CRuby? In my PhD thesis one way I found is to actually pass a different object than the Hash itself as the first argument to the block. See https://eregon.me/blog/assets/research/thesis-thread-safe-data-representati… page 83 `Idiomatic Concurrent Hash Operations`. In short, it replaces `[]=` calls in the initializer block with `put_if_absent` by passing a different object than the Concurrent::Hash itself, which overrides `[]=` and delegates the rest. #19069 could be another way but there are compatibility issues (e.g. storing when it previously would not for `Hash.new { |h,k| k * 3 }`. There is also the question whether the block should be allowed to execute more than once for a given key. I think that is difficult to solve (probably the only way is via some lock, but then that can lead to deadlocks), and less important than ensuring the value is only assigned once for a given key. --- Note that concurrent-ruby has the same issue because it uses ::Array/::Hash on CRuby: https://github.com/ruby-concurrency/concurrent-ruby/issues/970#issuecomment… There is also more discussions about trade-offs there which apply to `Hash` too. -- https://bugs.ruby-lang.org/

2 1

[ruby-core:111339] [Ruby master Feature#19245] Strict mode for Array#pack that doesn't silently truncate numbers that are too large for the given directive
by byroot (Jean Boussier) 20 Jan '23

20 Jan '23

Issue #19245 has been reported by byroot (Jean Boussier). ---------------------------------------- Feature #19245: Strict mode for Array#pack that doesn't silently truncate numbers that are too large for the given directive https://bugs.ruby-lang.org/issues/19245 * Author: byroot (Jean Boussier) * Status: Open * Priority: Normal ---------------------------------------- ```ruby >> [256].pack("C").unpack1("C") => 0 >> [257].pack("C").unpack1("C") => 1 ``` This is specified: ```ruby it "encodes the least significant 32 bits of a negative number" do [ [[-0x0000_0021], "\xdf\xff\xff\xff"], [[-0x0000_4321], "\xdf\xbc\xff\xff"], [[-0x0065_4321], "\xdf\xbc\x9a\xff"], [[-0x7865_4321], "\xdf\xbc\x9a\x87"] ].should be_computed_by(:pack, pack_format()) end ``` But not documented in `Array#pack`. I think that in many case this may lead to silent bugs. ### Possible solutions We could have a strict version of `pack`, either `pack(template, strict: true)` or `pack!(template)`. Or alternatively if we think this is never a desired behavior, we could change `pack` to first warn on truncation and later raise. -- https://bugs.ruby-lang.org/

5 7

[ruby-core:111446] [Ruby master Misc#19265] please remove rust yjit
by darkspy (gerty ken) 19 Jan '23

19 Jan '23

Issue #19265 has been reported by darkspy (gerty ken). ---------------------------------------- Misc #19265: please remove rust yjit https://bugs.ruby-lang.org/issues/19265 * Author: darkspy (gerty ken) * Status: Open * Priority: Normal ---------------------------------------- my job is heavily ruby coding and following ruby new versions.(servers and business depend on ruby, like heavy java server clusters) my one part of job is compile and customizing ruby for use in company. it's works ok until 3.1.x but 3.2 changes yjit to rust. that means i need to learn new lang and download new toolchains to build ruby(still, it can ignoring build yjit), but we core team using yjit for monthes and can't handle code out of c/c++ especially rust. it's too ugly to acceptable(syntax and compile time, sorry to say that, but it's true for us) please consider our advices to remove rust code to c++(if u think c99 is hard to handle) or zig or any other faster lang, but no rust please. for now we just try to back port 3.1 yjit to 3.2 :( thanks, regards. Ken -- https://bugs.ruby-lang.org/

3 2

[ruby-core:111435] [Ruby master Bug#19262] Segmentation fault on RubyVM::AbstractSyntaxTree.node_id_for_backtrace_location
by ksss (Yuki Kurihara) 19 Jan '23

19 Jan '23

Issue #19262 has been reported by ksss (Yuki Kurihara). ---------------------------------------- Bug #19262: Segmentation fault on RubyVM::AbstractSyntaxTree.node_id_for_backtrace_location https://bugs.ruby-lang.org/issues/19262 * Author: ksss (Yuki Kurihara) * Status: Open * Priority: Normal * ruby -v: ruby 3.2.0 (2022-12-25 revision a528908271) [arm64-darwin21] * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN ---------------------------------------- It seems that `RubyVM::AbstractSyntaxTree.node_id_for_backtrace_location` gives a Segmentation fault if any argument other than `Thread::Backtrace::Location` is given. repro: ``` $ ruby -e 'RubyVM::AbstractSyntaxTree.node_id_for_backtrace_location(1)' ``` -- https://bugs.ruby-lang.org/

2 1

[ruby-core:111361] [Ruby master Bug#19248] TestGCCompact#test_moving_objects_between_size_pools test failure
by vo.x (Vit Ondruch) 19 Jan '23

19 Jan '23

Issue #19248 has been reported by vo.x (Vit Ondruch). ---------------------------------------- Bug #19248: TestGCCompact#test_moving_objects_between_size_pools test failure https://bugs.ruby-lang.org/issues/19248 * Author: vo.x (Vit Ondruch) * Status: Open * Priority: Normal * ruby -v: ruby 3.2.0dev (2022-12-21 master 6af6857ecf) [x86_64-linux] * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN ---------------------------------------- Testing on Fedora Rawhide with commit:git|6af6857ecf, I observe the following error: ~~~ 1) Error: TestGCCompact#test_moving_objects_between_size_pools: NoMethodError: undefined method `>=' for nil:NilClass /builddir/build/BUILD/ruby-3.2.0-6af6857ecf/test/ruby/test_gc_compact.rb:278:in `<main>' /builddir/build/BUILD/ruby-3.2.0-6af6857ecf/test/ruby/test_gc_compact.rb:256:in `test_moving_objects_between_size_pools' /builddir/build/BUILD/ruby-3.2.0-6af6857ecf/tool/test/runner.rb:23:in `<top (required)>' /builddir/build/BUILD/ruby-3.2.0-6af6857ecf/test/runner.rb:16:in `require_relative' /builddir/build/BUILD/ruby-3.2.0-6af6857ecf/test/runner.rb:16:in `<main>' ~~~ Testing previously with commit:git|11acb7f7bc, everything was fine. I might just guess that this is related to commit:git|bfc66e07b7e0134dfa2041c311dc56941fe1caf0 -- https://bugs.ruby-lang.org/

6 24

[ruby-core:111456] [Ruby master Bug#19271] irb ignores rbs and debug with YJIT enabled
by olivierlacan (Olivier Lacan) 18 Jan '23

18 Jan '23

Issue #19271 has been reported by olivierlacan (Olivier Lacan). ---------------------------------------- Bug #19271: irb ignores rbs and debug with YJIT enabled https://bugs.ruby-lang.org/issues/19271 * Author: olivierlacan (Olivier Lacan) * Status: Open * Priority: Normal * ruby -v: ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [arm64-darwin21] * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- Not sure this is a serious issue but when starting IRB with YJIT enabled this (potentially confusing) message is immediately printed: ``` $ RUBY_YJIT_ENABLE=1 irb Ignoring debug-1.7.1 because its extensions are not built. Try: gem pristine debug --version 1.7.1 Ignoring rbs-2.8.2 because its extensions are not built. Try: gem pristine rbs --version 2.8.2 irb(main):001:0> ``` This is on a fresh installation of Ruby 3.2.0 with an empty Gemfile in the directory. I haven't run gem pristine on any gem since I hadn't installed any gems after installing Ruby 3.2.0 here but FYI: ``` $ gem list | grep "rbs\|debug" debug (1.7.1) rbs (2.8.2) ``` This seems to suggest that C extensions weren't built for those gems when they were installed during the Ruby installation process. Just to be safe I checked and while I do use rbenv and ruby-build to compile and manage Rubies, I don't have a default gem installer set up so as far as I know these gems weren't installed by my system. -- https://bugs.ruby-lang.org/

6 8