October 2023 - ruby-core - ml.ruby-lang.org

[ruby-core:114937] [Ruby master Feature#18915] New error class: NotImplementedYetError or scope change for NotImplementedError
by zdennis (Zach Dennis) 02 Oct '23

02 Oct '23

Issue #18915 has been updated by zdennis (Zach Dennis). File not-implemented-error-docs.patch added Attached is a patch to update the documentation for NotImplementedError to expand its scope beyond just missing features on the underlying platform. The current documentation has been in place since just before Ruby 1.9.2. Historically, it appears that Ruby hasn't limited its usage of NotImplementedError to errors that originate from features missing from the underlying platform (e.g. system calls) since at least 1.8.0. I believe the example provided in the current NotImplementedError documentation was meant as an example, not to suggest the only scope in which this error can be used. Ruby itself invalidates most of the interpretation provided in the Background section of this ticket. Here are just three examples: - [numeric.c](https://github.com/ruby/ruby/blob/50520cc1930331bccdb94730e17ddc… raises NotImplementedError when a class needs provide its own <=> method. - [delegate.rb](https://github.com/ruby/ruby/blob/c4d22d47f8bd019ae6df98fafb9d… raises NotImplementedError to indicate that a __getobj__ and __setobj__ need to provided by a subclass. - [tsort](https://github.com/ruby/ruby/blob/6dcd39997679914dad1c23f95adb3f7d84… uses this error and documents it expressly as: Should be implemented by a extended class. There are more examples to be found in Ruby as well. Outside of Ruby, this pattern is also commonly used as a way to communicate the intent to an application, framework, or library developer. Here are four examples from popular projects: - [rails uses this pattern](https://github.com/search?q=org%3Arails%20NotImplementedError&type… - [minitest uses this pattern](https://github.com/search?q=repo%3Aminitest%2Fminitest%20NotImplem… - [rspec uses this pattern](https://github.com/search?q=org%3Arspec%20NotImplementedError&type… - [dry-rb libraries use this pattern](https://github.com/search?q=org%3Adry-rb+NotImplementedError&type=… Additionally, even the latest Programming Ruby 3.2 book by PragPub uses an example of this in Chapter 6: Inheritance and Messages. ---------------------------------------- Feature #18915: New error class: NotImplementedYetError or scope change for NotImplementedError https://bugs.ruby-lang.org/issues/18915#change-104811 * Author: Quintasan (Michał Zając) * Status: Open * Priority: Normal ---------------------------------------- # Abstract Introduce `NotImplementedYetError` exception that should be used in case when the codepath has not been implemented by the developer for some reason (maybe they're designing an abstract class or are designing some sort of interface to reuse later on) OR extend the meaning of `NotImplementedError` to cover those usecases so we don't have to introduce another exception # Background `NotImplementedError` is supposed to be raised `if the underlying operating system or Ruby runtime does not support them` (https://ruby-doc.org/core-3.1.2/NotImplementedError.html) However it appears that many people are misusing this exception by raising this in a superclass from which they later inherit from. I do realize that Ruby promotes duck-typing (the default RuboCop style guide has a cop for this – https://github.com/rubocop/ruby-style-guide#duck-typing) However I have seen this being discussed numerous times: * https://github.com/rubocop/ruby-style-guide/issues/458 * http://chrisstump.online/2016/03/23/stop-abusing-notimplementederror/ * https://oleg0potapov.medium.com/ruby-notimplementederror-dont-use-it-dff1fd… * https://gitlab.com/gitlab-org/gitlab/-/issues/354314 (which I'm the author of) * https://github.com/rmosolgo/graphql-ruby/issues/2067 (here the author actually confused it with Python's `NotImplementedError`) * https://stackoverflow.com/questions/13668068/how-to-signal-not-implemented-… # Proposal Create `NotImplementedYetError` exception OR Allow raising `NotImplementedError` in cases other than OS or Ruby runtime incompatibilities # Evaluation ### Add `NotImplementedYetError` I think a new exception is a better idea than changing the usage of an existing one just because "everyone is using it". That said it would require people to refactor their code which might prevent wider adoption of the new exception. ### Change scope of `NotImplementedError` This would require the least amount of changes possible (only a documentation change) and I believe there would be no compatibility problems whatsoever. ---Files-------------------------------- not-implemented-error-docs.patch (0 Bytes) -- https://bugs.ruby-lang.org/

1 0

[ruby-core:114925] [Ruby master Bug#19906] fix kwarg memory leak
by HParker (Adam Hess) 01 Oct '23

01 Oct '23

Issue #19906 has been reported by HParker (Adam Hess). ---------------------------------------- Bug #19906: fix kwarg memory leak https://bugs.ruby-lang.org/issues/19906 * Author: HParker (Adam Hess) * Status: Open * Priority: Normal * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- GitHub PR: https://github.com/ruby/ruby/pull/8556 ci info tracks kwargs and which are shared across aliases ```ruby 30.times do 100_000.times do def foo(k:); yield; end alias bar foo undef foo end puts `ps -o rss= -p #{$$}` end ``` before: ``` 30364 45120 59700 73932 88512 102680 116884 130884 145308 159688 174468 188680 203016 216908 231568 246096 260592 274900 289168 303420 317620 331956 346148 360708 374880 389172 403472 417824 432016 446040 460196 474604 489152 503248 517504 531944 546228 560520 574760 589108 ``` after: ``` 8760 8940 9156 9540 9548 9548 9548 9548 9548 9548 9548 9548 9548 9548 9548 9548 9548 9548 9548 9548 9556 9564 9564 9564 9564 9564 9564 9564 9564 9564 9564 9564 9564 9576 9744 9744 9744 9744 9744 9936 ``` -- https://bugs.ruby-lang.org/

2 2

[ruby-core:114933] [Ruby master Bug#10416] Create mechanism for updating of Unicode data files downstreams when we want
by nobu (Nobuyoshi Nakada) 01 Oct '23

01 Oct '23

Issue #10416 has been updated by nobu (Nobuyoshi Nakada). The current enc-unicode.rb seems to fail because of `Indic_Conjunct_break` properties with values. I'm not sure how these properties should be handled well. `/\p{InCB_Liner}/` or `/\p{InCB=Liner}/` as the comments in that file? https://github.com/nobu/ruby/tree/unicode-15.1 is the former. ---------------------------------------- Bug #10416: Create mechanism for updating of Unicode data files downstreams when we want https://bugs.ruby-lang.org/issues/10416#change-104804 * Author: duerst (Martin Dürst) * Status: Open * Priority: Normal * Assignee: nobu (Nobuyoshi Nakada) * ruby -v: ruby 2.2.0dev (2014-10-22 trunk 48092) [x86_64-cygwin] * Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN ---------------------------------------- The current mechanism for updating Unicode data files will create the following problem: Downstream compilers/packagers will download Unicode data files ONE time (they may already have done so). However, if they don't activate ALWAYS_UPDATE_UNICODE = yes, these files will never get updated, and they will stay on Unicode version 7.0 even if in five years Unicode is e.g. on version 12.0. On the other hand, if they activate ALWAYS_UPDATE_UNICODE = yes (and assuming issue #10415 gets fixed), they constantly update to the latest version of Unicode. That's good for those who actually want this, but now what our current policy is. What's missing is that we (Ruby core) can make sure downstream checkouts update to a new Unicode version when we want then to do so (as we e.g. can do for other parts that are based on Unicode data, see e.g. https://bugs.ruby-lang.org/issues/9092) without sending an email to everybody and hoping they read and follow it. [Currently, the only solution I know will work is the one pointed out by Yui Naruse in https://bugs.ruby-lang.org/issues/10084#note-17, but I'm okay with any other solution.] -- https://bugs.ruby-lang.org/

1 0