March 2023 - ruby-core - ml.ruby-lang.org

[ruby-core:113014] [Ruby master Bug#18464] RUBY_INTERNAL_EVENT_NEWOBJ tracepoint causes an interpreter crash when combined with Ractors
by nagachika (Tomoyuki Chikanaga) 25 Mar '23

25 Mar '23

Issue #18464 has been updated by nagachika (Tomoyuki Chikanaga). Backport changed from 2.6: DONTNEED, 2.7: DONTNEED, 3.0: REQUIRED, 3.1: REQUIRED, 3.2: REQUIRED to 2.6: DONTNEED, 2.7: DONTNEED, 3.0: REQUIRED, 3.1: DONE, 3.2: REQUIRED ruby_3_1 bdbe6053853c11ffe9b8737eb4da50ed84c9dbd6 merged revision(s) 7bd7aee02e303de27d2cddfc5ef47e612d6782cb. ---------------------------------------- Bug #18464: RUBY_INTERNAL_EVENT_NEWOBJ tracepoint causes an interpreter crash when combined with Ractors https://bugs.ruby-lang.org/issues/18464#change-102549 * Author: kjtsanaktsidis (KJ Tsanaktsidis) * Status: Closed * Priority: Normal * Assignee: ko1 (Koichi Sasada) * ruby -v: ruby 3.1.0p0 (2021-12-25 revision fb4df44d16) [x86_64-darwin20] * Backport: 2.6: DONTNEED, 2.7: DONTNEED, 3.0: REQUIRED, 3.1: DONE, 3.2: REQUIRED ---------------------------------------- When a Ractor is created whilst a tracepoint for `RUBY_INTERNAL_EVENT_NEWOBJ` is active (registered with `rb_tracepoint_new`/`rb_tracepoint_enabled`), the interpreter crashes with a null pointer dereference with the following backtrace: ``` [BUG] Segmentation fault at 0x0000000000000000 ruby 3.1.0p0 (2021-12-25 revision fb4df44d16) [x86_64-darwin20] ... -- C level backtrace information ------------------------------------------- /Users/ktsanaktsidis/Code/zendesk/ruby/ruby(rb_print_backtrace+0xf) [0x10a15fadd] vm_dump.c:759 /Users/ktsanaktsidis/Code/zendesk/ruby/ruby(rb_vm_bugreport) vm_dump.c:1045 /Users/ktsanaktsidis/Code/zendesk/ruby/ruby(rb_vm_bugreport) (null):0 /Users/ktsanaktsidis/Code/zendesk/ruby/ruby(bug_report_end+0x0) [0x109f96b81] error.c:820 /Users/ktsanaktsidis/Code/zendesk/ruby/ruby(rb_bug_for_fatal_signal) error.c:820 /Users/ktsanaktsidis/Code/zendesk/ruby/ruby(sigsegv+0x52) [0x10a0be3a2] signal.c:964 /usr/lib/system/libsystem_platform.dylib(_sigtramp+0x1d) [0x7fff20934d7d] /Users/ktsanaktsidis/Code/zendesk/ruby/ruby(gc_event_hook_body+0x4) [0x109fb9d21] gc.c:2214 /Users/ktsanaktsidis/Code/zendesk/ruby/ruby(newobj_slowpath) gc.c:2486 /Users/ktsanaktsidis/Code/zendesk/ruby/ruby(newobj_slowpath_wb_unprotected) gc.c:2507 /Users/ktsanaktsidis/Code/zendesk/ruby/ruby(newobj_fill+0x0) [0x109fac92e] gc.c:2543 /Users/ktsanaktsidis/Code/zendesk/ruby/ruby(newobj_of0) gc.c:2553 /Users/ktsanaktsidis/Code/zendesk/ruby/ruby(newobj_of) gc.c:2552 /Users/ktsanaktsidis/Code/zendesk/ruby/ruby(rb_wb_unprotected_newobj_of) gc.c:2567 /Users/ktsanaktsidis/Code/zendesk/ruby/ruby(io_alloc+0x12) [0x109fd341c] io.c:1047 /Users/ktsanaktsidis/Code/zendesk/ruby/ruby(prep_io) io.c:8483 /Users/ktsanaktsidis/Code/zendesk/ruby/ruby(prep_stdio) io.c:8514 /Users/ktsanaktsidis/Code/zendesk/ruby/ruby(rb_io_prep_stdin) io.c:8532 /Users/ktsanaktsidis/Code/zendesk/ruby/ruby(thread_start_func_2+0xf7) [0x10a1058a7] thread.c:802 /Users/ktsanaktsidis/Code/zendesk/ruby/ruby(rb_native_cond_initialize+0x0) [0x10a1055fb] ./thread_pthread.c:1047 /Users/ktsanaktsidis/Code/zendesk/ruby/ruby(register_cached_thread_and_wait) ./thread_pthread.c:1099 /Users/ktsanaktsidis/Code/zendesk/ruby/ruby(thread_start_func_1) ./thread_pthread.c:1054 /usr/lib/system/libsystem_pthread.dylib(_pthread_start+0xe0) [0x7fff208ef8fc] ``` (full output is attached). This seems to be because the new Ractor sets up stdio objects (`rb_io_prep_stdin` et. al.), which in turn allocate Ruby objects, before `rb_ec_initialize_vm_stack` is called to set up the initial stack frame. I've attached a patch which works around this by not firing GC event hooks if there is no control frame on the execution context. The patch also includes a test which reproduces the issue using the `objspace` extension; creating a Ractor within an `ObjectSpace.trace_object_allocations` block is enough to trigger the crash. The patch seems to fix things, but if you folk prefer I can also try swapping around the order of `prep_stdio` and `rb_ec_initialize_vm_stack`. ---Files-------------------------------- 0001-Fix-interpreter-crash-caused-by-RUBY_INTERNAL_EVENT_.patch (1.91 KB) crash.log (26.1 KB) ruby_2022-01-08-151326_8927-ktsanaktsidis.crash (18.8 KB) -- https://bugs.ruby-lang.org/

1 0

[ruby-core:113013] [Ruby master Bug#19115] RubyGems fails to detect OpenSSL in --with-static-linked-ext builds
by nagachika (Tomoyuki Chikanaga) 25 Mar '23

25 Mar '23

Issue #19115 has been updated by nagachika (Tomoyuki Chikanaga). Backport changed from 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: REQUIRED to 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: DONE ruby_3_1 5c5a1135b2e688eca7dbc7ce085f37a4d9fa3fd1 merged revision(s) 790cf4b6d0475614afb127b416e87cfa39044d67. ---------------------------------------- Bug #19115: RubyGems fails to detect OpenSSL in --with-static-linked-ext builds https://bugs.ruby-lang.org/issues/19115#change-102548 * Author: thomthom (Thomas Thomassen) * Status: Closed * Priority: Normal * ruby -v: 3.1.2, 3.2.0dev * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: DONE ---------------------------------------- Related discussion: https://bugs.ruby-lang.org/issues/18876 We are seeing OpenSSL failing to autoload with the Ruby build we've been using. (We first observed this when using `Gem.install` that relies on autoload of OpenSSL). Our last working build was Ruby 2.7.2 with similar config. This causes RubyGems' `HAVE_OPENSSL` constant to be incorrectly initialized, and subsequent calls to `Gem.install` fails. There might be other scenarios that fail as a result of that, but we've not managed to identified that. ``` module Gem HAVE_OPENSSL = defined? OpenSSL::SSL # :nodoc: ``` Our Ruby 3.1.2 config: ``` '--prefix=/Users/user/.conan/data/ruby/3.1.2/sketchup/stable/build/bd95825b99dcb274d0e577fbdc953653a9ea0fb9' '--with-openssl-dir=/Users/user/.conan/data/openssl/1.1.1q/sketchup/stable/package/93ae0b0e7eebe0611c04d3e0d9bbf49fbce92332' '--with-libyaml-dir=/Users/user/.conan/data/libyaml/0.2.5/sketchup/stable/package/a56a950abed2e10dbdc26845400f0a034d97c454' '--disable-install-doc' '--disable-install-rdoc' '--enable-shared' '--enable-load-relative' '--with-static-linked-ext' '--without-debug' '--without-gdbm' '--without-gettext' '--without-irb' '--without-mkmf' '--without-rdoc' '--without-readline' '--without-tk' '--bindir=${prefix}/bin' '--sbindir=${prefix}/bin' '--libexecdir=${prefix}/bin' '--libdir=${prefix}/lib' '--includedir=${prefix}/include' '--oldincludedir=${prefix}/include' '--datarootdir=${prefix}/share' 'cflags=-mmacosx-version-min=10.14 -fdeclspec' 'cxxflags=-mmacosx-version-min=10.14 -fdeclspec' 'LDFLAGS=-mmacosx-version-min=10.14 -fdeclspec' ``` We also tested with latest build from master (November 8th 2022): ``` ./ruby -ve 'p RbConfig::CONFIG["configure_args"]' ruby 3.2.0dev (2022-11-07T19:35:21Z master b14f133054) [x86_64-darwin20] " '--prefix=/Users/vmehta/ruby/ruby-master/' '--with-openssl-dir=/Users/vmehta/.conan/data/openssl/1.1.1q/sketchup/stable/package/f2d937af1fa19d5fc4095849a65d1927e9e75ae7/' '--with-libyaml-dir=/Users/vmehta/.conan/data/libyaml/0.2.5/sketchup/stable/package/3fc084e254210603a5c5aece184b2d45e2509b30' '--disable-install-doc' '--disable-install-rdoc' '--enable-shared' '--enable-load-relative' '--with-static-linked-ext' '--without-debug' '--without-gdbm' '--without-gettext' '--without-irb' '--without-mkmf' '--without-rdoc' '--without-readline' '--without-tk'" ``` Using an RVM of Ruby 3.1.2 this appear to work as expected. But using out configuration, that we've used for the Ruby 2.x versions are now failing. We haven't been able to figure out the reason for this. -- https://bugs.ruby-lang.org/

1 0

[ruby-core:113011] [Ruby master Bug#18827] `__ENCODING__` is not set to the source encoding when saving script lines
by nagachika (Tomoyuki Chikanaga) 25 Mar '23

25 Mar '23

Issue #18827 has been updated by nagachika (Tomoyuki Chikanaga). Backport changed from 2.7: REQUIRED, 3.0: REQUIRED, 3.1: REQUIRED to 2.7: REQUIRED, 3.0: REQUIRED, 3.1: DONE ruby_3_1 8c99882dad0b6fedbd656889829a3780366bd8b6 merged revision(s) cd5cafa4a380e2459862b6e99ff0c381362ef1be. ---------------------------------------- Bug #18827: `__ENCODING__` is not set to the source encoding when saving script lines https://bugs.ruby-lang.org/issues/18827#change-102545 * Author: nobu (Nobuyoshi Nakada) * Status: Closed * Priority: Normal * Assignee: nobu (Nobuyoshi Nakada) * Backport: 2.7: REQUIRED, 3.0: REQUIRED, 3.1: DONE ---------------------------------------- `__ENCODING__` should respect the encoding of the given source code. ```shell-session $ ruby -Ke -e 'p __ENCODING__' #<Encoding:EUC-JP> ``` ```ruby p eval("__ENCODING__".encode("euc-jp")) #=> #<Encoding:EUC-JP> ``` But it is ignored when `SCRIPT_LINES__` is set. ```shell-session $ cat script_lines.rb SCRIPT_LINES__ = {} $ ruby -r./script_lines.rb -Ke -e 'p __ENCODING__' #<Encoding:UTF-8> ``` Also similar when `keep_script_lines` is true. ```ruby pp RubyVM::AbstractSyntaxTree.parse("__ENCODING__".encode("euc-jp"), keep_script_lines: true) #=> (SCOPE@1:0-1:12 tbl: [] args: nil body: (LIT@1:0-1:12 #<Encoding:UTF-8>)) ``` -- https://bugs.ruby-lang.org/

1 0

[ruby-core:113010] [Ruby master Bug#18748] Range#cover? returns true for beginless range of different type
by nagachika (Tomoyuki Chikanaga) 25 Mar '23

25 Mar '23

Issue #18748 has been updated by nagachika (Tomoyuki Chikanaga). Backport changed from 2.7: REQUIRED, 3.0: REQUIRED, 3.1: REQUIRED to 2.7: REQUIRED, 3.0: REQUIRED, 3.1: DONE ruby_3_1 477ab3f6c7f14c79e13f694463aa06a59206dda1 merged revision(s) c5475f42694eff35465c3332e0182c0611ca5918. ---------------------------------------- Bug #18748: Range#cover? returns true for beginless range of different type https://bugs.ruby-lang.org/issues/18748#change-102544 * Author: jeremyevans0 (Jeremy Evans) * Status: Closed * Priority: Normal * Backport: 2.7: REQUIRED, 3.0: REQUIRED, 3.1: DONE ---------------------------------------- While adding documentation to address #18155, I found a bug: ```ruby (2..).cover?("2"..) # => false (..2).cover?(.."2") # => true ``` I've submitted a pull request for fix this: https://github.com/ruby/ruby/pull/5831 -- https://bugs.ruby-lang.org/

1 0

[ruby-core:113009] [Ruby master Bug#18989] Backport f229b36087f1b387d77af8f3fa50f9bffd2fd44e to ruby_3_1
by nagachika (Tomoyuki Chikanaga) 25 Mar '23

25 Mar '23

Issue #18989 has been updated by nagachika (Tomoyuki Chikanaga). Backport changed from 2.7: DONTNEED, 3.0: DONTNEED, 3.1: REQUIRED to 2.7: DONTNEED, 3.0: DONTNEED, 3.1: DONE ruby_3_1 02bee9d4d404b5134d19b16bc489c20459cce4ac merged revision(s) f229b36087f1b387d77af8f3fa50f9bffd2fd44e. ---------------------------------------- Bug #18989: Backport f229b36087f1b387d77af8f3fa50f9bffd2fd44e to ruby_3_1 https://bugs.ruby-lang.org/issues/18989#change-102543 * Author: nagachika (Tomoyuki Chikanaga) * Status: Closed * Priority: Normal * Assignee: nagachika (Tomoyuki Chikanaga) * Backport: 2.7: DONTNEED, 3.0: DONTNEED, 3.1: DONE ---------------------------------------- This is a ticket for backport management. f229b36087f1b387d77af8f3fa50f9bffd2fd44e should be backported into ruby_3_1. -- https://bugs.ruby-lang.org/

1 0

[ruby-core:111332] [Ruby master Bug#19242] Circular cause by Marshal
by nobu (Nobuyoshi Nakada) 25 Mar '23

25 Mar '23

Issue #19242 has been reported by nobu (Nobuyoshi Nakada). ---------------------------------------- Bug #19242: Circular cause by Marshal https://bugs.ruby-lang.org/issues/19242 * Author: nobu (Nobuyoshi Nakada) * Status: Open * Priority: Normal * Backport: 2.7: REQUIRED, 3.0: REQUIRED, 3.1: REQUIRED ---------------------------------------- Crafted marshaled data can creates an `Exception` object with circular `cause`. -- https://bugs.ruby-lang.org/

2 1

[ruby-core:111333] [Ruby master Bug#19243] Windows: Dir.home returns string in wrong encoding
by larskanis (Lars Kanis) 25 Mar '23

25 Mar '23

Issue #19243 has been reported by larskanis (Lars Kanis). ---------------------------------------- Bug #19243: Windows: Dir.home returns string in wrong encoding https://bugs.ruby-lang.org/issues/19243 * Author: larskanis (Lars Kanis) * Status: Open * Priority: Normal * ruby -v: ruby 3.1.3p185 (2022-11-24 revision 1a6b16756e) [x64-mingw-ucrt] * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN ---------------------------------------- Create a new local user on Windows called "kanisä". Then login to the new user and run in cmd: ``` C:\Users\kanisä>ruby -e "p Dir.home" "C:/Users/kanis\xE4" C:\Users\kanisä>ruby -e "p Dir.home.encoding" #<Encoding:UTF-8> C:\Users\kanisä>ruby -e "p Dir.home.encode('utf-8', 'iso-8859-15')" "C:/Users/kanisä" C:\Users\kanisä>echo %USERPROFILE% C:\Users\kanisä ``` `Dir.home` should encode the path in UTF-8. Instead the string is labeled as UTF-8 but bytes are encoded in `iso-8859-15`. All versions between ruby-3.0 and current master branch are affected. -- https://bugs.ruby-lang.org/

2 3

[ruby-core:113006] [Ruby master Bug#18779] `GC.compact` and other compaction related methods should be defined as rb_f_notimplement on non supported platforms.
by nagachika (Tomoyuki Chikanaga) 25 Mar '23

25 Mar '23

Issue #18779 has been updated by nagachika (Tomoyuki Chikanaga). MEMO: It seems that #18829 is required to be backported preceded for this issue. ---------------------------------------- Bug #18779: `GC.compact` and other compaction related methods should be defined as rb_f_notimplement on non supported platforms. https://bugs.ruby-lang.org/issues/18779#change-102540 * Author: byroot (Jean Boussier) * Status: Closed * Priority: Normal * Backport: 2.7: WONTFIX, 3.0: REQUIRED, 3.1: REQUIRED ---------------------------------------- I received several bug report on native gems using `GC.verify_compaction_references` in their test suite. Examples: - https://github.com/msgpack/msgpack-ruby/pull/275/files - https://github.com/Shopify/bootsnap/pull/414/files I think that when `!GC_COMPACTION_SUPPORTED`, rather than raise `NotImplementedError`, we should instead define these methods as `rb_f_notimplement` like `Process.fork` on Windows. This way `GC.respond_to?(:compact)` would be a proper way to test for compaction support. Unfortunately, these methods are defined through `.rb` files with `Primitive`, and I don't know wether it's possible to check `GC_COMPACTION_SUPPORTED` from there, nor if it's possible to define a `rb_f_notimplement` method. cc @tenderlovemaking -- https://bugs.ruby-lang.org/

1 0

[ruby-core:113004] [Ruby master Bug#18997] Don't define ruby_qsort when POSIX qsort_r is available
by nagachika (Tomoyuki Chikanaga) 25 Mar '23

25 Mar '23

Issue #18997 has been updated by nagachika (Tomoyuki Chikanaga). Backport changed from 2.7: REQUIRED, 3.0: REQUIRED, 3.1: REQUIRED to 2.7: REQUIRED, 3.0: REQUIRED, 3.1: DONTNEED I don't think this is necessary to backport to stable branches. ---------------------------------------- Bug #18997: Don't define ruby_qsort when POSIX qsort_r is available https://bugs.ruby-lang.org/issues/18997#change-102537 * Author: delphij (Xin Li) * Status: Closed * Priority: Normal * ruby -v: Not applicable * Backport: 2.7: REQUIRED, 3.0: REQUIRED, 3.1: DONTNEED ---------------------------------------- The current code would define ruby_qsort as a wrapper of qsort_s when it is available. When both qsort_s and POSIX (GNU) qsort_r are available, we should call qsort_r directly instead, and the qsort_s wrapper is redundant. Proposed patch at https://github.com/ruby/ruby/pull/6332 and can be applied on Ruby 2.7 and newer Ruby versions -- https://bugs.ruby-lang.org/

1 0

[ruby-core:111693] [Ruby master Bug#19316] YJIT crash in 3.2.0
by jdashton (J Daniel Ashton) 25 Mar '23

25 Mar '23

Issue #19316 has been reported by jdashton (J Daniel Ashton). ---------------------------------------- Bug #19316: YJIT crash in 3.2.0 https://bugs.ruby-lang.org/issues/19316 * Author: jdashton (J Daniel Ashton) * Status: Open * Priority: Normal * ruby -v: ruby 3.2.0 (2022-12-25 revision a528908271) +YJIT [x86_64-darwin22] * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- When I check out this commit from GitHub, https://github.com/jdashton/aoc2022-ruby/tree/5702dac483cd6e95f7be35bfebaf9… , and run the following command, `RUBYOPT="-v --yjit" bin/rspec spec/aoc2022/puzzles/unstable_diffusion_spec.rb`, Ruby crashes. Crash Report log file attached. ---Files-------------------------------- ruby-2023-01-06-091855.ips (21.6 KB) -- https://bugs.ruby-lang.org/

8 11