June 2023 - ruby-core - ml.ruby-lang.org

[ruby-core:112697] [Ruby master Bug#19479] Support IPv4-mapped IPv6 addresses in IPAddr#private?
by tgxworld (Guo Xiang Tan) 22 Jun '23

22 Jun '23

Issue #19479 has been reported by tgxworld (Guo Xiang Tan). ---------------------------------------- Bug #19479: Support IPv4-mapped IPv6 addresses in IPAddr#private? https://bugs.ruby-lang.org/issues/19479 * Author: tgxworld (Guo Xiang Tan) * Status: Open * Priority: Normal * ruby -v: ruby 3.2.1 (2023-02-08 revision 31819e82c8) [x86_64-linux] * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- ``` irb(main):010:0> IPAddr.new("172.16.0.0").private? => true irb(main):011:0> IPAddr.new("::ffff:172.16.0.0").private? => false ``` If IPAddr#private? is used in a critical code path, not supporting IPv4-mapped IPv6 addresses could lead to security issues. -- https://bugs.ruby-lang.org/

2 1

[ruby-core:113083] [Ruby master Bug#19569] #map on Enumerator::Lazy block arguments differ from regular #map
by TomNaessens (Tom Naessens) 21 Jun '23

21 Jun '23

Issue #19569 has been reported by TomNaessens (Tom Naessens). ---------------------------------------- Bug #19569: #map on Enumerator::Lazy block arguments differ from regular #map https://bugs.ruby-lang.org/issues/19569 * Author: TomNaessens (Tom Naessens) * Status: Open * Priority: Normal * ruby -v: 3.0.5...3.2.0 * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- A Ruby 2 to 3 upgrade surfaced the following issue: Ruby 2: ``` irb(main):252:0> [1, 2, 3].to_enum.lazy.zip([:a, :b, :c]).map(&:last).to_a => [:a, :b, :c] ``` Ruby 3: ``` irb(main):020:0> [1, 2, 3].to_enum.lazy.zip([:a, :b, :c]).map(&:last).to_a (irb):20:in `each': undefined method `last' for 1:Integer (NoMethodError) ``` Debugging the issue, I noticed the following: Map with a block returns only the first argument (and seems to ignore the zipped list): ``` irb(main):024:0> [1, 2, 3].to_enum.lazy.zip([:a, :b, :c]).map { |x| x }.to_a => [1, 2, 3] ``` It's not actually ignored though, it's just passed as a second argument: ``` irb(main):025:0> [1, 2, 3].to_enum.lazy.zip([:a, :b, :c]).map { |*x| x }.to_a => [[1, :a], [2, :b], [3, :c]] ``` Thus, this looks like a workaround: ``` irb(main):026:0> [1, 2, 3].to_enum.lazy.zip([:a, :b, :c]).map { |*x| x.last }.to_a => [:a, :b, :c] ``` But it behaves differently when leaving the `lazy` out: ``` irb(main):027:0> [1, 2, 3].to_enum.zip([:a, :b, :c]).map { |*x| x.last }.to_a => [[1, :a], [2, :b], [3, :c]] ``` Not sure if I'm correct in my conclusion, but to me it looks like the argument handling of `map` and `lazy_map` differs in an unexpected manner. Is this a bug/oversight, or I am simply using the different map implementations wrong? -- https://bugs.ruby-lang.org/

2 1

[ruby-core:113958] [Ruby master Feature#19741] Mirror YARP to Ruby
by kddnewton (Kevin Newton) 21 Jun '23

21 Jun '23

Issue #19741 has been reported by kddnewton (Kevin Newton). ---------------------------------------- Feature #19741: Mirror YARP to Ruby https://bugs.ruby-lang.org/issues/19741 * Author: kddnewton (Kevin Newton) * Status: Open * Priority: Normal ---------------------------------------- At the [May Ruby Kaigi Dev Meeting](https://github.com/ruby/dev-meeting-log/blob/master/2023/DevMeetin…, Matz approved mirroring YARP into ruby/ruby. @jemmai and I are creating this redmine issue to log this work and link to the pull request. [Here](https://github.com/ruby/ruby/pull/7964) is the pull request that mirrors YARP into CRuby. We want to specifically also thank Adam Hess and Haldun Bayhantopcu for their contributions to YARP in getting us to this point. -- https://bugs.ruby-lang.org/

1 0

[ruby-core:113238] [Ruby master Misc#19599] DevMeeting-2023-05-10
by mame (Yusuke Endoh) 20 Jun '23

20 Jun '23

Issue #19599 has been reported by mame (Yusuke Endoh). ---------------------------------------- Misc #19599: DevMeeting-2023-05-10 https://bugs.ruby-lang.org/issues/19599 * Author: mame (Yusuke Endoh) * Status: Open * Priority: Normal ---------------------------------------- # The next dev meeting **Date: 2023/05/10 13:00-17:00** (JST) Log: *TBD* - Dev meeting *IS NOT* a decision-making place. All decisions should be done at the bug tracker. - Dev meeting is a place we can ask Matz, nobu, nurse and other developers directly. - Matz is a very busy person. Take this opportunity to ask him. If you can not attend, other attendees can ask instead of you (if attendees can understand your issue). - We will write a record of the discussion in the file or to each ticket in English. - All activities are best-effort (keep in mind that most of us are volunteer developers). - The date, time and place of the meeting are scheduled according to when/where we can reserve Matz's time. - *DO NOT* discuss then on this ticket, please. # Call for agenda items If you have a ticket that you want matz and committers to discuss, please post it into this ticket in the following format: ``` * [Ticket ref] Ticket title (your name) * Comment (A summary of the ticket, why you put this ticket here, what point should be discussed, etc.) ``` Example: ``` * [Feature #14609] `Kernel#p` without args shows the receiver (ko1) * I feel this feature is very useful and some people say :+1: so let discuss this feature. ``` - It is recommended to add a comment by 2023/05/07. We hold a preparatory meeting to create an agenda a few days before the dev-meeting. - The format is strict. We'll use [this script to automatically create an markdown-style agenda](https://gist.github.com/mame/b0390509ce1491b43610b9ebb665eb86). We may ignore a comment that does not follow the format. - Your comment is mandatory. We cannot read all discussion of the ticket in a limited time. We appreciate it if you could write a short summary and update from a previous discussion. -- https://bugs.ruby-lang.org/

14 13

[ruby-core:113938] [Ruby master Bug#19736] Ripper.tokenize ignores token after heredoc_beg when embexpr inside heredoc is unclosed
by tompng (tomoya ishida) 19 Jun '23

19 Jun '23

Issue #19736 has been reported by tompng (tomoya ishida). ---------------------------------------- Bug #19736: Ripper.tokenize ignores token after heredoc_beg when embexpr inside heredoc is unclosed https://bugs.ruby-lang.org/issues/19736 * Author: tompng (tomoya ishida) * Status: Open * Priority: Normal * ruby -v: ruby 3.3.0dev (2023-06-19T09:28:10Z master 2a80bac9f0) [x86_64-linux] * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- I expect Ripper.tokenize(code) to tokenize `+1+2+3\n` part. ```ruby code = <<'RUBY' <<A+1+2+3 #{4 RUBY Ripper.tokenize code # => ["<<A", "\#{", "4", "\n"] ``` It will be easy for IRB's internal code to handle indent and other things if Ripper.tokenize can tokenize all part of the code even if it is incomplete. -- https://bugs.ruby-lang.org/

1 0

[ruby-core:113937] Re: ruby/ruby Cirrus CI improvement
by Jun Aruga (he / him) 18 Jun '23

18 Jun '23

Hi Fedor, Okay. Thanks for the info, and for sharing the issue ticket below. https://github.com/cirruslabs/cirrus-ci-docs/issues/1177 Jun On Thu, Jun 15, 2023 at 8:39 PM Fedor Korotkov <fedor(a)cirruslabs.org> wrote: > Yes, we had some issues with the migration but everything should be > working now even better than before. Please check this > <https://github.com/cirruslabs/cirrus-ci-docs/issues/1177#issuecomment-15935…> > comment for details. > > On Thu, Jun 15, 2023 at 10:13 AM Jun Aruga (he / him) <jaruga(a)redhat.com> > wrote: > >> Hi Febor, >> >> Thank you for your help and investigation! It seems your email was not >> sent to the ruby-core(a)ruby-lang.org mailing list, as the setting of the >> mailing list only accepts the email from a subscribed person. So, I reply >> with your email message. >> >> > ... Right now it only uses 1 core: >> >> This can be improved in our Cirrus CI configuration file. >> >> > On a side, within the next week or two we are planning to migrate from >> Graviton 2 CPUs to more performant offering of Ampere CPUs on Google Cloud. >> >> I see. We observed the following Cirrus CI didn't start even after 1 >> hour. Do you know the reason? >> https://cirrus-ci.com/build/5470471567704064 >> >> I hope that this will be improved after the migration. >> >> Jun Aruga >> >> On Mon, Jun 12, 2023 at 3:33 PM Fedor Korotkov <fedor(a)cirruslabs.org> >> wrote: >> >>> Hey Jun, >>> >>> I was just writing a response when you followed up. :-) >>> >>> As far as the configuration, we don't see anything suspicious in it. The >>> only thing that might be improved is making compilation utilize all the >>> cores. Right now it only uses 1 core: >>> >>> [image: Screenshot 2023-06-12 at 9.24.09 AM.png] >>> >>> As for the clang performance, we don't have any insights. From the >>> graphs it just seems to be working slower than your gcc variant. >>> >>> On a side, within the next week or two we are planning to migrate from >>> Graviton 2 CPUs to more performant offering of Ampere CPUs on Google Cloud. >>> >>> On Mon, Jun 12, 2023 at 9:22 AM Jun Aruga (he / him) <jaruga(a)redhat.com> >>> wrote: >>> >>>> Dear Cirrus CI customer support, >>>> >>>> Thank you for helping us (Ruby project)! >>>> Could you check the following message about the issue in Cirrus CI in >>>> the Ruby project? >>>> >>>> I noticed sending an email to the customer support email is better >>>> than sending an email to a person's email. So, I am sending the >>>> message to the support email again. >>>> Long story short, we see Cirrus CI is unstable in our cases (running 4 >>>> cases in Arm), and we want your advice for our .cirrus.yml file to >>>> fill our needs. >>>> >>>> https://cirrus-ci.org/support/ >>>> > The best way to ask general questions about particular use cases is >>>> to email our support team at support+ci(a)cirruslabs.org. Our support >>>> team is trying our best to respond ASAP, but there is no guarantee on a >>>> response time unless your organization enrolls in Priority Support. >>>> >>>> Kind regards, >>>> Jun >>>> >>>> On Fri, Jun 9, 2023 at 12:57 PM Jun Aruga (he / him) <jaruga(a)redhat.com> >>>> wrote: >>>> > >>>> > Hello Fedor @ Cirrus CI, >>>> > CC: Ruby Core mailing list. >>>> > >>>> > Thank you for helping the Ruby project for adding Cirrus CI. I am >>>> > sending an email to ask you for help to improve the Cirrus CI. We are >>>> > running 4 parallel jobs (2 gcc cases ARM, 2 clang cases ARM) in the >>>> > Cirrus CI. >>>> > However, I am seeing some challenges such as the queue is stopping, >>>> > and the clang cases are 2 or 3 times slower than gcc cases. So, today >>>> > we stopped the 2 clang cases in a compromised way. >>>> > >>>> > Could you check our .cirrus.yml file on the reverted commit, and give >>>> > advice to us and ideally just send a pull-request to the master branch >>>> > for that? >>>> > >>>> > https://github.com/ruby/ruby/blob/master/.cirrus.yml >>>> > >>>> > ``` >>>> > $ git clone https://github.com/ruby/ruby.git >>>> > $ cd ruby >>>> > $ git revert 72f07f0a5f882e87e305d668587152fa209a0568. >>>> > ``` >>>> > >>>> > I suspect the current `cpu:` value might not be correct. And we may >>>> > need the following change. >>>> > >>>> > ``` >>>> > diff --git a/.cirrus.yml b/.cirrus.yml >>>> > index be76e4ab4a..8b820be1a2 100644 >>>> > --- a/.cirrus.yml >>>> > +++ b/.cirrus.yml >>>> > @@ -16,10 +16,10 @@ task: >>>> > image: ghcr.io/ruby/ruby-ci-image:$CC >>>> > # Define the used cpu core in each matrix task. We can use total >>>> 16 cpu >>>> > # cores in entire matrix. [cpu] = [total cpu: 16] / [number of >>>> tasks] >>>> > - cpu: 8 >>>> > + cpu: 4 >>>> > # We can request maximum 4 GB per cpu. >>>> > # [memory per task] = [memory per cpu: 4 GB] * [cpu] >>>> > - memory: 32G >>>> > + memory: 16G >>>> > env: >>>> > CIRRUS_CLONE_DEPTH: 50 >>>> > optflags: '-O1' >>>> > @@ -71,10 +71,10 @@ yjit_task: >>>> > image: ghcr.io/ruby/ruby-ci-image:$CC >>>> > # Define the used cpu core in each matrix task. We can use total >>>> 16 cpu >>>> > # cores in entire matrix. [cpu] = [total cpu: 16] / [number of >>>> tasks] >>>> > - cpu: 8 >>>> > + cpu: 4 >>>> > # We can request maximum 4 GB per cpu. >>>> > # [memory per task] = [memory per cpu: 4 GB] * [cpu] >>>> > - memory: 32G >>>> > + memory: 16G >>>> > env: >>>> > CIRRUS_CLONE_DEPTH: 50 >>>> > optflags: '-O1' >>>> > ``` >>>> > >>>> > Thank you for your help! >>>> > >>>> > -- >>>> > Jun | He - Him | Timezone: UTC+1 or 2, Czech Republic >>>> > See <https://www.worldtimebuddy.com/czech-republic-prague-to-utc> for >>>> > the timezone. >>>> >>>> -- >>>> Jun | He - Him | Timezone: UTC+1 or 2, Czech Republic >>>> See <https://www.worldtimebuddy.com/czech-republic-prague-to-utc> for >>>> the timezone. >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Support" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to support+unsubscribe(a)cirruslabs.org. >>>> To view this discussion on the web visit >>>> https://groups.google.com/a/cirruslabs.org/d/msgid/support/CAHE_3CiT_59xrbU… >>>> . >>>> >>> >>> >>> -- >>> >>> Fedor Korotkov >>> >>> Founder at *Cirrus Labs* >>> >>> @fedor <https://twitter.com/fedor> >>> >> >> >> -- >> Jun | He - Him | Timezone: UTC+1 or 2, Czech Republic >> See <https://www.worldtimebuddy.com/czech-republic-prague-to-utc> for >> the timezone. >> > > > -- > > Fedor Korotkov > > Founder at *Cirrus Labs* > > @fedor <https://twitter.com/fedor> > -- Jun | He - Him | Timezone: UTC+1 or 2, Czech Republic See <https://www.worldtimebuddy.com/czech-republic-prague-to-utc> for the timezone.

1 0

[ruby-core:113931] [Ruby master Bug#18686] Regexp supporting unexpected age properties in Ruby < 3.2
by janosch-x 18 Jun '23

18 Jun '23

Issue #18686 has been updated by janosch-x (Janosch Müller). this no longer occurs in ruby 3.2 or 3.3 so IMO this bug can be closed @duerst @jeremyevans0 ```ruby RUBY_DESCRIPTION # => "ruby 3.3.0preview1 (2023-05-12 master a1b01e7701) [arm64-darwin22]" [*0..1000].product([*0..100]).each_with_object([]) do |(n1, n2), acc| n = "#{n1}.#{n2}" acc << n if (/\p{age=#{n}}/ rescue nil) end # => ["1.1", "2.0", "2.1", "3.0", "3.1", "3.2", "4.0", "4.1", "5.0", "5.1", "5.2", "6.0", "6.1", "6.2", "6.3", "7.0", "8.0", "9.0", "10.0", "11.0", "12.0", "12.1", "13.0", "14.0", "15.0"] ---------------------------------------- Bug #18686: Regexp supporting unexpected age properties in Ruby < 3.2 https://bugs.ruby-lang.org/issues/18686#change-103586 * Author: janosch-x (Janosch Müller) * Status: Open * Priority: Normal * Backport: 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN ---------------------------------------- I've encountered this on GitHub Actions running Ubuntu 20. I cannot reproduce it locally on Darwin/arm64. It is a weird bug and far from critical, but it might indicate some underlying problem. I've found that ... - all Ruby versions below 3.1 allow `/\p{age=14.0}/` - this is unexpected because age 14 was only added in Ruby 3.2 - Ruby seems to parse this as `age=10.0`, at least it matches exactly these codepoints - all Ruby versions below 3.2 allow *some* unexpected values for age - allowed values are e.g. `age=21.0`, `age=41.0`, `age=99.0` (depending on Ruby version) - on Ruby 3.1, `age=99.0` matches exactly the same codepoints as `age=11.0` - ruby-head doesn't seem to allow unexpected age values (i've only tested values ending in `.0`) I've set up a minimal reproduction here: https://github.com/jaynetics/ruby_age_property_bug_repro with the unexpected results visible here: https://github.com/jaynetics/ruby_age_property_bug_repro/actions/runs/21155… and here: https://github.com/jaynetics/ruby_age_property_bug_repro/actions/runs/21167… CC @duerst -- https://bugs.ruby-lang.org/

1 0

[ruby-core:113925] [Ruby master Feature#19734] Let `File` be a subclass of `Dir`
by sawa (Tsuyoshi Sawada) 18 Jun '23

18 Jun '23

Issue #19734 has been reported by sawa (Tsuyoshi Sawada). ---------------------------------------- Feature #19734: Let `File` be a subclass of `Dir` https://bugs.ruby-lang.org/issues/19734 * Author: sawa (Tsuyoshi Sawada) * Status: Open * Priority: Normal ---------------------------------------- I propose to let `File` class be a subclass of `Dir` class. Motivations are as follows. When we want to do something with a file (for example `File.read` or `File.write`), we quite often want to achieve the home directory. If we are in the mode of thinking in the ream of `File`, we would likely come up with `File.expand_path("~")`. However, this is cumbersome, and actually, `Dir.home` is simpler. But my experience is that switching the mind to `Dir` when thinking about `File` require extra cognitive load. Also, many methods defined in `File` work for both a file or a directory. When we are doing something with a directory, we have to stop and think whether the method we want to use is defined in `File` or in `Dir`. It is possible to do that, but that also requires extra cognitive load. I thought things would become simpler if we do not need to switch between these two classes in mind, and keep using `File`. There are a few singleton methods that are defined on both `File` and `Dir`: ``` delete/unlink, empty?, exist?, new/open ``` but I think there would be no problem in choosing the appropriate class depending on the need. Semantically, maybe it makes more sense to let `Dir` be a subclass of `File` because directories are special cases of files. However, in Ruby, `File` and `Dir` have ancestors ``` File < IO < Enumerable < File::Constants < Object < ... Dir < Enumerable < Object < ... ``` respectively, and `File` inherits `IO` and `File::Constants`, beside their common ancestors, so I though that letting `File` be a subclass of `Dir` would be more practical. -- https://bugs.ruby-lang.org/

2 1

[ruby-core:113715] [Ruby master Bug#19701] The rb_classext_t::classpath field is not marked for T_ICLASS
by wks (Kunshan Wang) 18 Jun '23

18 Jun '23

Issue #19701 has been reported by wks (Kunshan Wang). ---------------------------------------- Bug #19701: The rb_classext_t::classpath field is not marked for T_ICLASS https://bugs.ruby-lang.org/issues/19701 * Author: wks (Kunshan Wang) * Status: Open * Priority: Normal * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- I am hacking Ruby to dump information about some objects, and I found that the `rb_classext_t::classpath` field for `T_ICLASS` objects sometimes contains dangling references to dead objects. The commit https://github.com/ruby/ruby/commit/081cc4eb283cb01ddffb364397e5175dbfacab66 set the `classpath` field of `rb_mRubyVMFrozenCore` to a string "FrozenCore" so that it can be dumped using the `rb_dump_literal` function. However, in `gc_mark_children`, if the `obj` is a `T_ICLASS`, the `RCLASS_EXT(obj)->classpath` will not be marked. As a result, if `rb_mRubyVMFrozenCore` is the only object that holds a reference to the string "FrozenCore", the string will be considered garbage and reclaimed during a GC, and the `classpath` will contain a dangling pointer. There are two solutions to this problem. We can take *one* of the approaches below (not both). 1. Let the GC mark the `classpath` field. I drafted a pull request here: https://github.com/ruby/ruby/pull/7875 2. Revert the commit https://github.com/ruby/ruby/commit/081cc4eb283cb01ddffb364397e5175dbfacab66 Marking the `classpath` field in GC will keep the `rb_dump_literal` function working. For debug purposes, we can also use that field to identify what object a given `T_ICLASS` is. Adding one marked field may make GC slower, but I don't think it will be observable because there are far less `T_ICLASS` objects than ordinary objects. If we reverting the commit above, the `classpath` will always be blank for all `T_ICLASS` objects. (Question: How do we enforce it?) It will also save some memory by keeping less strings alive. However, currently, "FrozenCore" seems to be the only `T_OBJECT` that has its classpath set, and it may not result in significant memory saving. I don't know what purpose the `rb_dump_literal` function originally served. Maybe it is still important. Maybe it is safe to remove now. Which of the two approaches should we take? It looks like each of them has its pros and cons. -- https://bugs.ruby-lang.org/

4 3

[ruby-core:113924] [Ruby master Feature#16833] Add Enumerator#empty?
by ioquatix (Samuel Williams) 17 Jun '23

17 Jun '23

Issue #16833 has been updated by ioquatix (Samuel Williams). Assignee set to ioquatix (Samuel Williams) ---------------------------------------- Feature #16833: Add Enumerator#empty? https://bugs.ruby-lang.org/issues/16833#change-103577 * Author: f3ndot (Justin Bull) * Status: Open * Priority: Normal * Assignee: ioquatix (Samuel Williams) ---------------------------------------- It was surprising to me that Enumerator, something mixed into Array, does not include `#empty?`. I think it is reasonable to assume people may have to guard iterating and other logic based on the emptiness of an enumerator, such was my case. ``` ruby # pretend there's convoluted enumerator logic to produce this structure table_rows = [{ data: ['First', 'Second', 'Third'], config: {} }, { data: [4, 5, 6], config: { color: 'red' } }].to_enum return if table_rows.empty? table_header = table_rows.first[:data] # requires an empty guard # ... ``` I propose that it simply behaves as `#take(1).to_a.empty?` instead of aliasing to something like `#none?` because of falsey elements or `#size == 0` because of potential `nil` returns: ```ruby [].to_enum.empty? # => true [false].to_enum.empty? # => false [nil].to_enum.empty? # => false [0].to_enum.empty? # => false [1, 2, 3].to_enum.empty? # => false ``` ---Files-------------------------------- add-enumerable-empty.patch (1.99 KB) -- https://bugs.ruby-lang.org/

1 0