September 2023 - ruby-core - ml.ruby-lang.org

[ruby-core:114773] [Ruby master Misc#19883] DevMeeting-2023-10-12
by mame (Yusuke Endoh) 11 Oct '23

11 Oct '23

Issue #19883 has been reported by mame (Yusuke Endoh). ---------------------------------------- Misc #19883: DevMeeting-2023-10-12 https://bugs.ruby-lang.org/issues/19883 * Author: mame (Yusuke Endoh) * Status: Open * Priority: Normal ---------------------------------------- # The next dev meeting **Date: 2023/10/12 13:00-17:00** (JST) Log: *TBD* - Dev meeting *IS NOT* a decision-making place. All decisions should be done at the bug tracker. - Dev meeting is a place we can ask Matz, nobu, nurse and other developers directly. - Matz is a very busy person. Take this opportunity to ask him. If you can not attend, other attendees can ask instead of you (if attendees can understand your issue). - We will write a record of the discussion in the file or to each ticket in English. - All activities are best-effort (keep in mind that most of us are volunteer developers). - The date, time and place of the meeting are scheduled according to when/where we can reserve Matz's time. - *DO NOT* discuss then on this ticket, please. # Call for agenda items If you have a ticket that you want matz and committers to discuss, please post it into this ticket in the following format: ``` * [Ticket ref] Ticket title (your name) * Comment (A summary of the ticket, why you put this ticket here, what point should be discussed, etc.) ``` Example: ``` * [Feature #14609] `Kernel#p` without args shows the receiver (ko1) * I feel this feature is very useful and some people say :+1: so let discuss this feature. ``` - It is recommended to add a comment by 2023/10/09. We hold a preparatory meeting to create an agenda a few days before the dev-meeting. - The format is strict. We'll use [this script to automatically create an markdown-style agenda](https://gist.github.com/mame/b0390509ce1491b43610b9ebb665eb86). We may ignore a comment that does not follow the format. - Your comment is mandatory. We cannot read all discussion of the ticket in a limited time. We appreciate it if you could write a short summary and update from a previous discussion. -- https://bugs.ruby-lang.org/

6 5

[ruby-core:114774] [Ruby master Feature#19884] Make Safe Navigation Operator work on classes
by p8 (Petrik de Heus) 10 Oct '23

10 Oct '23

Issue #19884 has been reported by p8 (Petrik de Heus). ---------------------------------------- Feature #19884: Make Safe Navigation Operator work on classes https://bugs.ruby-lang.org/issues/19884 * Author: p8 (Petrik de Heus) * Status: Open * Priority: Normal ---------------------------------------- If a class might not be defined we need to add a conditional: ```ruby defined?(ActiveRecord::Base) && ActiveRecord::Base.some_method ``` It would be nice if we could use the Safe Navigation Operator instead. ```ruby ActiveRecord::Base&.some_method ``` -- https://bugs.ruby-lang.org/

7 12

[ruby-core:114734] [Ruby master Bug#19880] Missing write barrier in iseq instruction list
by peterzhu2118 (Peter Zhu) 10 Oct '23

10 Oct '23

Issue #19880 has been reported by peterzhu2118 (Peter Zhu). ---------------------------------------- Bug #19880: Missing write barrier in iseq instruction list https://bugs.ruby-lang.org/issues/19880 * Author: peterzhu2118 (Peter Zhu) * Status: Open * Priority: Normal * Backport: 3.0: UNKNOWN, 3.1: REQUIRED, 3.2: REQUIRED ---------------------------------------- There's a missing write barrier for operands in the iseq instruction list, which can cause crashes. This bug has been fixed in commit [b3b57f7](https://github.com/ruby/ruby/commit/b3b57f70cc1ee6f40ff10b2abaa518…. It can be reproduced when Ruby is compiled with `-DRUBY_DEBUG_ENV=1`. Using the following command: ``` RUBY_GC_HEAP_OLDOBJECT_LIMIT_FACTOR=0 RUBY_DEBUG=gc_stress ruby -w --disable=gems -Itool/lib -W0 test.rb ``` The following script crashes: ```ruby require "test/unit" ``` I have backports for Ruby 3.1 and Ruby 3.2 available here: 3.1: https://github.com/ruby/ruby/pull/8430 3.2: https://github.com/ruby/ruby/pull/8431 -- https://bugs.ruby-lang.org/

3 2

[ruby-core:114574] [Ruby master Bug#19855] Array#bsearch gets wrong result when its block returns a non-integer numeric value.
by kyanagi (Kouhei Yanagita) 10 Oct '23

10 Oct '23

Issue #19855 has been reported by kyanagi (Kouhei Yanagita). ---------------------------------------- Bug #19855: Array#bsearch gets wrong result when its block returns a non-integer numeric value. https://bugs.ruby-lang.org/issues/19855 * Author: kyanagi (Kouhei Yanagita) * Status: Open * Priority: Normal * ruby -v: ruby 3.3.0dev (2023-08-29T04:52:18Z master c0e913ae88) [arm64-darwin22] * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- Array#bsearch gets wrong result when its block returns a non-integer numeric value. ``` % ruby -e 'p [0, 4, 7, 10, 12].bsearch { |x| (4 - x) }' 4 % ruby -e 'p [0, 4, 7, 10, 12].bsearch { |x| (4 - x).to_r }' nil ``` fix: https://github.com/ruby/ruby/pull/8314 -- https://bugs.ruby-lang.org/

3 3

[ruby-core:114822] [Ruby master Bug#19893] OpenStruct#respond_to? when true fails with NameError
by msxavi (Emerson Xavier) 04 Oct '23

04 Oct '23

Issue #19893 has been reported by msxavi (Emerson Xavier). ---------------------------------------- Bug #19893: OpenStruct#respond_to? when true fails with NameError https://bugs.ruby-lang.org/issues/19893 * Author: msxavi (Emerson Xavier) * Status: Open * Priority: Normal * ruby -v: 3.1.4 * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- Hello, I have a case where I overrode respond_to? on a subclass of OpenStruct because I this class to work as fake object. ``` class Dep def a "Hello from Dep" end end class FakeDep < OpenStruct def respond_to?(*args) super || Dep.new.respond_to?(*args) end end FakeDep.new(a: []) NameError: undefined method `a' for class `FakeDep' owner = method!(name).owner ^^^^^^^ from /usr/local/lib/ruby/3.1.0/ostruct.rb:245:in `method' ``` Is this a valid issue? Also posted in https://github.com/ruby/ostruct/issues/55 -- https://bugs.ruby-lang.org/

2 2

[ruby-core:114925] [Ruby master Bug#19906] fix kwarg memory leak
by HParker (Adam Hess) 01 Oct '23

01 Oct '23

Issue #19906 has been reported by HParker (Adam Hess). ---------------------------------------- Bug #19906: fix kwarg memory leak https://bugs.ruby-lang.org/issues/19906 * Author: HParker (Adam Hess) * Status: Open * Priority: Normal * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- GitHub PR: https://github.com/ruby/ruby/pull/8556 ci info tracks kwargs and which are shared across aliases ```ruby 30.times do 100_000.times do def foo(k:); yield; end alias bar foo undef foo end puts `ps -o rss= -p #{$$}` end ``` before: ``` 30364 45120 59700 73932 88512 102680 116884 130884 145308 159688 174468 188680 203016 216908 231568 246096 260592 274900 289168 303420 317620 331956 346148 360708 374880 389172 403472 417824 432016 446040 460196 474604 489152 503248 517504 531944 546228 560520 574760 589108 ``` after: ``` 8760 8940 9156 9540 9548 9548 9548 9548 9548 9548 9548 9548 9548 9548 9548 9548 9548 9548 9548 9548 9556 9564 9564 9564 9564 9564 9564 9564 9564 9564 9564 9564 9564 9576 9744 9744 9744 9744 9744 9936 ``` -- https://bugs.ruby-lang.org/

2 2

[ruby-core:114475] [Ruby master Bug#19845] `Fiber[key] = value` fails if key is not interned.
by ioquatix (Samuel Williams) 30 Sep '23

30 Sep '23

Issue #19845 has been reported by ioquatix (Samuel Williams). ---------------------------------------- Bug #19845: `Fiber[key] = value` fails if key is not interned. https://bugs.ruby-lang.org/issues/19845 * Author: ioquatix (Samuel Williams) * Status: Open * Priority: Normal * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- See https://github.com/ruby/ruby/pull/8273 for the fix. -- https://bugs.ruby-lang.org/

2 2

[ruby-core:114847] [Ruby master Bug#19896] Ruby method refinement memory leak
by HParker (Adam Hess) 30 Sep '23

30 Sep '23

Issue #19896 has been reported by HParker (Adam Hess). ---------------------------------------- Bug #19896: Ruby method refinement memory leak https://bugs.ruby-lang.org/issues/19896 * Author: HParker (Adam Hess) * Status: Open * Priority: Normal * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- GitHub pull request: https://github.com/ruby/ruby/pull/8487 When method redefinitions happen, sometimes the final definition does not get cleaned up, Reproducable with the same script from: https://bugs.ruby-lang.org/issues/19894 ``` ruby 10.times do 20_000.times do $c = Class.new do def foo; end end $m = Module.new do refine $c do def foo; end end end Class.new do using $m def initialize o = $c.new o.method(:foo).unbind end end.new end puts `ps -o rss= -p #{$$}` end ``` before: ``` 19792 20944 22224 23504 24784 26064 27344 28624 29776 31056 ``` after: ``` 18560 18560 18560 18560 18560 18560 18560 18560 18560 18560 ``` -- https://bugs.ruby-lang.org/

2 1

[ruby-core:114889] [Ruby master Bug#19901] Module clone memory leak
by HParker (Adam Hess) 30 Sep '23

30 Sep '23

Issue #19901 has been reported by HParker (Adam Hess). ---------------------------------------- Bug #19901: Module clone memory leak https://bugs.ruby-lang.org/issues/19901 * Author: HParker (Adam Hess) * Status: Open * Priority: Normal * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- GitHub PR: https://github.com/ruby/ruby/pull/8503 reproduction: ```ruby m = Module.new 20.times do 100_000.times do m.clone end puts `ps -o rss= -p #{$$}` end ``` before: ``` 21544 24708 27860 31024 33928 37360 40264 43432 46600 49768 52936 55840 59008 62176 65344 68512 71680 74584 77752 80920 ``` after: ``` 18808 18808 18872 18872 18872 18872 18872 18872 18872 18872 18872 18872 18872 18872 18872 18872 18872 18872 18872 18872 ``` -- https://bugs.ruby-lang.org/

2 1

[ruby-core:114897] [Ruby master Bug#19903] Fix memory leak in generating and loading iseq
by HParker (Adam Hess) 30 Sep '23

30 Sep '23

Issue #19903 has been reported by HParker (Adam Hess). ---------------------------------------- Bug #19903: Fix memory leak in generating and loading iseq https://bugs.ruby-lang.org/issues/19903 * Author: HParker (Adam Hess) * Status: Open * Priority: Normal * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- PR: https://github.com/ruby/ruby/pull/8512 Reproduction: ```ruby 10.times do 100_000.times do RubyVM::InstructionSequence.load_from_binary(RubyVM::InstructionSequence.compile("def foo(bar:); end; foo(bar: :baz)").to_binary) end puts `ps -o rss= -p #{$$}` end ``` before: ``` 39636 60756 82140 103260 124380 145764 166884 188004 209388 230508 ``` after: ``` 25184 31784 38648 45248 51848 58712 65312 71912 78776 85376 ``` -- https://bugs.ruby-lang.org/

2 1