February 2024 - ruby-core - ml.ruby-lang.org

[ruby-core:115911] [Ruby master Bug#20089] Fiber#kill transfers to root fiber
by rmosolgo (Robert Mosolgo) 17 Apr '24

17 Apr '24

Issue #20089 has been reported by rmosolgo (Robert Mosolgo). ---------------------------------------- Bug #20089: Fiber#kill transfers to root fiber https://bugs.ruby-lang.org/issues/20089 * Author: rmosolgo (Robert Mosolgo) * Status: Open * Priority: Normal * ruby -v: ruby 3.3.0 (2023-12-25 revision 5124f9ac75) [x86_64-darwin22] * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- I was hoping to use `Fiber#kill` to clean up formerly `.transfer`-d Fibers and work around https://bugs.ruby-lang.org/issues/20081, but I found that `Fiber#kill` has a similar control flow jump behavior. Is this on purpose, or a bug? Here's a script to test the behavior: ```ruby manager = Fiber.new do worker = Fiber.new do puts "2. Begin Worker" manager.transfer puts "This should never print -- killed" end puts "1. Transfer to Worker" worker.transfer puts "3. Killing Worker" worker.kill puts "4. Finished manager" end manager.transfer puts "5. Finished script" ``` I expected items `1` through `5` to be printed in order, but in fact, `4` is never printed: ``` $ ruby fiber_transfer_test.rb 1. Transfer to Worker 2. Begin Worker 3. Killing Worker 5. Finished script ``` It seems like `worker.kill` is transferring control to the top-level fiber instead of giving it back to `manager`. I also tried having the thread kill _itself_, hoping it would return to the fiber that originally `.transfer`ed to it, but it also seems to jump out: ```ruby manager = Fiber.new do worker = Fiber.new do puts "2. Begin Worker" manager.transfer Fiber.current.kill puts "This should never print -- killed" end puts "1. Transfer to Worker" worker.transfer puts "3. Killing Worker" worker.transfer puts "4. Finished manager" end manager.transfer puts "5. Finished script" ``` Prints: ``` 1. Transfer to Worker 2. Begin Worker 3. Killing Worker 5. Finished script ``` -- https://bugs.ruby-lang.org/

2 5

[ruby-core:115649] [Ruby master Bug#20050] Segfault on Ruby 3.2.2 on x86_64 Darwin 20 (maybe in Array#hash)
by martinemde (Martin Emde) 08 Apr '24

08 Apr '24

Issue #20050 has been reported by martinemde (Martin Emde). ---------------------------------------- Bug #20050: Segfault on Ruby 3.2.2 on x86_64 Darwin 20 (maybe in Array#hash) https://bugs.ruby-lang.org/issues/20050 * Author: martinemde (Martin Emde) * Status: Open * Priority: Normal * ruby -v: ruby 3.2.2 (2023-03-30 revision e51014f9c0) [x86_64-darwin20] * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- Hi, In the rubygems & bundler repositories we've now had two segfaults in the same exact code within days of merging a change to that code, both on ruby 3.2.2 on darwin20. 1. https://github.com/rubygems/rubygems/actions/runs/7110489973/job/1935706778… 2. https://github.com/rubygems/rubygems/actions/runs/7131889001/job/1942130416… The specific error seems to happen when calculating the hash of the array in Gem::NameTuple#hash. The array contents that is being `.hash`ed both times should be exactly: `["has_metadata", "1.0", "ruby"]`. If I'm reading this correctly, this indicates that the crash is related either to creating this hash or storing this hash in the hash table (I'm not quite sure which is triggering the crash). An excerpt of the C backtrace shows the same backtrace for both crashes: ``` -- C level backtrace information ------------------------------------------- /Users/runner/hostedtoolcache/Ruby/3.2.2/x64/lib/libruby.3.2.dylib(rb_vm_bugreport+0x7c4) [0x10cb0f994] /Users/runner/hostedtoolcache/Ruby/3.2.2/x64/lib/libruby.3.2.dylib(rb_bug_for_fatal_signal+0x1d0) [0x10c9158c0] /Users/runner/hostedtoolcache/Ruby/3.2.2/x64/lib/libruby.3.2.dylib(sigsegv+0x5b) [0x10ca609ab] /usr/lib/system/libsystem_platform.dylib(_sigtramp+0x1d) [0x7ff810c14dfd] /Users/runner/hostedtoolcache/Ruby/3.2.2/x64/lib/libruby.3.2.dylib(rb_id_table_lookup+0x16) [0x10caa2a56] /Users/runner/hostedtoolcache/Ruby/3.2.2/x64/lib/libruby.3.2.dylib(callable_method_entry_or_negative+0x5e) [0x10cae9c8e] /Users/runner/hostedtoolcache/Ruby/3.2.2/x64/lib/libruby.3.2.dylib(rb_check_funcall_basic_kw+0x129) [0x10caf0039] /Users/runner/hostedtoolcache/Ruby/3.2.2/x64/lib/libruby.3.2.dylib(obj_any_hash+0x3c) [0x10c94bd2c] /Users/runner/hostedtoolcache/Ruby/3.2.2/x64/lib/libruby.3.2.dylib(any_hash+0x52) [0x10c94bc12] /Users/runner/hostedtoolcache/Ruby/3.2.2/x64/lib/libruby.3.2.dylib(rb_st_add_direct+0x1d) [0x10ca69b7d] /Users/runner/hostedtoolcache/Ruby/3.2.2/x64/lib/libruby.3.2.dylib(ar_try_convert_table+0x85) [0x10c94d015] /Users/runner/hostedtoolcache/Ruby/3.2.2/x64/lib/libruby.3.2.dylib(rb_hash_aset+0x18f) [0x10c94e26f] ``` I'm not sure how to follow this instruction in this case on GitHub actions: "Don't forget to include the Crash Report log file under DiagnosticReports directory in bug reports." I have not been able to reproduce this locally with the same version of ruby (but I'm on darwin22 instead of 20). I will follow up if we continue to see this same crash. -- https://bugs.ruby-lang.org/

6 10

[ruby-core:115952] [Ruby master Bug#20102] Introduce `Fiber#resuming?`
by ioquatix (Samuel Williams) 07 Apr '24

07 Apr '24

Issue #20102 has been reported by ioquatix (Samuel Williams). ---------------------------------------- Bug #20102: Introduce `Fiber#resuming?` https://bugs.ruby-lang.org/issues/20102 * Author: ioquatix (Samuel Williams) * Status: Open * Priority: Normal * Assignee: ioquatix (Samuel Williams) * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- There are some tricky edge cases when using `Fibre#raise` and `Fiber#kill`, e.g. ```ruby fiber = nil killer = Fiber.new do fiber.raise("Stop") end fiber = Fiber.new do killer.resume end fiber.resume # 4:in `raise': attempt to raise a resuming fiber (FiberError) # 4:in `block in <main>' ``` Async has to deal with this edge case explicitly by rescuing the exception: https://github.com/socketry/async/blob/ffd019d9c1d547926a28fe8f36bf7bfe91d8… I'd like to avoid doing that and instead just ask "Can I kill/raise on this fiber right now?" which is determined by whether the fiber itself can be resumed or transferred to. To address this, I'd like to introduce `Fiber#resuming?`: ```c /* * call-seq: fiber.resumed? -> true or false * * Whether the fiber is currently resumed. */ VALUE rb_fiber_resuming_p(VALUE fiber_value) { struct rb_fiber_struct *fiber = fiber_ptr(fiber_value); if (FIBER_TERMINATED_P(fiber)) return RUBY_Qfalse; return RBOOL(fiber->resuming_fiber); } ``` See the PR: https://github.com/ruby/ruby/pull/9382 -- https://bugs.ruby-lang.org/

3 6

[ruby-core:113195] [Ruby master Bug#19592] Unable to statically link a single extension in 3.2.x and >3.1.4
by npic1 (Nat Pic1) 07 Apr '24

07 Apr '24

Issue #19592 has been reported by npic1 (Nat Pic1). ---------------------------------------- Bug #19592: Unable to statically link a single extension in 3.2.x and >3.1.4 https://bugs.ruby-lang.org/issues/19592 * Author: npic1 (Nat Pic1) * Status: Open * Priority: Normal * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- Hi, I need to statically link a single extension (not all of them) by adding it to ext/Setup. This worked until version 3.1.4 and 3.2.x. It appears that this change broke it: [https://bugs.ruby-lang.org/projects/ruby-master/repository/git/revisions/79… [https://github.com/ruby/ruby/pull/6756](https://github.com/ruby/ruby/pull/6…. I have attached a script to reproduce the issue. When running the script, `ldd` fails with: ``` ext/extinit.o: in function `Init_ext': extinit.c:(.text+0x10): undefined reference to `ruby_init_ext' ``` ---Files-------------------------------- ruby_static_test.sh (1.57 KB) -- https://bugs.ruby-lang.org/

2 2

[ruby-core:115831] [Ruby master Bug#20076] M:N scheduler crashes on macOS with RUBY_MN_THREADS=1
by hsbt (Hiroshi SHIBATA) 03 Apr '24

03 Apr '24

Issue #20076 has been reported by hsbt (Hiroshi SHIBATA). ---------------------------------------- Bug #20076: M:N scheduler crashes on macOS with RUBY_MN_THREADS=1 https://bugs.ruby-lang.org/issues/20076 * Author: hsbt (Hiroshi SHIBATA) * Status: Open * Priority: Normal * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- This is known issue. I already shared this to ko1. The version of https://github.com/ruby/ruby/commit/28e3886689c71b22487dd5d0cb62f3b5ed0a77cc is crashed with `make exam`. This is happend with webrick test on `make test-tool`. My environment is macOS Sonoma 14.3 beta1 and ``` $ pkgutil --pkg-info=com.apple.pkg.CLTools_Executables package-id: com.apple.pkg.CLTools_Executables version: 15.1.0.0.1.1700200546 volume: / location: / install-time: 1702331495 ``` -- https://bugs.ruby-lang.org/

2 6

[ruby-core:116534] [Ruby master Bug#20231] Don't wait in io_binwrite_string if not necessary.
by ioquatix (Samuel Williams) 01 Apr '24

01 Apr '24

Issue #20231 has been reported by ioquatix (Samuel Williams). ---------------------------------------- Bug #20231: Don't wait in io_binwrite_string if not necessary. https://bugs.ruby-lang.org/issues/20231 * Author: ioquatix (Samuel Williams) * Status: Open * Priority: Normal * Backport: 3.2: REQUIRED, 3.3: REQUIRED ---------------------------------------- PR: https://github.com/ruby/ruby/pull/9792 Writing to a buffered IO can result in the entire internal buffer being flushed, which causes `io_binwrite_string_internal` to return 0. In that case, we were setting `errno = EAGAIN`. This causes `rb_io_maybe_wait_writable` to be invoked, however we should immediately retry `io_binwrite_string_internal` instead. The reason why calling `rb_io_maybe_wait_writable` is a bad idea in general, is that not all IO can go via this mechanism in every situation - in other words, `kqueue` does not support `kevent("/dev/null", writable)` and returns errno=22 `EINVAL`. The same applies to some kinds of pipes, TTYs, etc. Indirectly responsible for <https://github.com/socketry/async/issues/301>. -- https://bugs.ruby-lang.org/

3 7

[ruby-core:116622] [Ruby master Bug#20245] Crash when checking symbol encoding
by peterzhu2118 (Peter Zhu) 31 Mar '24

31 Mar '24

Issue #20245 has been reported by peterzhu2118 (Peter Zhu). ---------------------------------------- Bug #20245: Crash when checking symbol encoding https://bugs.ruby-lang.org/issues/20245 * Author: peterzhu2118 (Peter Zhu) * Status: Open * Priority: Normal * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: REQUIRED, 3.3: REQUIRED ---------------------------------------- GitHub PR: https://github.com/ruby/ruby/pull/9871 We sometimes pass in a fake string to sym_check_asciionly. This can crash if sym_check_asciionly raises because it creates a CFP with the fake string as the receiver which will crash if GC tries to mark the CFP. For example, the following script crashes: ```ruby GC.stress = true Object.const_defined?("\xC3") ``` -- https://bugs.ruby-lang.org/

3 2

[ruby-core:116230] [Ruby master Bug#20190] `invalid_encoding_string << number` should be valid encoding in some case, but does not
by tompng (tomoya ishida) 31 Mar '24

31 Mar '24

Issue #20190 has been reported by tompng (tomoya ishida). ---------------------------------------- Bug #20190: `invalid_encoding_string << number` should be valid encoding in some case, but does not https://bugs.ruby-lang.org/issues/20190 * Author: tompng (tomoya ishida) * Status: Open * Priority: Normal * ruby -v: ruby 3.4.0dev (2024-01-09T07:07:19Z master db476cc71c) [x86_64-linux] * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- In some encoding, appending ascii char might change invalid encoding string to valid. But it does not. ~~~ruby # encoding: utf-8 valid = '表'.encode('sjis') valid.bytes # => [0x95, 0x5c] s = valid.byteslice(0, 1) p s.valid_encoding? #=> false s << 0x5c p s == valid #=> true p s.valid_encoding? #=> should be true, but false ~~~ pull request: https://github.com/ruby/ruby/pull/9553 -- https://bugs.ruby-lang.org/

3 2

[ruby-core:116336] [Ruby master Bug#20194] Memory leak with TracePoint on bmethod
by peterzhu2118 (Peter Zhu) 31 Mar '24

31 Mar '24

Issue #20194 has been reported by peterzhu2118 (Peter Zhu). ---------------------------------------- Bug #20194: Memory leak with TracePoint on bmethod https://bugs.ruby-lang.org/issues/20194 * Author: peterzhu2118 (Peter Zhu) * Status: Open * Priority: Normal * Backport: 3.0: UNKNOWN, 3.1: REQUIRED, 3.2: REQUIRED, 3.3: REQUIRED ---------------------------------------- GitHub PR: https://github.com/ruby/ruby/pull/9614 When disabling the TracePoint on bmethod, the hooks list is not freed. For example: ```ruby obj = Object.new obj.define_singleton_method(:foo) {} bmethod = obj.method(:foo) tp = TracePoint.new(:return) {} 10.times do 100_000.times do tp.enable(target: bmethod) {} end puts `ps -o rss= -p #{$$}` end ``` Before: ``` 18208 22832 26528 29728 34000 37776 40864 44400 47680 51504 ``` After: ``` 16688 17168 17168 17248 17696 17760 17824 17824 17856 17920 ``` -- https://bugs.ruby-lang.org/

3 2

[ruby-core:115933] [Ruby master Bug#20098] Wrong regexp match in ruby 3.2 and 3.3
by tompng (tomoya ishida) 31 Mar '24

31 Mar '24

Issue #20098 has been reported by tompng (tomoya ishida). ---------------------------------------- Bug #20098: Wrong regexp match in ruby 3.2 and 3.3 https://bugs.ruby-lang.org/issues/20098 * Author: tompng (tomoya ishida) * Status: Open * Priority: Normal * ruby -v: ruby 3.3.0 (2023-12-25 revision 5124f9ac75) +MN [arm64-darwin22] * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- These regexp all matches in ruby 3.1.4, but not in ruby 3.3.0. ~~~ruby p /a((.|.)|bc){,4}z/.match? 'abcbcbcbcz' p /a(b+?c*){4,5}z/.match? 'abbbccbbbccbcbcz' # matches in ruby 3.2.2 p /a(b+?(.|.)){2,3}z/.match? 'abbbcbbbcbbbcz' p /a(b*?(.|.)[bc]){2,5}z/.match? 'abcbbbcbcccbcz' ~~~ Adding backref (to disable optimization) makes them match. ~~~ruby p /()\1a((.|.)|bc){,4}z/.match? 'abcbcbcbcz' p /()\1a(b+?c*){4,5}z/.match? 'abbbccbbbccbcbcz' p /()\1a(b+?(.|.)){2,3}z/.match? 'abbbcbbbcbbbcz' p /()\1a(b*?(.|.)[bc]){2,5}z/.match? 'abcbbbcbcccbcz' ~~~ Found in this script https://gist.github.com/tompng/aa0706a181e9187bd79e8cec5a5f3c97 -- https://bugs.ruby-lang.org/

5 5