February 2024 - ruby-core - ml.ruby-lang.org

[ruby-core:116534] [Ruby master Bug#20231] Don't wait in io_binwrite_string if not necessary.
by ioquatix (Samuel Williams) 01 Apr '24

01 Apr '24

Issue #20231 has been reported by ioquatix (Samuel Williams). ---------------------------------------- Bug #20231: Don't wait in io_binwrite_string if not necessary. https://bugs.ruby-lang.org/issues/20231 * Author: ioquatix (Samuel Williams) * Status: Open * Priority: Normal * Backport: 3.2: REQUIRED, 3.3: REQUIRED ---------------------------------------- PR: https://github.com/ruby/ruby/pull/9792 Writing to a buffered IO can result in the entire internal buffer being flushed, which causes `io_binwrite_string_internal` to return 0. In that case, we were setting `errno = EAGAIN`. This causes `rb_io_maybe_wait_writable` to be invoked, however we should immediately retry `io_binwrite_string_internal` instead. The reason why calling `rb_io_maybe_wait_writable` is a bad idea in general, is that not all IO can go via this mechanism in every situation - in other words, `kqueue` does not support `kevent("/dev/null", writable)` and returns errno=22 `EINVAL`. The same applies to some kinds of pipes, TTYs, etc. Indirectly responsible for <https://github.com/socketry/async/issues/301>. -- https://bugs.ruby-lang.org/

3 7

[ruby-core:116622] [Ruby master Bug#20245] Crash when checking symbol encoding
by peterzhu2118 (Peter Zhu) 31 Mar '24

31 Mar '24

Issue #20245 has been reported by peterzhu2118 (Peter Zhu). ---------------------------------------- Bug #20245: Crash when checking symbol encoding https://bugs.ruby-lang.org/issues/20245 * Author: peterzhu2118 (Peter Zhu) * Status: Open * Priority: Normal * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: REQUIRED, 3.3: REQUIRED ---------------------------------------- GitHub PR: https://github.com/ruby/ruby/pull/9871 We sometimes pass in a fake string to sym_check_asciionly. This can crash if sym_check_asciionly raises because it creates a CFP with the fake string as the receiver which will crash if GC tries to mark the CFP. For example, the following script crashes: ```ruby GC.stress = true Object.const_defined?("\xC3") ``` -- https://bugs.ruby-lang.org/

3 2

[ruby-core:116230] [Ruby master Bug#20190] `invalid_encoding_string << number` should be valid encoding in some case, but does not
by tompng (tomoya ishida) 31 Mar '24

31 Mar '24

Issue #20190 has been reported by tompng (tomoya ishida). ---------------------------------------- Bug #20190: `invalid_encoding_string << number` should be valid encoding in some case, but does not https://bugs.ruby-lang.org/issues/20190 * Author: tompng (tomoya ishida) * Status: Open * Priority: Normal * ruby -v: ruby 3.4.0dev (2024-01-09T07:07:19Z master db476cc71c) [x86_64-linux] * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- In some encoding, appending ascii char might change invalid encoding string to valid. But it does not. ~~~ruby # encoding: utf-8 valid = '表'.encode('sjis') valid.bytes # => [0x95, 0x5c] s = valid.byteslice(0, 1) p s.valid_encoding? #=> false s << 0x5c p s == valid #=> true p s.valid_encoding? #=> should be true, but false ~~~ pull request: https://github.com/ruby/ruby/pull/9553 -- https://bugs.ruby-lang.org/

3 2

[ruby-core:116336] [Ruby master Bug#20194] Memory leak with TracePoint on bmethod
by peterzhu2118 (Peter Zhu) 31 Mar '24

31 Mar '24

Issue #20194 has been reported by peterzhu2118 (Peter Zhu). ---------------------------------------- Bug #20194: Memory leak with TracePoint on bmethod https://bugs.ruby-lang.org/issues/20194 * Author: peterzhu2118 (Peter Zhu) * Status: Open * Priority: Normal * Backport: 3.0: UNKNOWN, 3.1: REQUIRED, 3.2: REQUIRED, 3.3: REQUIRED ---------------------------------------- GitHub PR: https://github.com/ruby/ruby/pull/9614 When disabling the TracePoint on bmethod, the hooks list is not freed. For example: ```ruby obj = Object.new obj.define_singleton_method(:foo) {} bmethod = obj.method(:foo) tp = TracePoint.new(:return) {} 10.times do 100_000.times do tp.enable(target: bmethod) {} end puts `ps -o rss= -p #{$$}` end ``` Before: ``` 18208 22832 26528 29728 34000 37776 40864 44400 47680 51504 ``` After: ``` 16688 17168 17168 17248 17696 17760 17824 17824 17856 17920 ``` -- https://bugs.ruby-lang.org/

3 2

[ruby-core:115933] [Ruby master Bug#20098] Wrong regexp match in ruby 3.2 and 3.3
by tompng (tomoya ishida) 31 Mar '24

31 Mar '24

Issue #20098 has been reported by tompng (tomoya ishida). ---------------------------------------- Bug #20098: Wrong regexp match in ruby 3.2 and 3.3 https://bugs.ruby-lang.org/issues/20098 * Author: tompng (tomoya ishida) * Status: Open * Priority: Normal * ruby -v: ruby 3.3.0 (2023-12-25 revision 5124f9ac75) +MN [arm64-darwin22] * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- These regexp all matches in ruby 3.1.4, but not in ruby 3.3.0. ~~~ruby p /a((.|.)|bc){,4}z/.match? 'abcbcbcbcz' p /a(b+?c*){4,5}z/.match? 'abbbccbbbccbcbcz' # matches in ruby 3.2.2 p /a(b+?(.|.)){2,3}z/.match? 'abbbcbbbcbbbcz' p /a(b*?(.|.)[bc]){2,5}z/.match? 'abcbbbcbcccbcz' ~~~ Adding backref (to disable optimization) makes them match. ~~~ruby p /()\1a((.|.)|bc){,4}z/.match? 'abcbcbcbcz' p /()\1a(b+?c*){4,5}z/.match? 'abbbccbbbccbcbcz' p /()\1a(b+?(.|.)){2,3}z/.match? 'abbbcbbbcbbbcz' p /()\1a(b*?(.|.)[bc]){2,5}z/.match? 'abcbbbcbcccbcz' ~~~ Found in this script https://gist.github.com/tompng/aa0706a181e9187bd79e8cec5a5f3c97 -- https://bugs.ruby-lang.org/

5 5

[ruby-core:113782] [Ruby master Bug#19716] SystemStackError occurs too easily on Alpine Linux (due to small stack size reported by pthread_attr_getstacksize on musl libc)
by alexdowad (Alex Dowad) 27 Mar '24

27 Mar '24

Issue #19716 has been reported by alexdowad (Alex Dowad). ---------------------------------------- Bug #19716: SystemStackError occurs too easily on Alpine Linux (due to small stack size reported by pthread_attr_getstacksize on musl libc) https://bugs.ruby-lang.org/issues/19716 * Author: alexdowad (Alex Dowad) * Status: Open * Priority: Normal * ruby -v: ruby 3.1.4p223 (2023-03-30 revision 957bb7cb81) [x86_64-linux-musl] * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- This is the same problem previously reported against Ruby 2.5 in https://bugs.ruby-lang.org/issues/14387. I just ran into the same problem on Ruby 3.1.4, built on Alpine Linux 3.16. @hsbt stated in the previous thread (https://bugs.ruby-lang.org/issues/14387#note-28) > If you have this issue with Ruby 3.2, please file it with another issue. I hacked `stack_check` in gc.c to print the values of `STACK_START` and `STACK_END` on stack overflow; on the Alpine 3.16 host where this problem just occurred, the values printed were: > Start=0x7ffd0bf4f000, End=0x7ffd0bf32530 ...which shows that Ruby thinks the stack size is only 131072 bytes. On the other hand, `ulimit -s` shows a stack size limit of 8192kb. This Ruby 3.1.4 was built from unmodified source code downloaded from https://cache.ruby-lang.org; the build was configured using `CFLAGS='-march=native' ./configure --disable-install-doc`. The invocation of Ruby which blew the stack was `bundle exec rake db:migrate`, on a mid-sized Rails project. Regarding @ncopa's patch from #14387, @wanabe listed some things which should be done before it is merged into mainline Ruby: > Okay, The patch needs one or more proofs of its behaviour, like that: > > Original issue [ruby-dev:50421] has gone away. > Standard test codes run well. > test-all > ruby/spec > getrlimit works on some situations like: > on single thread > with multiple threads > with RLIMIT_STACK environment variable > getrlimit code of musl is implemented correctly as expected. > (But It's doubtful whether it can be. I guess that a proof of code soundness is very difficult.) > Some "real world" applications can work. > I think it is better example that that application(s) can't work without the patch. I am happy to help cover some of these points if the Ruby development team is still interested in merging @ncopa's patch. -- https://bugs.ruby-lang.org/

4 5

[ruby-core:115538] [Ruby master Misc#20028] I'd like my commit bit back
by zenspider (Ryan Davis) 27 Mar '24

27 Mar '24

Issue #20028 has been reported by zenspider (Ryan Davis). ---------------------------------------- Misc #20028: I'd like my commit bit back https://bugs.ruby-lang.org/issues/20028 * Author: zenspider (Ryan Davis) * Status: Open * Priority: Normal ---------------------------------------- It's been a while, in the svn -> git shuffle I lost commit privs. I'd like to help out more actively, triage issues, clean doco, etc. Not sure who's doing admin work so I'm not sure who to assign to to expedite. -- https://bugs.ruby-lang.org/

4 6

[ruby-core:116106] [Ruby master Bug#20168] Process won't exit when Ractor.select waiting a Ractor
by shia (Sangyong Sim) 26 Mar '24

26 Mar '24

Issue #20168 has been reported by shia (Sangyong Sim). ---------------------------------------- Bug #20168: Process won't exit when Ractor.select waiting a Ractor https://bugs.ruby-lang.org/issues/20168 * Author: shia (Sangyong Sim) * Status: Open * Priority: Normal * ruby -v: 3.3.0 * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- ## Reproduction code ```ruby trap(:INT) do puts "SIGINT" exit end trap(:TERM) do puts "SIGTERM" exit end r = Ractor.new do loop do sleep 1 end end Ractor.select(r) # stucked. # SIGINT/SIGTERM sent to Ruby process(confirmed by trap), # but process won't exit. ``` ## Expected behavior Process killed successfully with exit code 0. ## Affected Ruby version 3.3.0 3.2.x works as expected. -- https://bugs.ruby-lang.org/

3 2

[ruby-core:111075] [Ruby master Bug#19161] Cannot compile 3.0.5 or 3.1.3 on Red Hat 7
by werebus (Matt Moretti) 25 Mar '24

25 Mar '24

Issue #19161 has been reported by werebus (Matt Moretti). ---------------------------------------- Bug #19161: Cannot compile 3.0.5 or 3.1.3 on Red Hat 7 https://bugs.ruby-lang.org/issues/19161 * Author: werebus (Matt Moretti) * Status: Open * Priority: Normal * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN ---------------------------------------- When attempting to run `make` on either the 3.0.5 or 3.1.3 release, I get the following error (I included the whole output as it's pretty short): ``` BASERUBY = /opt/ruby/bin/ruby --disable=gems CC = gcc -std=gnu11 LD = ld LDSHARED = gcc -std=gnu11 -shared CFLAGS = -O3 -fno-fast-math -ggdb3 -Wall -Wextra -Wdeprecated-declarations -Wimplicit-function-declaration -Wimplicit-int -Wpointer-arith -Wwrite-strings -Wold-style-definition -Wmissing-noreturn -Wno-cast-function-type -Wno-constant-logical-operand -Wno-long-long -Wno-missing-field-initializers -Wno-overlength-strings -Wno-packed-bitfield-compat -Wno-parentheses-equality -Wno-self-assign -Wno-tautological-compare -Wno-unused-parameter -Wno-unused-value -Wsuggest-attribute=format -Wsuggest-attribute=noreturn -Wunused-variable XCFLAGS = -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-strict-overflow -fvisibility=hidden -fexcess-precision=standard -DRUBY_EXPORT -fPIE -I. -I.ext/include/x86_64-linux -I./include -I. -I./enc/unicode/13.0.0 CPPFLAGS = DLDFLAGS = -Wl,--compress-debug-sections=zlib -fstack-protector-strong -pie SOLIBS = -lz -lpthread -lrt -lrt -ldl -lcrypt -lm LANG = en_US.UTF-8 LC_ALL = LC_CTYPE = MFLAGS = gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-44) Copyright (C) 2015 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. compiling ./main.c compiling dmydln.c compiling miniinit.c In file included from vm_core.h:83:0, from iseq.h:14, from mini_builtin.c:3, from miniinit.c:51: thread_pthread.h:108:43: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘struct’ RUBY_EXTERN RB_THREAD_LOCAL_SPECIFIER struct rb_execution_context_struct *ruby_current_ec; ^ In file included from iseq.h:14:0, from mini_builtin.c:3, from miniinit.c:51: vm_core.h: In function ‘rb_current_execution_context’: vm_core.h:1870:34: error: ‘ruby_current_ec’ undeclared (first use in this function) rb_execution_context_t *ec = ruby_current_ec; ^ vm_core.h:1870:34: note: each undeclared identifier is reported only once for each function it appears in miniinit.c: At top level: cc1: warning: unrecognized command line option "-Wno-tautological-compare" [enabled by default] cc1: warning: unrecognized command line option "-Wno-self-assign" [enabled by default] cc1: warning: unrecognized command line option "-Wno-parentheses-equality" [enabled by default] cc1: warning: unrecognized command line option "-Wno-constant-logical-operand" [enabled by default] cc1: warning: unrecognized command line option "-Wno-cast-function-type" [enabled by default] make: *** [miniinit.o] Error 1 ``` Both Ruby 3.0.4 and 3.1.2 build without error and pass (all but one of) the `make check` tests. I know RHEL 7 is getting to be pretty old; I suspect a factor here are the ancient build tools available to me. But... EOL for Ruby 2.7 comes before the one for RHEL 7, so I'm trying to prioritize. -- https://bugs.ruby-lang.org/

10 14

[ruby-core:116819] [Ruby master Feature#20275] Avoid extra backtrace entries for rescue and ensure
by Eregon (Benoit Daloze) 21 Mar '24

21 Mar '24

Issue #20275 has been reported by Eregon (Benoit Daloze). ---------------------------------------- Feature #20275: Avoid extra backtrace entries for rescue and ensure https://bugs.ruby-lang.org/issues/20275 * Author: Eregon (Benoit Daloze) * Status: Open * Priority: Normal ---------------------------------------- From https://bugs.ruby-lang.org/issues/19117#note-48: ```ruby def raise_nested_exceptions raise "First error" rescue begin raise "Second error" rescue raise "Third error" end end raise_nested_exceptions ``` Current: ``` -:7:in 'Object#raise_nested_exceptions': Third error (RuntimeError) from -:4:in 'Object#raise_nested_exceptions' from -:1:in 'Object#raise_nested_exceptions' from -:11:in '<main>' -:5:in 'Object#raise_nested_exceptions': Second error (RuntimeError) from -:1:in 'Object#raise_nested_exceptions' from -:11:in '<main>' -:2:in 'Object#raise_nested_exceptions': First error (RuntimeError) from -:11:in '<main>' ``` The above repeated backtrace entries for `Object#raise_nested_exceptions` are because of CRuby implementation details. It seems best to hide them because they do not help understanding the program, and semantically there is no (method or proc) call on line 1 or 4. Proposed: ``` -:7:in 'Object#raise_nested_exceptions': Third error (RuntimeError) from -:11:in '<main>' -:5:in 'Object#raise_nested_exceptions': Second error (RuntimeError) from -:11:in '<main>' -:2:in 'Object#raise_nested_exceptions': First error (RuntimeError) from -:11:in '<main>' ``` We can see TruffleRuby already behave this way, most likely because they do not use an extra frame for `rescue`. It is definitely useful to have the same backtrace on different Ruby implementations as lots of tests rely on this. TruffleRuby 23.1.2: ``` -:7:in `raise_nested_exceptions': Third error (RuntimeError) from -:11:in `<main>' -:5:in `raise_nested_exceptions': Second error (RuntimeError) from -:11:in `<main>' -:2:in `raise_nested_exceptions': First error (RuntimeError) from -:11:in `<main>' ``` JRuby 9.4.5.0: ``` RuntimeError: Third error raise_nested_exceptions at -:7 <main> at -:11 RuntimeError: Second error raise_nested_exceptions at -:5 <main> at -:11 RuntimeError: First error raise_nested_exceptions at -:2 <main> at -:11 ``` -- https://bugs.ruby-lang.org/

5 7