- ruby-core - ml.ruby-lang.org

[ruby-core:117858] [Ruby master Bug#20486] Internal compiler error when compile CRuby with msys2-mingw64-gcc14
by nekoyama32767 (Jinsong Yu) 13 May '24

13 May '24

Issue #20486 has been reported by nekoyama32767 (Jinsong Yu). ---------------------------------------- Bug #20486: Internal compiler error when compile CRuby with msys2-mingw64-gcc14 https://bugs.ruby-lang.org/issues/20486 * Author: nekoyama32767 (Jinsong Yu) * Status: Open * Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- Follow CRuby build guide in `https://github.com/ruby/ruby` Some file like `numerc.c` whill produce a `internal compiler error` when enble option `-fno-omit-frame-pointer` gcc version is ``` $ gcc --version gcc.exe (Rev2, Built by MSYS2 project) 14.1.0 Copyright (C) 2024 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. ``` ``` $ cc -fstack-protector-strong -fno-strict-overflow -fvisibility=hidden -fexcess-precision=standard -DRUBY_EXPORT -I. -I.ext/include/x64-mingw32 -I./include -I. -I./prism -I./enc/unicode/15.0.0 -O3 -fno-fast-math -ggdb3 -Wall -Wextra -Wdeprecated-declarations -Wdiv-by-zero -Wduplicated-cond -Wimplicit-function-declaration -Wimplicit-int -Wpointer-arith -Wwrite-strings -Wold-style-definition -Wimplicit-fallthrough=0 -Wmissing-noreturn -Wno-cast-function-type -Wno-constant-logical-operand -Wno-long-long -Wno-missing-field-initializers -Wno-overlength-strings -Wno-packed-bitfield-compat -Wno-parentheses-equality -Wno-self-assign -Wno-tautological-compare -Wno-unused-parameter -Wno-unused-value -Wsuggest-attribute=format -Wsuggest-attribute=noreturn -Wunused-variable -Wmisleading-indentation -Wundef -D_WIN32_WINNT=0x0600 -D__MINGW_USE_VC2005_COMPAT -c numeric.c -fno-omit-frame-pointer -freport-bug during RTL pass: dwarf2 numeric.c: In function 'rb_float_new_in_heap': numeric.c:1034:1: internal compiler error: in dwarf2out_frame_debug_expr, at dwarf2cfi.cc:2112 1034 | } | ^ Please submit a full bug report, with preprocessed source. See <https://github.com/msys2/MINGW-packages/issues> for instructions. ``` Without `-fno-omit-frame-pointer` option, compile will pass. OS: `MSYS_NT-10.0-22631` CPU: I9-14900HX -- https://bugs.ruby-lang.org/

2 1

[ruby-core:117834] [Ruby master Feature#20483] More intuitive initialisation of null Range
by bodacious (Gavin Morrice) 12 May '24

12 May '24

Issue #20483 has been reported by bodacious (Gavin Morrice). ---------------------------------------- Feature #20483: More intuitive initialisation of null Range https://bugs.ruby-lang.org/issues/20483 * Author: bodacious (Gavin Morrice) * Status: Open ---------------------------------------- Hi all 👋🏻 I've come across cases where I want a method to return a Range. In some cases, the Range should be empty. I see from the documentation, that it's possible to initialise a null Range by passing in values where a is greater than b `Range.new(1, -1)`. I find this particular notation to be unclear, and likely to be discouraged by my team because it's unclear. I'm opening this discussion to see if there's any interest in support for a simpler notation for null (empty) Ranges. Something like: ``` ruby r = Range.new(nil) # notation not currently supported r.size # => 0 r.max # => nil r.min # => nil r.each { puts "This is never called" } ``` -- https://bugs.ruby-lang.org/

2 1

[ruby-core:117833] [Ruby master Bug#20482] nil variables in a guard clause of a standalone => or in expression
by Soilent (Konstantin x) 12 May '24

12 May '24

Issue #20482 has been reported by Soilent (Konstantin x). ---------------------------------------- Bug #20482: nil variables in a guard clause of a standalone => or in expression https://bugs.ruby-lang.org/issues/20482 * Author: Soilent (Konstantin x) * Status: Open * ruby -v: ruby 3.3.0 (2023-12-25 revision 5124f9ac75) [arm64-darwin23] * Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- The following expression produces a TypeError, which is quite unexpected: ```ruby [1, 2] in a, b if b == 2*a ``` ``` x.rb:1:in `*': nil can't be coerced into Integer (TypeError) [1, 2] in a, b if b == 2*a ^ from x.rb:1:in `<main>' ``` The expression above should be equivalent to the following one, which works as expected: ```ruby case [1, 2] in a, b if b == 2*a true else false end # => true ``` Apologies in advance if this is intentional or has been reported before. -- https://bugs.ruby-lang.org/

2 3

[ruby-core:116940] [Ruby master Feature#20300] Hash: set value and get pre-existing value in one call
by AMomchilov (Alexander Momchilov) 11 May '24

11 May '24

Issue #20300 has been reported by AMomchilov (Alexander Momchilov). ---------------------------------------- Feature #20300: Hash: set value and get pre-existing value in one call https://bugs.ruby-lang.org/issues/20300 * Author: AMomchilov (Alexander Momchilov) * Status: Open ---------------------------------------- When using a Hash, sometimes you want to set a new value, *and* see what was already there. Today, you **have** to do this in two steps: ```ruby h = { k: "old value" } # 1. Do a look-up for `:k`. old_value = h[:k] # 2. Do another look-up for `:k`, even though we just did that! h[:k] = "new value" use(old_value) ``` This requires two separate `Hash` look-ups for `:k`. This is fine for symbols, but is expensive if computing `#hash` or `#eql?` is expensive for the key. It's impossible to work around this today from pure Ruby code. I propose adding `Hash#update_value`, which has semantics are similar to this Ruby snippet: ```ruby class Hash def update_value(key, new_value) old_value = self[key] self[key] = new_value old_value end end ``` ... except it'll be implemented in C, with modifications to `tbl_update` that achieves this with a hash-lookup. Here's a PR with a PoC implementation: https://github.com/ruby/ruby/pull/10092 -- https://bugs.ruby-lang.org/

8 18

[ruby-core:117831] [Ruby master Bug#20481] Untrusted Marshal data can overwrite class/module instance variables
by qnighy (Masaki Hara) 11 May '24

11 May '24

Issue #20481 has been reported by qnighy (Masaki Hara). ---------------------------------------- Bug #20481: Untrusted Marshal data can overwrite class/module instance variables https://bugs.ruby-lang.org/issues/20481 * Author: qnighy (Masaki Hara) * Status: Open * ruby -v: ruby 3.3.1 (2024-04-23 revision c56cd86388) [x86_64-linux] * Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- The following code snippet shows how class/module instance variables can be overwritten in Ruby. Checked on Ruby 3.3.1. ```ruby class <<Object; attr_reader :foo; end p Object.foo # => nil # Marshal.load("\x04\x08Ic\x0BObject\x06:\x09@fooi\x2F") # # => can't override instance variable of class `Object' (TypeError) # p Object.foo # # => nil Marshal.load("\x04\x08[\x07c\x0BObjectI@\x06\x06:\x09@fooi\x2F") # => [Object, Object] p Object.foo # => 42 ``` Although it is the program author's responsibility to trust Marshal data, [there was an attempt to disallow write to a class instance variable](https://github.com/ruby/ruby/commit/3fe939564fc5f4dde52a6b9bc385e… and it is considered a bug that one can circumvent this check. This bug was once submitted to HackerOne, just in case this is considered a security vulnerability, and it was concluded that the bug actually isn't. -- https://bugs.ruby-lang.org/

1 0

[ruby-core:117815] [Ruby master Misc#17569] `uri` lib maintainership
by hsbt (Hiroshi SHIBATA) 09 May '24

09 May '24

Issue #17569 has been updated by hsbt (Hiroshi SHIBATA). Status changed from Assigned to Closed Assignee changed from akr (Akira Tanaka) to hsbt (Hiroshi SHIBATA) We have been merged the followings instead of https://github.com/ruby/uri/pull/15 * https://github.com/ruby/uri/pull/22 * https://github.com/ruby/uri/pull/26 * https://github.com/ruby/uri/pull/27 I'll close this. ---------------------------------------- Misc #17569: `uri` lib maintainership https://bugs.ruby-lang.org/issues/17569#change-108224 * Author: marcandre (Marc-Andre Lafortune) * Status: Closed * Assignee: hsbt (Hiroshi SHIBATA) ---------------------------------------- I’d like to merge https://github.com/ruby/uri/pull/15 but it is an API change. I would release v1.0.0. @akr is the official maintainer of `uri`… Is he still interested in this role? Otherwise we could put “Ruby core team” in the listing… -- https://bugs.ruby-lang.org/

1 0

[ruby-core:117794] [Ruby master Bug#20474] Heredoc common leading whitespace calculation question
by kddnewton (Kevin Newton) 08 May '24

08 May '24

Issue #20474 has been reported by kddnewton (Kevin Newton). ---------------------------------------- Bug #20474: Heredoc common leading whitespace calculation question https://bugs.ruby-lang.org/issues/20474 * Author: kddnewton (Kevin Newton) * Status: Open * Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- I think I understand that <<~ will strip common leading whitespace from all lines. However, I am confused by the following example: ```ruby eval("<<~H\n \nh\n \nH\n") ``` In this example, the heredoc has 3 lines: " \n", "h\n", and " \n". The common leading whitespace is definitely 0, because of the 2nd line. However, the string is equal to `"\nh\n\n"`. In fact, no matter how many spaces you put _before_ the `h`, it will always be equal to `"\nh\n\n"`. I'm not sure if this is a bug, or even what is happening here. Could someone explain? -- https://bugs.ruby-lang.org/

3 3

[ruby-core:117804] [Ruby master Bug#20477] RJIT NoMatchingPatternError when initialize Hash literal with more 8 items
by ukolovda (Dmitry Ukolov) 08 May '24

08 May '24

Issue #20477 has been reported by ukolovda (Dmitry Ukolov). ---------------------------------------- Bug #20477: RJIT NoMatchingPatternError when initialize Hash literal with more 8 items https://bugs.ruby-lang.org/issues/20477 * Author: ukolovda (Dmitry Ukolov) * Status: Open * ruby -v: ruby 3.3.1 (2024-04-23 revision c56cd86388) [x86_64-linux] * Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- When I create Hash with 8 or more items: ```bash ruby --rjit -e "a = 1; 1.upto(10) { b={a1: a&1, a2: a&1, a3: a&1, a4: a&1, a5: a&1, a6: a&1, a7: a&1, a8: a&1} }" /home/ukolovda/.rvm/rubies/ruby-3.3.1/lib/ruby/3.3.0/ruby_vm/rjit/assembler.rb:124:in `and': [:rax, [:rbx, 128]] (NoMatchingPatternError) from /home/ukolovda/.rvm/rubies/ruby-3.3.1/lib/ruby/3.3.0/ruby_vm/rjit/insn_compiler.rb:2348:in `opt_and' from /home/ukolovda/.rvm/rubies/ruby-3.3.1/lib/ruby/3.3.0/ruby_vm/rjit/insn_compiler.rb:118:in `compile' from /home/ukolovda/.rvm/rubies/ruby-3.3.1/lib/ruby/3.3.0/ruby_vm/rjit/compiler.rb:321:in `compile_block' from /home/ukolovda/.rvm/rubies/ruby-3.3.1/lib/ruby/3.3.0/ruby_vm/rjit/compiler.rb:150:in `block in branch_stub_hit' from <internal:kernel>:133:in `then' from /home/ukolovda/.rvm/rubies/ruby-3.3.1/lib/ruby/3.3.0/ruby_vm/rjit/compiler.rb:149:in `branch_stub_hit' from -e:1:in `block in <main>' from -e:1:in `upto' from -e:1:in `<main>' ``` Test ruby file: ```ruby # test.rb # Running: ruby --rjit test.rb a = 1 1.upto(10) do b = { a1: a&1, a2: a&1, a3: a&1, a4: a&1, a5: a&1, a6: a&1, a7: a&1, a8: a&1, } end ``` (I described it first in #20475, but it is closed now. Current description is more clear and easy reproduce). -- https://bugs.ruby-lang.org/

2 3

[ruby-core:117796] [Ruby master Bug#20475] RJIT NoMatchingPatternError
by ukolovda (Dmitry Ukolov) 08 May '24

08 May '24

Issue #20475 has been reported by ukolovda (Dmitry Ukolov). ---------------------------------------- Bug #20475: RJIT NoMatchingPatternError https://bugs.ruby-lang.org/issues/20475 * Author: ukolovda (Dmitry Ukolov) * Status: Open * ruby -v: ruby 3.3.1 (2024-04-23 revision c56cd86388) [x86_64-linux] * Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- I try use RJIT for testing of Rails application: ```bash $ RUBYOPT="--rjit" bin/bundle exec rake test Started with run options --seed 63595 ... /home/ukolovda/.rvm/rubies/ruby-3.3.1/lib/ruby/3.3.0/ruby_vm/rjit/assembler.rb:124:in `and': [:rax, [:rbx, 128]] (NoMatchingPatternError) ] 70% Time: 00:05:26, ETA: 00:02:19 from /home/ukolovda/.rvm/rubies/ruby-3.3.1/lib/ruby/3.3.0/ruby_vm/rjit/insn_compiler.rb:2348:in `opt_and' from /home/ukolovda/.rvm/rubies/ruby-3.3.1/lib/ruby/3.3.0/ruby_vm/rjit/insn_compiler.rb:118:in `compile' from /home/ukolovda/.rvm/rubies/ruby-3.3.1/lib/ruby/3.3.0/ruby_vm/rjit/compiler.rb:321:in `compile_block' from /home/ukolovda/.rvm/rubies/ruby-3.3.1/lib/ruby/3.3.0/ruby_vm/rjit/compiler.rb:150:in `block in branch_stub_hit' from <internal:kernel>:133:in `then' from /home/ukolovda/.rvm/rubies/ruby-3.3.1/lib/ruby/3.3.0/ruby_vm/rjit/compiler.rb:149:in `branch_stub_hit' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/spreadsheet-1.3.1/lib/spreadsheet/excel/reader.rb:1263:in `set_row_address' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/spreadsheet-1.3.1/lib/spreadsheet/excel/reader.rb:884:in `read_worksheet' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/spreadsheet-1.3.1/lib/spreadsheet/excel/worksheet.rb:53:in `ensure_rows_read' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/spreadsheet-1.3.1/lib/spreadsheet/excel/worksheet.rb:46:in `each' from /home/ukolovda/.rvm/gems/ruby-3.3.1/bundler/gems/roo-xls-0032c662b4ad/lib/roo/xls/excel.rb:253:in `read_cells' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/roo-2.10.1/lib/roo/base.rb:119:in `block (2 levels) in <class:Base>' from /home/ukolovda/RubymineProjects/cc/app/app/models/concerns/contact_import.rb:401:in `open_spreadsheet' from /home/ukolovda/RubymineProjects/cc/app/app/models/concerns/contact_import.rb:317:in `parse_contacts' from /home/ukolovda/RubymineProjects/cc/app/app/models/concerns/contact_import.rb:206:in `import_contacts' from /home/ukolovda/RubymineProjects/cc/app/test/models/contact_test.rb:23:in `do_import2' from /home/ukolovda/RubymineProjects/cc/app/test/models/contact_test.rb:18:in `do_import' from /home/ukolovda/RubymineProjects/cc/app/test/models/contact_test.rb:194:in `block in <class:ContactTest>' from /home/ukolovda/RubymineProjects/cc/app/test/models/contact_test.rb:201:in `instance_exec' from /home/ukolovda/RubymineProjects/cc/app/test/models/contact_test.rb:201:in `block in create_test_from_should_hash' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/minitest-5.22.3/lib/minitest/test.rb:95:in `block (3 levels) in run' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/minitest-5.22.3/lib/minitest/test.rb:192:in `capture_exceptions' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/minitest-5.22.3/lib/minitest/test.rb:90:in `block (2 levels) in run' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/minitest-5.22.3/lib/minitest.rb:324:in `time_it' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/minitest-5.22.3/lib/minitest/test.rb:89:in `block in run' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/minitest-5.22.3/lib/minitest.rb:423:in `on_signal' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/minitest-5.22.3/lib/minitest/test.rb:240:in `with_info_handler' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/minitest-5.22.3/lib/minitest/test.rb:88:in `run' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/minitest-reporters-1.6.1/lib/minitest/reporters.rb:48:in `run_with_hooks' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/activesupport-7.1.3.2/lib/active_support/executor/test_helper.rb:5:in `block in run' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/activesupport-7.1.3.2/lib/active_support/execution_wrapper.rb:105:in `perform' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/activesupport-7.1.3.2/lib/active_support/executor/test_helper.rb:5:in `run' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/minitest-5.22.3/lib/minitest.rb:1138:in `run_one_method' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/minitest-5.22.3/lib/minitest.rb:389:in `run_one_method' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/minitest-5.22.3/lib/minitest.rb:376:in `block (2 levels) in run' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/minitest-5.22.3/lib/minitest.rb:375:in `each' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/minitest-5.22.3/lib/minitest.rb:375:in `block in run' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/minitest-5.22.3/lib/minitest.rb:423:in `on_signal' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/minitest-5.22.3/lib/minitest.rb:410:in `with_info_handler' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/minitest-5.22.3/lib/minitest.rb:374:in `run' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/railties-7.1.3.2/lib/rails/test_unit/line_filtering.rb:10:in `run' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/minitest-5.22.3/lib/minitest.rb:206:in `block in __run' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/minitest-5.22.3/lib/minitest.rb:206:in `map' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/minitest-5.22.3/lib/minitest.rb:206:in `__run' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/minitest-5.22.3/lib/minitest.rb:162:in `run' from /home/ukolovda/.rvm/gems/ruby-3.3.1/gems/minitest-5.22.3/lib/minitest.rb:86:in `block in autorun' ``` I cannot give entire application, but this error happen on line https://github.com/zdavatz/spreadsheet/blob/2f4253f2eb882fd4d43eaed164eb8a1… of spreadsheet gem. I try reproduce error on this gem with `--rjit` option, but can't. I also try extract calculation of boolean to variable, and it work fine, but error happen later: Origin code (spreadsheet-1.3.1/lib/spreadsheet/excel/reader.rb, line from 1255): ```ruby attrs = { :default_format => format, :first_used => first_used, :first_unused => first_unused, :index => index, :row_block => @current_row_block_offset, :offset => @current_row_block_offset[0], :outline_level => flags & 0x00000007, :collapsed => (flags & 0x0000010) > 0, # <== Error happen there :hidden => (flags & 0x0000020) > 0, } ``` Modified code: ```ruby collapsed = (flags & 0x0000010) > 0 hidden = (flags & 0x0000020) > 0 outline_level = flags & 0x00000007 # TODO: read attributes from work[13,3], read flags attrs = { :default_format => format, :first_used => first_used, :first_unused => first_unused, :index => index, :row_block => @current_row_block_offset, :offset => @current_row_block_offset[0], :outline_level => outline_level, :collapsed => collapsed, :hidden => hidden, } if (flags & 0x00000040) > 0 # <== Error happen there attrs.store :height, height / TWIPS end ``` And new error have other attribute: ruby_vm/rjit/assembler.rb:124:in `and': [:rax, [:rbx, -136]] (NoMatchingPatternError) -- https://bugs.ruby-lang.org/

2 2

[ruby-core:117801] [Ruby master Feature#20476] Add Enumerator#eager that returns self, like Enumerator::Lazy#lazy
by shan (Shannon Skipper) 08 May '24

08 May '24

Issue #20476 has been reported by shan (Shannon Skipper). ---------------------------------------- Feature #20476: Add Enumerator#eager that returns self, like Enumerator::Lazy#lazy https://bugs.ruby-lang.org/issues/20476 * Author: shan (Shannon Skipper) * Status: Open ---------------------------------------- I'd like to propose adding an Enumerator#eager method. We currently have Enumerator#lazy, Enumerator::Lazy#lazy, Enumerator::Lazy#eager, but not Enumerator#eager. I like that you can always call `enum.lazy` with any type of Enumerator since a lazy Enumerator will just return itself. This PR just adds an equivalent `enum.eager` for eager Enumerators. I've found it handy to be able to call `.lazy` to ensure that I have a lazy Enumerator and would like to be able to do the same with `.eager`, which currently is only implemented on Enumerator::Lazy. -- https://bugs.ruby-lang.org/

1 1