- ruby-core - ml.ruby-lang.org

[ruby-core:111339] [Ruby master Feature#19245] Strict mode for Array#pack that doesn't silently truncate numbers that are too large for the given directive
by byroot (Jean Boussier) 20 Jan '23

20 Jan '23

Issue #19245 has been reported by byroot (Jean Boussier). ---------------------------------------- Feature #19245: Strict mode for Array#pack that doesn't silently truncate numbers that are too large for the given directive https://bugs.ruby-lang.org/issues/19245 * Author: byroot (Jean Boussier) * Status: Open * Priority: Normal ---------------------------------------- ```ruby >> [256].pack("C").unpack1("C") => 0 >> [257].pack("C").unpack1("C") => 1 ``` This is specified: ```ruby it "encodes the least significant 32 bits of a negative number" do [ [[-0x0000_0021], "\xdf\xff\xff\xff"], [[-0x0000_4321], "\xdf\xbc\xff\xff"], [[-0x0065_4321], "\xdf\xbc\x9a\xff"], [[-0x7865_4321], "\xdf\xbc\x9a\x87"] ].should be_computed_by(:pack, pack_format()) end ``` But not documented in `Array#pack`. I think that in many case this may lead to silent bugs. ### Possible solutions We could have a strict version of `pack`, either `pack(template, strict: true)` or `pack!(template)`. Or alternatively if we think this is never a desired behavior, we could change `pack` to first warn on truncation and later raise. -- https://bugs.ruby-lang.org/

5 7

[ruby-core:111746] [Ruby master Bug#19327] Backport commits 3be2acfafd3b3c6168e2266c7c6561d143d7ae5c and 9726736006b3f74635fd8af05814fe0908e2cf84
by peterzhu2118 (Peter Zhu) 20 Jan '23

20 Jan '23

Issue #19327 has been reported by peterzhu2118 (Peter Zhu). ---------------------------------------- Bug #19327: Backport commits 3be2acfafd3b3c6168e2266c7c6561d143d7ae5c and 9726736006b3f74635fd8af05814fe0908e2cf84 https://bugs.ruby-lang.org/issues/19327 * Author: peterzhu2118 (Peter Zhu) * Status: Closed * Priority: Normal * Backport: 2.7: DONTNEED, 3.0: DONTNEED, 3.1: DONTNEED, 3.2: REQUIRED ---------------------------------------- Please backport commits [3be2acfafd3b3c6168e2266c7c6561d143d7ae5c](https://github.com/ruby/ruby/comm… and [9726736006b3f74635fd8af05814fe0908e2cf84](https://github.com/ruby/ruby/comm…. This commits fixes a bug where string objects are not correctly re-embedding during GC compaction. -- https://bugs.ruby-lang.org/

2 1

[ruby-core:111915] [Ruby master Bug#15507] Thread#raise is delivered to GC context
by kjtsanaktsidis (KJ Tsanaktsidis) 19 Jan '23

19 Jan '23

Issue #15507 has been updated by kjtsanaktsidis (KJ Tsanaktsidis). ❤️ Thank you for fixing this @jeremyevans - I was debugging some instances of our Ruby 2.7 app's test suite hanging on exit, and narrowed it down to this reproduction: ``` require 'tempfile' def forget_about_a_tempfile Tempfile.new('garbage') end def tempfile_making_thread loop do forget_about_a_tempfile GC.start end end 10.times do Thread.new { tempfile_making_thread } end sleep 0.5 ``` I git bisect'd the fix to this commit. I guess the `eTerminateSignal` that kills threads on process exit has the same problem as an explicit `Thread#raise`. ---------------------------------------- Bug #15507: Thread#raise is delivered to GC context https://bugs.ruby-lang.org/issues/15507#change-101338 * Author: larskanis (Lars Kanis) * Status: Closed * Priority: Normal * ruby -v: ruby 2.6.0p0 (2018-12-25 revision 66547) [x86_64-linux] * Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN ---------------------------------------- Since I started the development of [Eventbox](https://github.com/larskanis/eventbox) I noticed sporadic failures of the Eventbox test suite on MRI. [One issue](https://github.com/larskanis/eventbox/issues/2) has been fixed in the meantime, but I was now able to minimize 3 others to a reproducible script. This is the first one: This script combines a GC finalizer with Thread#raise: ```ruby Thread.abort_on_exception = true class Finalizer def self.define ObjectSpace.define_finalizer(String.new, self.method(:gc)) end def self.gc(object_id) puts "gc #{object_id} #{caller[0]}" end end class Deadlocker class Stop < RuntimeError end def self.run th = Thread.handle_interrupt(Exception => :never) do Thread.new do begin Thread.handle_interrupt(Stop => :on_blocking) do 100.times { String.new } # Trigger GC sleep 5 # Wait for Stop exception raise "not interrupted" end rescue Stop end end end th.raise Stop th.join end end 100.times do Finalizer.define # This alone works well Deadlocker.run # This alone works equally, but both interfere badly end ``` The program output looks similar to: ```ruby $ ruby -d --disable-gems interrupt-in-gc-error.rb Exception `Deadlocker::Stop' at interrupt-in-gc-error.rb:23 - Deadlocker::Stop Exception `Deadlocker::Stop' at interrupt-in-gc-error.rb:23 - Deadlocker::Stop [...] Exception `Deadlocker::Stop' at interrupt-in-gc-error.rb:9 - Deadlocker::Stop gc 47133824012760 interrupt-in-gc-error.rb:22:in `call' gc 47133824022800 interrupt-in-gc-error.rb:22:in `call' [...] Exception `RuntimeError' at interrupt-in-gc-error.rb:24 - not interrupted #<Thread:0x000055bc65ac8f38@interrupt-in-gc-error.rb:19 run> terminated with exception (report_on_exception is true): Traceback (most recent call last): 2: from interrupt-in-gc-error.rb:21:in `block (2 levels) in run' 1: from interrupt-in-gc-error.rb:21:in `handle_interrupt' interrupt-in-gc-error.rb:24:in `block (3 levels) in run': not interrupted (RuntimeError) ``` The debug output shows, that the `Stop` exception is delivered several times, so that the sleep call is properly interrupted. But if the interrupt is sent just in the moment when the finalizer is active, it is discarded and doesn't abort the `sleep` call. IMHO interrupts shouldn't be delivered to any GC/trap context. At least they should be masked in this context. This issue is present on all older MRI versions. However it doesn't appear on JRuby-9.2.5.0. So they seem to have solved the GC/interrupt relationship somehow. -- https://bugs.ruby-lang.org/

1 0

[ruby-core:111912] [Ruby master Feature#19355] Add finer coarsed locking for searching callable method entries
by luke-gru (Luke Gruber) 19 Jan '23

19 Jan '23

Issue #19355 has been reported by luke-gru (Luke Gruber). ---------------------------------------- Feature #19355: Add finer coarsed locking for searching callable method entries https://bugs.ruby-lang.org/issues/19355 * Author: luke-gru (Luke Gruber) * Status: Open * Priority: Normal ---------------------------------------- During multi-ractor mode, unfortunately when calling methods often there's a call to the internal cruby function `callable_method_entry`, which returns a cached CME or a new one. In the case that it's cached, there's a VM lock around its access that could be reduced to a lock pertaining to the class of the caller of the method. This reduces locking in multi-ractor mode and allows, for example, object allocation to happen at the same time as method calls. -- https://bugs.ruby-lang.org/

1 1

[ruby-core:111913] [Ruby master Bug#18658] Need openssl 3 support for Ubuntu 22.04 (Ruby 2.7.x and 3.0.x)
by hsbt (Hiroshi SHIBATA) 19 Jan '23

19 Jan '23

Issue #18658 has been updated by hsbt (Hiroshi SHIBATA). Assignee changed from hsbt (Hiroshi SHIBATA) to usa (Usaku NAKAMURA) ---------------------------------------- Bug #18658: Need openssl 3 support for Ubuntu 22.04 (Ruby 2.7.x and 3.0.x) https://bugs.ruby-lang.org/issues/18658#change-101336 * Author: schneems (Richard Schneeman) * Status: Assigned * Priority: Normal * Assignee: usa (Usaku NAKAMURA) * ruby -v: 3.0 * Backport: 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN ---------------------------------------- Ubuntu 22.04 is being released soon and ships with openssl 3. As of now Ruby 2.7.x and 3.0.x are under core support and will not build on Ubuntu 22.04 with openssl (Ruby 3.1.x can compile). When attempting to compile 3.0.3 on Ubuntu 22 it issues this warning: ``` *** Following extensions are not compiled: openssl: Could not be configured. It will not be installed. /ruby-3.0.3/ext/openssl/extconf.rb:113: OpenSSL >= 1.0.1, < 3.0.0 or LibreSSL >= 2.5.0 is required Check ext/openssl/mkmf.log for more details. ``` Here are some existing issues/PRs that I could find: - https://github.com/ruby/openssl/issues/369 - https://github.com/ruby/openssl/pull/399 Ideally I would like to compile and support all non-EOL Ruby versions for Ubuntu 22 on release day. Are there any plans to backport support for OpenSSL 3 to Ruby 3.0 and 2.7? -- https://bugs.ruby-lang.org/

1 0

[ruby-core:111446] [Ruby master Misc#19265] please remove rust yjit
by darkspy (gerty ken) 19 Jan '23

19 Jan '23

Issue #19265 has been reported by darkspy (gerty ken). ---------------------------------------- Misc #19265: please remove rust yjit https://bugs.ruby-lang.org/issues/19265 * Author: darkspy (gerty ken) * Status: Open * Priority: Normal ---------------------------------------- my job is heavily ruby coding and following ruby new versions.(servers and business depend on ruby, like heavy java server clusters) my one part of job is compile and customizing ruby for use in company. it's works ok until 3.1.x but 3.2 changes yjit to rust. that means i need to learn new lang and download new toolchains to build ruby(still, it can ignoring build yjit), but we core team using yjit for monthes and can't handle code out of c/c++ especially rust. it's too ugly to acceptable(syntax and compile time, sorry to say that, but it's true for us) please consider our advices to remove rust code to c++(if u think c99 is hard to handle) or zig or any other faster lang, but no rust please. for now we just try to back port 3.1 yjit to 3.2 :( thanks, regards. Ken -- https://bugs.ruby-lang.org/

3 2

[ruby-core:111905] [Ruby master Feature#12698] Method to delete a substring by regex match
by sawa (Tsuyoshi Sawada) 19 Jan '23

19 Jan '23

Issue #12698 has been updated by sawa (Tsuyoshi Sawada). I now agree with https://bugs.ruby-lang.org/issues/12698#note-9. This issue can be considered to be along that line. ---------------------------------------- Feature #12698: Method to delete a substring by regex match https://bugs.ruby-lang.org/issues/12698#change-101326 * Author: sawa (Tsuyoshi Sawada) * Status: Feedback * Priority: Normal ---------------------------------------- There is frequent need to delete a substring from a string. There already are methods `String#delete` and `String#delete!`, but their feature is a little bit different from the use cases that I am mentioning here. I request methods that take a string or a regexp as an argument, and delete the matches from the receiver string. I am not sure of the method name, and I will use the term `remove` here. It can be named in some other better way. I request all combinations of global vs. local, and non-destructive vs. destructive. The expected feature is something like the following. First, the non-destructive ones: ```ruby "abcabc".remove("c") # => "ababc" "abcabc".remove(/\zc/) # => "abcab" "abcabc".gremove("c") # => "abab" "abcabc".gremove(/c/) # => "abab" ``` Then, the destructive ones: ```ruby s = "abcabc" s.remove!("c") # => "ababc" s # => "ababc" s = "abcabc" s.gremove!("d") # => nil s # => "abcabc" ``` Using this, cases like https://bugs.ruby-lang.org/issues/12694 would be just special cases. They can be handled like this: ```ruby "abcdef".remove(/\Aabc/) # => "def" -- https://bugs.ruby-lang.org/

1 0

[ruby-core:111674] [Ruby master Feature#19314] String#bytesplice should support partial copy
by shugo (Shugo Maeda) 19 Jan '23

19 Jan '23

Issue #19314 has been reported by shugo (Shugo Maeda). ---------------------------------------- Feature #19314: String#bytesplice should support partial copy https://bugs.ruby-lang.org/issues/19314 * Author: shugo (Shugo Maeda) * Status: Open * Priority: Normal ---------------------------------------- String#bytesplice should support partial copy without temporary String objects. For example, given `x = "0123456789"`, either of the following replaces the contents of `x` with `"0167856789"`: ```ruby x.bytesplice(2, 3, x, 6, 3) x.bytesplice(2..4, x, 6..8) ``` ## Considerations * What should be the return value? * The return value should be the whole source string for performance and consistency with `bytesplice(offset, len, s)`. * Can the source and destination ranges overlap? * Yes. * Can the source and destination lengths be different? * Yes. * Can range form and offset/length form be mixed in the source and destination? * No. * What should happen when any offset doesn't land on character boundary in text strings. * IndexError should be raised. * Can the length be omitted in the destination? * Maybe yes, but it may be confusing. ## Use cases * [Gapped buffer implementation for text editors](https://github.com/shugo/textbringer) * [NAT implementation](https://github.com/kazuho/rat) * https://twitter.com/kazuho/status/1611279616098070532 -- https://bugs.ruby-lang.org/

4 7

[ruby-core:111903] [Ruby master Feature#13890] Allow a regexp as an argument to 'count', to count more interesting things than single characters
by sawa (Tsuyoshi Sawada) 19 Jan '23

19 Jan '23

Issue #13890 has been updated by sawa (Tsuyoshi Sawada). Can't overlapping be realized by putting the overlapping part within a look-ahead? Is there a use case where it cannot? ---------------------------------------- Feature #13890: Allow a regexp as an argument to 'count', to count more interesting things than single characters https://bugs.ruby-lang.org/issues/13890#change-101324 * Author: duerst (Martin Dürst) * Status: Open * Priority: Normal ---------------------------------------- Currently, String#count only accepts strings, and counts all the characters in the string. However, I have repeatedly met the situation where I wanted to count more interesting things in strings. These 'interesting things' can easily be expressed with regular expressions. Here is a quick-and-dirty Ruby-level implementation: ````Ruby class String alias old_count count def count (what) case what when String old_count what when Regexp pos = -1 count = 0 count += 1 while pos = index(what, pos+1) count end end end ```` Please note that the implementation counts overlapping occurrences; maybe there is room for an option like `overlap: :no`. -- https://bugs.ruby-lang.org/

1 0

[ruby-core:111897] [Ruby master Feature#13890] Allow a regexp as an argument to 'count', to count more interesting things than single characters
by matz (Yukihiro Matsumoto) 19 Jan '23

19 Jan '23

Issue #13890 has been updated by matz (Yukihiro Matsumoto). If `str.count(re)` works as `str.scan(re).size` (besides efficiency), it's acceptable. But if someone needs overlapping, they needs to explain their use-case. Matz. ---------------------------------------- Feature #13890: Allow a regexp as an argument to 'count', to count more interesting things than single characters https://bugs.ruby-lang.org/issues/13890#change-101315 * Author: duerst (Martin Dürst) * Status: Open * Priority: Normal ---------------------------------------- Currently, String#count only accepts strings, and counts all the characters in the string. However, I have repeatedly met the situation where I wanted to count more interesting things in strings. These 'interesting things' can easily be expressed with regular expressions. Here is a quick-and-dirty Ruby-level implementation: ````Ruby class String alias old_count count def count (what) case what when String old_count what when Regexp pos = -1 count = 0 count += 1 while pos = index(what, pos+1) count end end end ```` Please note that the implementation counts overlapping occurrences; maybe there is room for an option like `overlap: :no`. -- https://bugs.ruby-lang.org/

1 0