- ruby-core - ml.ruby-lang.org

[ruby-core:111498] [Ruby master Bug#18743] Enumerator#next / peek re-use each others stacktraces
by marcper (Marcelo Pereira) 29 Dec '22

29 Dec '22

Issue #18743 has been updated by marcper (Marcelo Pereira). Good evening, @matz. The PR with the bug fix is available now for a few months. Please advise on the next steps. ---------------------------------------- Bug #18743: Enumerator#next / peek re-use each others stacktraces https://bugs.ruby-lang.org/issues/18743#change-100867 * Author: sos4nt (Stefan Schüßler) * Status: Open * Priority: Normal * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN ---------------------------------------- I encountered an odd behavior. If I rescue the `StopIteration` exception from `peek` and call `next` afterwards: (or vice-versa) ```ruby # enum.rb # 1 # 2 enum = [].each # 3 enum.peek rescue nil # 4 enum.next # 5 ``` it will show the stacktrace from the rescued `peek` call: ``` $ ruby enum.rb enum.rb:4:in `peek': iteration reached an end (StopIteration) from enum.rb:4:in `<main>' ``` Whereas the error should refer to `next` on line number 5. The same happens when calling `peek` after `next` or when having muliple `peek` / `next` calls: ```ruby # enum.rb # 1 # 2 enum = [].each # 3 enum.peek rescue nil # 4 enum.next rescue nil # 5 enum.peek rescue nil # 6 puts "line #{__LINE__}" # 7 enum.next # 8 ``` The stacktrace from the first (rescued) `peek` or `next` call will be shown which doesn't reflect the actual error location: ``` $ ruby enum.rb line 7 enum.rb:4:in `peek': iteration reached an end (StopIteration) from enum.rb:4:in `<main>' ``` This is very confusing when debugging code. ---Files-------------------------------- 01-Recreate-stacktrace-enumerator.patch (1.29 KB) -- https://bugs.ruby-lang.org/

1 0

[ruby-core:111482] [Ruby master Feature#19277] Project-scoped refinements
by georgeclaghorn (George Claghorn) 28 Dec '22

28 Dec '22

Issue #19277 has been reported by georgeclaghorn (George Claghorn). ---------------------------------------- Feature #19277: Project-scoped refinements https://bugs.ruby-lang.org/issues/19277 * Author: georgeclaghorn (George Claghorn) * Status: Open * Priority: Normal ---------------------------------------- Refinements are a great way to isolate patches to the files that rely on them. Nonetheless, I believe the need to explicitly enable refinements in every file that uses them has hindered their adoption. As an inciting example, it’s hard to imagine Rails adopting refinements in their current form and requiring `using` calls for Active Support core extensions throughout Rails applications. I’d like to propose a middle way: allowing a Ruby project (a gem, library, application, etc.) to enable refinements for all of its Ruby files. This would combine the isolation benefits of refinements with the convenience of global monkey-patches. #### Projects To do this, we must decide how to identify projects and how they specify their desired refinements. A Ruby project is a directory containing a project configuration file with a special name. (I am intentionally not proposing a specific name for the file here. One will need to be chosen eventually, and suggestions are welcome.) A project configuration file is in Ruby format. When Ruby loads a script from a file, it searches upwards from the current directory for a project configuration file. For reasons of performance, project configurations may be cached by project root path. The search for a project configuration would end when a configuration for a particular path prefix is found in the cache. When a project configuration is found, it is evaluated as though it were prepended to the beginning of the currently-loading file. Alternatively, a limited DSL could be provided to the configuration file that prepares interpreter state for the currently-loading file. Below is an example project configuration: ```ruby require "prestige/refinements" using Prestige::Refinements ``` For `ruby -e` and `irb`, the project configuration is searched for beginning from the current working directory. For `Kernel#eval`, the current file’s project configuration is used. #### Concerns * Performance, mainly. This is a significant amount of work to add to hot code paths. I believe the cost could be minimized with sensible caching, though not completely eliminated. I haven’t started implementing this and don’t have measurements of the actual cost yet. * Ergonomics. Is this the best way to provide project-scoped refinements? Is the project configuration format appropriate? -- https://bugs.ruby-lang.org/

2 2

[ruby-core:111481] [Ruby master Bug#18797] Third argument to Regexp.new is a bit broken
by jeremyevans0 (Jeremy Evans) 28 Dec '22

28 Dec '22

Issue #18797 has been updated by jeremyevans0 (Jeremy Evans). Status changed from Closed to Open Pull request submitted to remove support for the 3rd argument: https://github.com/ruby/ruby/pull/7039 ---------------------------------------- Bug #18797: Third argument to Regexp.new is a bit broken https://bugs.ruby-lang.org/issues/18797#change-100850 * Author: janosch-x (Janosch Müller) * Status: Open * Priority: Normal * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN ---------------------------------------- ## Situation 'n' or 'N' can be passed as a third argument to `Regexp.new`. However, the behavior is not the same as the literal `n`-flag or the `Regexp::NOENCODING` option, and it makes the `#encoding` of `Regexp` and `Regexp#source` diverge: ```ruby /😅/n # => SyntaxError Regexp.new('😅', Regexp::NOENCODING) # => RegexpError re = Regexp.new('😅', nil, 'n') # => /😅/ re.options == Regexp::NOENCODING # => true re.encoding # => ASCII-8BIT re.source.encoding # => UTF-8 re =~ '😅' # => Encoding::CompatibilityError ``` ## Code [Here](https://github.com/ruby/ruby/blob/b41de3a1e8c36a5cc336b6f7cd3cb71126c…. There is also a test for the resulting encoding [here](https://github.com/ruby/ruby/blob/cf2bbcfff2985c116552967c7c4522f4630…, but it is a no-op because the whole file is set to that encoding via magic comment anyway. The third argument was added when ASCII was still the default Ruby encoding, so I guess Regexp and source encoding still matched at that point. ## Solution It could be fixed, but my impression is that it is not useful anymore. It was probably only added because `Regexp::NOENCODING` wasn't available at the time, so I think it could be deprecated like so: > Passing a third argument to Regexp.new is deprecated. Use `Regexp::NOENCODING` as second argument instead. -- https://bugs.ruby-lang.org/

1 0

[ruby-core:111472] [Ruby master Bug#19274] Error installing ruby 3.2.0 on RH 8
by aalllop (Alberto Allegue) 28 Dec '22

28 Dec '22

Issue #19274 has been reported by aalllop (Alberto Allegue). ---------------------------------------- Bug #19274: Error installing ruby 3.2.0 on RH 8 https://bugs.ruby-lang.org/issues/19274 * Author: aalllop (Alberto Allegue) * Status: Open * Priority: Normal * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- When I execute rvm install 3.2.0 the installation fails with the next error: installing default gems from lib: /var/lib/jenkins/.rvm/rubies/ruby-3.2.0-rc1/lib/ruby/gems/3.2.0+3 abbrev 0.1.0 base64 0.1.1 benchmark 0.2.1 bundler 2.4.0.dev <internal:/var/lib/jenkins/.rvm/src/ruby-3.2.0-rc1/lib/rubygems/core_ext/kernel_require.rb>:85:in `require': cannot load such file -- psych (LoadError) from <internal:/var/lib/jenkins/.rvm/src/ruby-3.2.0-rc1/lib/rubygems/core_ext/kernel_require.rb>:85:in `require' from /var/lib/jenkins/.rvm/src/ruby-3.2.0-rc1/lib/rubygems.rb:610:in `load_yaml' from /var/lib/jenkins/.rvm/src/ruby-3.2.0-rc1/lib/rubygems/config_file.rb:346:in `load_file' from /var/lib/jenkins/.rvm/src/ruby-3.2.0-rc1/lib/rubygems/config_file.rb:189:in `initialize' from /var/lib/jenkins/.rvm/src/ruby-3.2.0-rc1/lib/rubygems.rb:331:in `new' from /var/lib/jenkins/.rvm/src/ruby-3.2.0-rc1/lib/rubygems.rb:331:in `configuration' from /var/lib/jenkins/.rvm/src/ruby-3.2.0-rc1/lib/rubygems/user_interaction.rb:167:in `verbose' from /var/lib/jenkins/.rvm/src/ruby-3.2.0-rc1/lib/rubygems/installer.rb:544:in `generate_bin_script' from ./tool/rbinstall.rb:891:in `generate_bin_script' from ./tool/rbinstall.rb:855:in `generate_bin_script' from /var/lib/jenkins/.rvm/src/ruby-3.2.0-rc1/lib/rubygems/installer.rb:506:in `block in generate_bin' from /var/lib/jenkins/.rvm/src/ruby-3.2.0-rc1/lib/rubygems/installer.rb:490:in `each' from /var/lib/jenkins/.rvm/src/ruby-3.2.0-rc1/lib/rubygems/installer.rb:490:in `generate_bin' from /var/lib/jenkins/.rvm/src/ruby-3.2.0-rc1/lib/rubygems/installer.rb:331:in `install' from ./tool/rbinstall.rb:881:in `block in install' from ./tool/rbinstall.rb:721:in `no_write' from ./tool/rbinstall.rb:881:in `install' from ./tool/rbinstall.rb:989:in `block in install_default_gem' from ./tool/rbinstall.rb:976:in `each' from ./tool/rbinstall.rb:976:in `install_default_gem' from ./tool/rbinstall.rb:913:in `block in <main>' from ./tool/rbinstall.rb:1077:in `block in <main>' from ./tool/rbinstall.rb:1074:in `each' from ./tool/rbinstall.rb:1074:in `<main>' make: *** [uncommon.mk:415: do-install-nodoc] Error 1 ++ return 2 -- https://bugs.ruby-lang.org/

4 4

[ruby-core:111449] [Ruby master Bug#19267] Compile fails when enabling YJIT on x64-mingw-ucrt
by cfis (Charlie Savage) 27 Dec '22

27 Dec '22

Issue #19267 has been reported by cfis (Charlie Savage). ---------------------------------------- Bug #19267: Compile fails when enabling YJIT on x64-mingw-ucrt https://bugs.ruby-lang.org/issues/19267 * Author: cfis (Charlie Savage) * Status: Open * Priority: Normal * ruby -v: ruby 3.1.3p185 (2022-11-24 revision 1a6b16756e) [x64-mingw-ucrt] * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- Ruby fails to compile with msys2/ucrt64 when enabling yjit. Error: ``` c In file included from ./include/ruby/defines.h:72, from ./include/ruby/ruby.h:25, from eval_intern.h:4, from vm.c:13: vm.c: In function 'mjit_check_iseq': vm.c:393:12: warning: implicit declaration of function 'MJIT_FUNC_STATE_P' [-Wimplicit-function-declaration] 393 | ASSUME(MJIT_FUNC_STATE_P(mjit_state)); | ^~~~~~~~~~~~~~~~~ ./include/ruby/backward/2/assume.h:43:46: note: in definition of macro 'RB_LIKELY' 43 | # define RB_LIKELY(x) (__builtin_expect(!!(x), 1)) | ^ ./include/ruby/backward/2/assume.h:27:28: note: in expansion of macro 'RBIMPL_ASSUME' 27 | #define ASSUME RBIMPL_ASSUME /**< @old{RBIMPL_ASSUME} */ | ^~~~~~~~~~~~~ vm.c:393:5: note: in expansion of macro 'ASSUME' 393 | ASSUME(MJIT_FUNC_STATE_P(mjit_state)); | ^~~~~~ vm.c:394:19: error: conversion to incomplete type 394 | switch ((enum rb_mjit_func_state)mjit_state) { | ^~~~~~~~~~~~~~~~~~ vm.c:395:12: error: 'MJIT_FUNC_NOT_COMPILED' undeclared (first use in this function) 395 | case MJIT_FUNC_NOT_COMPILED: ``` The problem: In ruby-3.2.0\.ext\include\x64-mingw-ucrt\ruby\config.h ``` c #define USE_MJIT 0 #define USE_YJIT 1 ``` But in mjit.h: ``` c # if USE_MJIT ... // Return true if jit_func is part of enum rb_mjit_func_state #define MJIT_FUNC_STATE_P(jit_func) ((uintptr_t)(jit_func) <= (uintptr_t)MJIT_FUNC_FAILED) ... # end ``` So MJIT_FUNC_STATE_P is never defined. Then in vm.c: ``` c #if USE_MJIT || USE_YJIT # ifdef MJIT_HEADER NOINLINE(static COLDFUNC VALUE mjit_check_iseq(rb_execution_context_t *ec, const rb_iseq_t *iseq, struct rb_iseq_constant_body *body)); # else static inline VALUE mjit_check_iseq(rb_execution_context_t *ec, const rb_iseq_t *iseq, struct rb_iseq_constant_body *body); # endif static VALUE mjit_check_iseq(rb_execution_context_t *ec, const rb_iseq_t *iseq, struct rb_iseq_constant_body *body) { uintptr_t mjit_state = (uintptr_t)(body->jit_func); ASSUME(MJIT_FUNC_STATE_P(mjit_state)); etc ``` Note that MJIT_HEADER is not defined. Note this is just the first of many errors that you will encounter. To get Ruby 3.2.0 to compile, I had to do a significant rearrangement of mjit.h which I have attached. However, when yjit.c then compiles: ``` c yjit.c: In function 'rb_yjit_mark_unused': yjit.c:93:5: warning: implicit declaration of function 'madvise'; did you mean 'raise'? [-Wimplicit-function-declaratio ] 93 | madvise(mem_block, mem_size, MADV_DONTNEED); | ^~~~~~~ | raise yjit.c:93:34: error: 'MADV_DONTNEED' undeclared (first use in this function) 93 | madvise(mem_block, mem_size, MADV_DONTNEED); ``` This is because the check in yjit.c (line 32) is: ``` c // For mmapp(), sysconf() #if defined _WIN32 #include <unistd.h> #include <sys/mman.h> #endif ``` UCRT doesn't define _WIN32, it defines _WIN64 However, then the next issue - there is no sys/mman.h header with mingw. So enabling yjit on mingw breaks the compile and is apparently unsupported. ---Files-------------------------------- mjit.h (5.71 KB) -- https://bugs.ruby-lang.org/

2 2

[ruby-core:111459] [Ruby master Bug#18240] Random segfault on a local Rails server
by Benoit_Tigeot (Benoit Tigeot) 27 Dec '22

27 Dec '22

Issue #18240 has been updated by Benoit_Tigeot (Benoit Tigeot). Hello Olivier ---------------------------------------- Bug #18240: Random segfault on a local Rails server https://bugs.ruby-lang.org/issues/18240#change-100828 * Author: Benoit_Tigeot (Benoit Tigeot) * Status: Closed * Priority: Normal * ruby -v: 3.0.2 * Backport: 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN ---------------------------------------- Hello I am having random segfault locally when rails a basic rails app. The control frame is weird: | -- Control frame information ----------------------------------------------- web | c:0073 p:---- s:0470 e:000469 CFUNC :append_features web | c:0072 p:---- s:0467 e:000466 CFUNC :include ---Files-------------------------------- Untitled.txt (724 KB) -- https://bugs.ruby-lang.org/

1 0

[ruby-core:111458] [Ruby master Bug#18240] Random segfault on a local Rails server
by Benoit_Tigeot (Benoit Tigeot) 27 Dec '22

27 Dec '22

Issue #18240 has been updated by Benoit_Tigeot (Benoit Tigeot). EDIT ---------------------------------------- Bug #18240: Random segfault on a local Rails server https://bugs.ruby-lang.org/issues/18240#change-100827 * Author: Benoit_Tigeot (Benoit Tigeot) * Status: Closed * Priority: Normal * ruby -v: 3.0.2 * Backport: 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN ---------------------------------------- Hello I am having random segfault locally when rails a basic rails app. The control frame is weird: | -- Control frame information ----------------------------------------------- web | c:0073 p:---- s:0470 e:000469 CFUNC :append_features web | c:0072 p:---- s:0467 e:000466 CFUNC :include ---Files-------------------------------- Untitled.txt (724 KB) -- https://bugs.ruby-lang.org/

1 0

[ruby-core:111454] test message
by Koichi Sasada 27 Dec '22

27 Dec '22

This message is a test mail.

1 0

[ruby-core:111431] [Ruby master Bug#19259] `Data#with` doesn't call `initialize` nor `initialize_copy`
by ko1 (Koichi Sasada) 26 Dec '22

26 Dec '22

Issue #19259 has been reported by ko1 (Koichi Sasada). ---------------------------------------- Bug #19259: `Data#with` doesn't call `initialize` nor `initialize_copy` https://bugs.ruby-lang.org/issues/19259 * Author: ko1 (Koichi Sasada) * Status: Open * Priority: Normal * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN ---------------------------------------- Data#with` doesn't call `initialize` nor `initialize_copy`. It is confirmation request. ```ruby class P < Data.define(:x, :y) def initialize_copy(...) p :initialize_copy super end def initialize(...) p :initialize super end end p pt = P.new(1, 2) #=> :initialize p pt.clone #=> :initialize_copy p pt.dup #=> :initialize_copy p pt.with(x: 10) #=> N/A ``` For example, if an author of `P` add validation code, `#with` skips it. -- https://bugs.ruby-lang.org/

5 5

[ruby-core:111436] [Ruby master Misc#18975] Propose Stan Lo (@st0012) as an IRB maintainer
by k0kubun (Takashi Kokubun) 25 Dec '22

25 Dec '22

Issue #18975 has been updated by k0kubun (Takashi Kokubun). Status changed from Feedback to Closed We discussed this again in the DevMeeting-2022-12-15. We agreed to make the following changes after the Ruby 3.2 release. Now that Ruby 3.2 is released, I'm publishing this update and making permission changes on the IRB repository. ### Ruby 3.2 This year, Reline and IRB have been maintained as follows: * reline * Maintenance (git push only): ima1zumi, hasumikin * Release: hsbt * irb * No maintainers. Any committers merge bug fixes. * For features like adding commands, Stan and I can review each other’s PR and merge it. * Release: k0kubun or hsbt ### Ruby 3.3 We agreed to make the following changes from the Ruby 3.3 development. * reline * Maintenance **+ Release**: ima1zumi, hasumikin * irb * **Make Stan, ima1zumi, and hasumikin the new IRB maintainers.** * New features can be merged if those three maintainers agree on it. * The maintainers will get GitHub write access on ruby/irb. * Release: k0kubun or hsbt will continue to do it at first, but revisit this later. Looking forward to making IRB and Reline better with you all :) ---------------------------------------- Misc #18975: Propose Stan Lo (@st0012) as an IRB maintainer https://bugs.ruby-lang.org/issues/18975#change-100805 * Author: k0kubun (Takashi Kokubun) * Status: Closed * Priority: Normal ---------------------------------------- ## Background Looking at @aycabta 's GitHub activity, he's been inactive on the Internet for 6~7 months, which means that IRB hasn't had the maintainer during that period of time. While I managed to sneak in some IRB changes when he was active, I personally have some more IRB changes that I want to make, but I'm not sure if we're gonna make it to Ruby 3.2 since we can't predict when he'll be back and there's nobody taking the ownership of the IRB design now. However, I don't think the 2nd most active contributor (@nobu) is particularly interested in IRB, and the 3rd most active contributor (myself) currently doesn't have capacity to maintain anything new. So having a temporary maintainer from existing committers could also be hard. ## Proposal I propose to make Stan Lo (@st0012) a new committer and a co-maintainer of IRB. He's best known for being almost as active as @ko1 in [recent debug.gem development](https://github.com/ruby/debug/commits?author=st0012) and I think he deserves maintainership in the Ruby's debug tooling area in general. While he has fewer contributions to IRB, some modules of IRB (which I authored, so I should have a say) are used by debug.gem, so I believe IRB being maintained by him will also be useful for the success of debug.gem and Ruby 3 tooling. -- https://bugs.ruby-lang.org/

1 0