- ruby-core - ml.ruby-lang.org

[ruby-core:113061] [Ruby master Feature#19565] Ignore lower-case/upper-case Proposal
by rubyFeedback (robert heiler) 01 Apr '23

01 Apr '23

Issue #19565 has been reported by rubyFeedback (robert heiler). ---------------------------------------- Feature #19565: Ignore lower-case/upper-case Proposal https://bugs.ruby-lang.org/issues/19565 * Author: rubyFeedback (robert heiler) * Status: Open * Priority: Normal ---------------------------------------- So, first april is on the horizon and in-before-we-go (nobu tends to make quick first april proposals, so let's hurry up!) It is here proposed to ignore case, that is, lower-case, and upper-case, at the least for method calls. This could be for variables too, but I don't care so much about variables. Rationale for the proposal: Given a method such as primary_link I typoed and wrote: primary_LINK Of course ruby complains and insists it must be written "primary_link". (I use that method for ad-hoc HTML hyperreferences in a webpage.) Wouldn't it be nice if we are able to ignore this, and simply assume that, at the least for method names, ruby would ignore the case, that is, whether it is downcased/lowercased or upper cased? Granted, the proposal is about 85% meant as a jest and joke, but the 15% is that this MAY be useful in SOME situations. Kind of like we had in oldschool evil.rb; I distinctly remember we could even change object identities at runtime too (I don't know what happened to evil.rb, but I distinctly remember we had it during the ruby 1.8.x era or so). I actually only propose this to be used on a per-file basis, to simplify it. So, for instance, you have a .rb file, and in that .rb file you need to tell ruby that you want to ignore the case. This could perhaps be via some configuration-call, such as: RbConfig.ignore_case Or something similar. Or more similar to IRB where we treat RbConfig as a Hash via [] e. g. RbConfig[:ignore_case] = true Or something similar like that. Right now there is no method defined on RbConfig, so this should not cause backwards incompatibility issues. Of course one can reason that this is 100% a rubbish proposal. That's ok. Easier to suggest it when it is close to the first april. :) PHP works like this if I recall correctly. Windows also ignores cases of e. g. binaries and directories if I recall correctly. So while this proposal may be rubbish, and as stated more of a joke, I believe there may be a few potential use cases of this too. Kind of like the ruby user telling ruby "ruby, I know by default you look at the case of characters, but for this specific file or project, I want you to ignore the case". (We could extend this to a whole namespace, e. g. per-module and per-class, but for this proposal I want to keep it simpler and just focus on a per-file basis, that is, on a per .rb basis. We could also add more magic comments such as it was with "# frozen_string_literal: true", but I think the ruby core team does not want to add more meta-meaning, so this probably would have zero chance to be implemented. So the focus on a per .rb file basis just seemed simpler to me for this proposal here.) -- https://bugs.ruby-lang.org/

2 1

[ruby-core:113032] [Ruby master Bug#19554] Invalid memory access detected by Valgrind when using Fibers
by peterzhu2118 (Peter Zhu) 30 Mar '23

30 Mar '23

Issue #19554 has been reported by peterzhu2118 (Peter Zhu). ---------------------------------------- Bug #19554: Invalid memory access detected by Valgrind when using Fibers https://bugs.ruby-lang.org/issues/19554 * Author: peterzhu2118 (Peter Zhu) * Status: Open * Priority: Normal * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- This issue was originally reported here: https://github.com/Shopify/ruby_memcheck/issues/14 Running the script shown below using `valgrind --trace-children=yes --num-callers=500 ruby test.rb` outputs a lot of invalid memory access errors. I've shown a few sample errors below. I am able to reproduce this issue on the master branch (commit [1e9a218ade](https://github.com/ruby/ruby/commit/1e9a218ade3af90c18f42e3fea0…) 3.2, 3.1, 3.0. ```ruby require "bundler/inline" gemfile do source "https://rubygems.org" gem "graphql" end module Example class FooType < GraphQL::Schema::Object field :id, ID, null: false end class FooSource < GraphQL::Dataloader::Source def fetch(ids) ids end end class QueryType < GraphQL::Schema::Object field :foo, Example::FooType do argument :foo_id, GraphQL::Types::ID, required: false, loads: Example::FooType end def foo(foo: nil); end end class Schema < GraphQL::Schema query Example::QueryType use GraphQL::Dataloader def self.object_from_id(id, ctx) ctx.dataloader.with(Example::FooSource).request(id) end end end Example::Schema.execute(<<-GRAPHQL) { foo(fooId: "Other") { id } } GRAPHQL ``` ``` ==203957== Use of uninitialised value of size 8 ==203957== at 0x3453FD: vm_exec_core (vm.inc:4411) ==203957== by 0x357EFB: rb_vm_exec (vm.c:2366) ==203957== by 0x354E44: invoke_block (vm.c:1384) ==203957== by 0x355759: invoke_iseq_block_from_c (vm.c:1440) ==203957== by 0x355759: invoke_block_from_c_proc (vm.c:1538) ==203957== by 0x355759: vm_invoke_proc (vm.c:1568) ==203957== by 0x355DF4: rb_vm_invoke_proc (vm.c:1589) ==203957== by 0x48F695: rb_fiber_start (cont.c:2513) ==203957== by 0x48CCF8: fiber_entry (cont.c:831) ==203957== ==203957== Invalid write of size 8 ==203957== at 0x48C407: fiber_pool_stack_reset (cont.c:325) ==203957== by 0x48C4E9: fiber_pool_vacancy_reset (cont.c:364) ==203957== by 0x48CBB0: fiber_pool_stack_release (cont.c:752) ==203957== by 0x48CECF: fiber_stack_release (cont.c:874) ==203957== by 0x48FC9F: fiber_switch (cont.c:2726) ==203957== by 0x4901F9: fiber_resume_kw (cont.c:2906) ==203957== by 0x490235: rb_fiber_resume_kw (cont.c:2912) ==203957== by 0x4903B7: rb_fiber_m_resume (cont.c:2973) ==203957== by 0x3337D6: ractor_safe_call_cfunc_m1 (vm_insnhelper.c:3166) ==203957== by 0x33440A: vm_call_cfunc_with_frame_ (vm_insnhelper.c:3357) ==203957== by 0x3345E1: vm_call_cfunc_with_frame (vm_insnhelper.c:3385) ==203957== by 0x3398E5: vm_sendish (vm_insnhelper.c:5225) ==203957== by 0x341203: vm_exec_core (insns.def:835) ==203957== by 0x357EFB: rb_vm_exec (vm.c:2366) ==203957== by 0x354E44: invoke_block (vm.c:1384) ==203957== by 0x355759: invoke_iseq_block_from_c (vm.c:1440) ==203957== by 0x355759: invoke_block_from_c_proc (vm.c:1538) ==203957== by 0x355759: vm_invoke_proc (vm.c:1568) ==203957== by 0x355DF4: rb_vm_invoke_proc (vm.c:1589) ==203957== by 0x48F695: rb_fiber_start (cont.c:2513) ==203957== by 0x48CCF8: fiber_entry (cont.c:831) ==203957== Address 0x9bad008 is in a rw- anonymous segment ``` -- https://bugs.ruby-lang.org/

3 5

[ruby-core:113041] [Ruby master Bug#19558] str.dump.undump crashes when str contains both Unicode and ASCII control characters
by ikaronen-relex (Ilmari Karonen) 30 Mar '23

30 Mar '23

Issue #19558 has been reported by ikaronen-relex (Ilmari Karonen). ---------------------------------------- Bug #19558: str.dump.undump crashes when str contains both Unicode and ASCII control characters https://bugs.ruby-lang.org/issues/19558 * Author: ikaronen-relex (Ilmari Karonen) * Status: Open * Priority: Normal * ruby -v: ruby 3.3.0dev (2023-03-29T10:20:29Z master 02ecdf85c5) [x86_64-darwin21] * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- Recently, as a result of a question I asked on Stack Overflow (https://stackoverflow.com/q/75866159) I learned about the existence of String#dump and String#undump. However, I also found what seems like a bug in them, in that apparently dumping and then undumping a string containing a sufficiently diverse selection of characters (such as at least one ASCII C0 control character and at least one non-ASCII Unicode character) causes the undump to raise a RuntimeError. Specifically, evaluating e.g. any of the following expressions: "\u0000\uFFFF".dump.undump "\u0001\uABCD".dump.undump "\u007F\u0080".dump.undump raises a RuntimeError with the message "hex escape and Unicode escape are mixed". This contradicts the documentation of String#undump, which says that it "does the inverse of String#dump." The behavior is the same on all Ruby versions I have tested this on, including master (3.3.0), 2.6.10 and JRuby 9.3.10.0. The obvious fix would be to simply remove the check for mixed hex and Unicode escape sequences, essentially reverting https://github.com/ruby/ruby/commit/05d1d29d1f4a87620371463d8c7942e170be031f. However, as I don't understand why the check is there in the first place, I'm also not sure if removing it could somehow have some unwanted consequences. -- https://bugs.ruby-lang.org/

2 1

[ruby-core:113016] [Ruby master Bug#19547] `RubyVM::AST.parse("\\", keep_tokens: true)` dumps core
by mame (Yusuke Endoh) 30 Mar '23

30 Mar '23

Issue #19547 has been reported by mame (Yusuke Endoh). ---------------------------------------- Bug #19547: `RubyVM::AST.parse("\\", keep_tokens: true)` dumps core https://bugs.ruby-lang.org/issues/19547 * Author: mame (Yusuke Endoh) * Status: Assigned * Priority: Normal * Assignee: yui-knk (Kaneko Yuichiro) * ruby -v: ruby 3.3.0dev (2023-03-25T08:17:05Z master 9bc2dbd33c) [x86_64-linux] * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- ``` $ ./miniruby -e 'RubyVM::AbstractSyntaxTree.parse("\\", keep_tokens: true)' <internal:ast>:59: [BUG] parser_token2id: unknown token 92 ruby 3.3.0dev (2023-03-25T08:17:05Z master 9bc2dbd33c) [x86_64-linux] -- Control frame information ----------------------------------------------- c:0003 p:0003 s:0015 e:000014 METHOD <internal:ast>:59 c:0002 p:0008 s:0006 e:000005 EVAL -e:1 [FINISH] c:0001 p:0000 s:0003 E:001db0 DUMMY [FINISH] -- Ruby level backtrace information ---------------------------------------- -e:1:in `<main>' <internal:ast>:59:in `parse' -- Threading information --------------------------------------------------- Total ractor count: 1 Ruby thread count for this ractor: 1 -- C level backtrace information ------------------------------------------- /home/mame/work/ruby/miniruby(rb_print_backtrace+0xd) [0x55ee562be9be] /home/mame/work/ruby/vm_dump.c:785 /home/mame/work/ruby/miniruby(rb_vm_bugreport) /home/mame/work/ruby/vm_dump.c:1101 /home/mame/work/ruby/miniruby(bug_report_end+0x0) [0x55ee560ab94f] /home/mame/work/ruby/error.c:790 /home/mame/work/ruby/miniruby(rb_bug_without_die) /home/mame/work/ruby/error.c:790 /home/mame/work/ruby/miniruby(die+0x0) [0x55ee560092a1] /home/mame/work/ruby/error.c:798 /home/mame/work/ruby/miniruby(rb_bug) /home/mame/work/ruby/error.c:800 /home/mame/work/ruby/miniruby(rb_long2int_inline+0x0) [0x55ee5600a925] /home/mame/work/ruby/parse.y:630 /home/mame/work/ruby/miniruby(add_delayed_token) /home/mame/work/ruby/parse.y:7008 /home/mame/work/ruby/miniruby(add_delayed_token) /home/mame/work/ruby/parse.y:6997 /home/mame/work/ruby/miniruby(parser_dispatch_scan_event+0x25) [0x55ee56174855] /home/mame/work/ruby/parse.y:6222 /home/mame/work/ruby/miniruby(parser_dispatch_scan_event) /home/mame/work/ruby/parse.y:6212 /home/mame/work/ruby/miniruby(yylex+0xf) [0x55ee56184173] /home/mame/work/ruby/parse.y:10492 /home/mame/work/ruby/miniruby(ruby_yyparse) /home/mame/work/ruby/parse.c:9357 /home/mame/work/ruby/miniruby(yycompile0+0xf9) [0x55ee561954c9] /home/mame/work/ruby/parse.y:6767 /home/mame/work/ruby/miniruby(rb_suppress_tracing+0x10c) [0x55ee562c369c] /home/mame/work/ruby/vm_trace.c:483 /home/mame/work/ruby/miniruby(yycompile+0x55) [0x55ee5617b76c] /home/mame/work/ruby/parse.y:6824 /home/mame/work/ruby/miniruby(parser_compile_string) /home/mame/work/ruby/parse.y:6892 /home/mame/work/ruby/miniruby(rb_parser_compile_string_path) /home/mame/work/ruby/parse.y:6905 /home/mame/work/ruby/miniruby(ast_parse_done+0x0) [0x55ee560279a8] /home/mame/work/ruby/ast.c:103 /home/mame/work/ruby/miniruby(rb_ast_parse_str) /home/mame/work/ruby/ast.c:104 /home/mame/work/ruby/miniruby(ast_s_parse) /home/mame/work/ruby/ast.c:90 /home/mame/work/ruby/miniruby(invoke_bf+0x12) [0x55ee562ae7fe] /home/mame/work/ruby/vm_insnhelper.c:6414 /home/mame/work/ruby/miniruby(vm_invoke_builtin_delegate) /home/mame/work/ruby/vm_insnhelper.c:6441 /home/mame/work/ruby/miniruby(vm_exec_core) /home/mame/work/ruby/insns.def:1526 /home/mame/work/ruby/miniruby(rb_vm_exec+0x938) [0x55ee562a14e8] /home/mame/work/ruby/vm.c:2366 /home/mame/work/ruby/miniruby(rb_ec_exec_node+0xb1) [0x55ee560b0ff1] /home/mame/work/ruby/eval.c:287 /home/mame/work/ruby/miniruby(ruby_run_node+0x4c) [0x55ee560b634c] /home/mame/work/ruby/eval.c:328 /home/mame/work/ruby/miniruby(rb_main+0x21) [0x55ee560126c6] ./main.c:39 /home/mame/work/ruby/miniruby(main) ./main.c:58 /lib/x86_64-linux-gnu/libc.so.6(__libc_start_call_main+0x80) [0x7fdc30c23510] ../sysdeps/nptl/libc_start_call_main.h:58 /lib/x86_64-linux-gnu/libc.so.6(call_init+0x0) [0x7fdc30c235c9] ../csu/libc-start.c:381 /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main_impl) ../csu/libc-start.c:368 /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main) (null):0 [0x55ee56012715] ``` -- https://bugs.ruby-lang.org/

2 1

[ruby-core:113046] [Ruby master Feature#17290] Syntax sugar for boolean keyword argument
by sawa (Tsuyoshi Sawada) 30 Mar '23

30 Mar '23

Issue #17290 has been updated by sawa (Tsuyoshi Sawada). I withdraw this proposal. Please close it. I came up with a better idea #19559. ---------------------------------------- Feature #17290: Syntax sugar for boolean keyword argument https://bugs.ruby-lang.org/issues/17290#change-102585 * Author: sawa (Tsuyoshi Sawada) * Status: Open * Priority: Normal ---------------------------------------- We frequently use keyword arguments just to pass `true` value out of the truthy/falsy options given. And in many such cases, the falsy option is set as the default, and only the truthy value is ever passed explicitly. I propose to have a syntax sugar to omit the value of a keyword argument. When omitted, it should be interpreted with value `true`. ```ruby gets(chomp:) CSV.parse(" foo var ", strip:) ``` should be equivalent to ```ruby gets(chomp: true) CSV.parse(" foo var ", strip: true) ``` Additionally, we may also extend this to pragmas. ```ruby # frozen_string_literal: ``` to be equivalent to: ```ruby # frozen_string_literal: true ``` -- https://bugs.ruby-lang.org/

1 0

[ruby-core:113024] [Ruby master Bug#19549] Inconsistency in backref parsing
by hurricup (Alexandr Evstigneev) 29 Mar '23

29 Mar '23

Issue #19549 has been reported by hurricup (Alexandr Evstigneev). ---------------------------------------- Bug #19549: Inconsistency in backref parsing https://bugs.ruby-lang.org/issues/19549 * Author: hurricup (Alexandr Evstigneev) * Status: Open * Priority: Normal * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- This is fine: ``` puts "test #$01234 value" ``` This is not: ``` puts $01234 ``` -- https://bugs.ruby-lang.org/

2 1

[ruby-core:113039] [Ruby master Bug#19557] Deadlock on STDOUT(ERR) lock on signal handler
by ko1 (Koichi Sasada) 29 Mar '23

29 Mar '23

Issue #19557 has been reported by ko1 (Koichi Sasada). ---------------------------------------- Bug #19557: Deadlock on STDOUT(ERR) lock on signal handler https://bugs.ruby-lang.org/issues/19557 * Author: ko1 (Koichi Sasada) * Status: Open * Priority: Normal * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- The following Ruby code produces `deadlock; recursive locking (ThreadError)`. It means some IO operations (`puts`, ...) is not used on trap handlers safely. ```ruby trap(:USR1){puts 'world'} Thread.new{loop{Process.kill(:USR1, $$); sleep 0.5}} loop{puts 'hello'} ``` ``` ... hello hello hello hello hello ../../src/clean/test.rb:2:in `write': deadlock; recursive locking (ThreadError) from ../../src/clean/test.rb:2:in `puts' from ../../src/clean/test.rb:2:in `puts' from ../../src/clean/test.rb:2:in `block in <main>' from ../../src/clean/test.rb:4:in `write' from ../../src/clean/test.rb:4:in `puts' from ../../src/clean/test.rb:4:in `puts' from ../../src/clean/test.rb:4:in `block in <main>' from <internal:kernel>:187:in `loop' from ../../src/clean/test.rb:4:in `<main>' ``` ## Reason * `puts()` calls `rb_io_writev()` * it calls `IO#write` * it calls `io_write_m()` * it calls `io_writev()` * it calls `io_fwritev()` * it calls `io_binwritev()` * it calls `rb_mutex_synchronize()` with `io_binwritev_internal()` * STDOUT's `fptr->write_lock` is acquired here * `io_binwritev_internal()` calls `rb_writev_internal()` * it calls `rb_thread_io_blocking_region()` with `internal_writev_func()` Here, `internal_writev_func()` can be interrupted by signals and if a trap handler is registered, call the trap handler (written in Ruby, `puts 'world'` in this case) and call `Kernel#puts()` and `fptr->write_lock` is already acquired -> `deadlock; recursive locking`. ## Ideas I'm not sure why `fptr->write_lock` is needed, but if there is no internal consistency issue, we can make `fptr->write_lock` `nil` at least for STDOUT/ERR. Another idea is, calling trap handlers (or other interruptible Ruby code such as finalizers and so on) after releasing the lock. But I'm not sure it is feasible. -- https://bugs.ruby-lang.org/

1 0

[ruby-core:113035] [Ruby master Bug#19556] Backport latest versions of URI
by hsbt (Hiroshi SHIBATA) 29 Mar '23

29 Mar '23

Issue #19556 has been reported by hsbt (Hiroshi SHIBATA). ---------------------------------------- Bug #19556: Backport latest versions of URI https://bugs.ruby-lang.org/issues/19556 * Author: hsbt (Hiroshi SHIBATA) * Status: Closed * Priority: Normal * Backport: 2.7: DONE, 3.0: REQUIRED, 3.1: REQUIRED, 3.2: DONE ---------------------------------------- https://www.ruby-lang.org/en/news/2023/03/28/redos-in-uri-cve-2023-28755/ has been published. We should upgrade URI version each stable branch. * [for Ruby 3.0](https://github.com/ruby/ruby/pull/7607) * [for Ruby 3.1](https://github.com/ruby/ruby/pull/7605) -- https://bugs.ruby-lang.org/

2 1

[ruby-core:113031] [Ruby master Feature#19553] Document thread-safety of OpenSSL related classes such as OpenSSL::PKey::RSA or OpenSSL::Cipher etc
by rupert (Robert Pankowecki) 28 Mar '23

28 Mar '23

Issue #19553 has been reported by rupert (Robert Pankowecki). ---------------------------------------- Feature #19553: Document thread-safety of OpenSSL related classes such as OpenSSL::PKey::RSA or OpenSSL::Cipher etc https://bugs.ruby-lang.org/issues/19553 * Author: rupert (Robert Pankowecki) * Status: Open * Priority: Normal ---------------------------------------- From the ruby documentation it is not clear if these objects can be used (i.e. when assigned to a constant) by multiple threads. Especially for the respective encrypting/decrypting method after those objects are fully initialized with keys etc. If you look at what OpenSSL::PKey::RSA#private_encrypt does, it uses RSA_private_encrypt method from openssl: https://www.openssl.org/docs/man1.1.1/man3/RSA_private_encrypt.html . Which also is not documented in relation to thread-safety. The only thing that I found so far about this subject is: > OpenSSL can generally be used safely in multi-threaded applications provided that at least two callback functions are set, the locking_function and threadid_func. Note that OpenSSL is not completely thread-safe, and unfortunately not all global resources have the necessary locks. Further, the thread-safety does not extend to things like multiple threads using the same SSL object at the same time. from https://www.openssl.org/docs/man1.0.2/man3/threads.html which on itself does not help much because: * it is vague (not clear what's the meaning of both "SSL object" and "at the same time") * I do not know if Ruby provides locking_function and threadid_func, perhaps it does https://github.com/ruby/ruby/blob/99d0a257af54aa819c6ced5f1ff8ff37e3d5342b/… ? * I am not sure what's the impact of GIL on all this Looking at how Rails uses OpenSSL related objects, it seems that creating a new instance every time is the recommended approach. Can you confirm? -- https://bugs.ruby-lang.org/

1 0

[ruby-core:112652] [Ruby master Bug#19471] Regexp::compile does not handle :timeout argument
by os (Shigeki OHARA) 28 Mar '23

28 Mar '23

Issue #19471 has been reported by os (Shigeki OHARA). ---------------------------------------- Bug #19471: Regexp::compile does not handle :timeout argument https://bugs.ruby-lang.org/issues/19471 * Author: os (Shigeki OHARA) * Status: Open * Priority: Normal * ruby -v: ruby 3.2.1 (2023-02-08 revision 31819e82c8) [x86_64-freebsd13.1] * Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN ---------------------------------------- I think Regexp::compile is just an alias for Regexp::new, so I assume it handles the :timeout argument. However, Regexp::compile does not seem to handle the :timeout argument properly. ``` $ irb irb(main):001:0> RUBY_VERSION => "3.2.1" irb(main):002:0> re_new = Regexp.new('hoge', timeout: 1.0) => /hoge/ irb(main):003:0> re_new.timeout => 1.0 irb(main):004:0> re_compile = Regexp.compile('hoge', timeout: 1.0) => /hoge/i irb(main):005:0> re_compile.timeout => nil irb(main):006:0> ``` -- https://bugs.ruby-lang.org/

2 1