September 2024 - ruby-core - ml.ruby-lang.org

[ruby-core:117564] [Ruby master Bug#20433] Hash.inspect for some hash returns syntax invalid representation
by tompng (tomoya ishida) 05 Oct '24

05 Oct '24

Issue #20433 has been reported by tompng (tomoya ishida). ---------------------------------------- Bug #20433: Hash.inspect for some hash returns syntax invalid representation https://bugs.ruby-lang.org/issues/20433 * Author: tompng (tomoya ishida) * Status: Open * Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- For these hashes, Hash.inspect returns a syntax invalid representation: ~~~ruby { :a! => 1 } # {:a!=>1} { :a? => 1 } # {:a?=>1} { :* => 1 } # {:*=>1} { :== => 1 } # {:===>1} { :< => 1 } # {:<=>1} ~~~ `eval(hash.inspect)` will raise SyntaxError. Although inspect does not guarantee that the result can be eval-ed, it'd be confusing for these few cases. Maybe related to https://bugs.ruby-lang.org/issues/20235 -- https://bugs.ruby-lang.org/

10 15

[ruby-core:119332] [Ruby master Feature#20769] Add `Hash#transform_value`
by seanpdoyle (Sean Doyle) 05 Oct '24

05 Oct '24

Issue #20769 has been reported by seanpdoyle (Sean Doyle). ---------------------------------------- Feature #20769: Add `Hash#transform_value` https://bugs.ruby-lang.org/issues/20769 * Author: seanpdoyle (Sean Doyle) * Status: Open ---------------------------------------- Add `Hash#transform_value` as a specialized, key-specific version of [Hash#transform_values](https://docs.ruby-lang.org/en/3.3/Hash.html#method-i…. ```ruby hash = { image: "https://example.com/image.jpg" } mutated_hash = hash.transform_value(:image) { |url| download(url) } hash # => { image: "https://example.com/image.jpg" } mutated_hash # => { image: File<...> } hash.transform_value!(:image) { |url| download(url) } hash # => { image: File<...> } ``` Similar value transformation can be achieved through variable assignment and direct mutation: ```ruby hash = { image: "https://example.com/image.jpg" } hash.merge(image: download(hash[:image])) hash[:image] = download(hash[:image]) ``` While simple and currently supported, it requires a local variable (and therefore poses some challenges when chaining other methods) and repeats the Hash key in both the reading and writing portions of the code. -- https://bugs.ruby-lang.org/

3 3

[ruby-core:118811] [Ruby master Feature#20669] Add error classes to differentiate Marshal ArgumentErrors
by olleolleolle (Olle Jonsson) 03 Oct '24

03 Oct '24

Issue #20669 has been reported by olleolleolle (Olle Jonsson). ---------------------------------------- Feature #20669: Add error classes to differentiate Marshal ArgumentErrors https://bugs.ruby-lang.org/issues/20669 * Author: olleolleolle (Olle Jonsson) * Status: Open ---------------------------------------- Currently, Marshal.load raises ArgumentErrors on failure. In the memcache client Dalli, there is [a regular expression to check for a few of the ArgumentErrors that can be raised during Marshal.load](https://github.com/petergoldstein/dalli/blob/v3.2.8/lib/dalli…. In order to make it easier to work with, perhaps new individual error classes deriving from ArgumentError could be introduced in Marshal? Perhaps a MarshalError base class deriving from ArgumentError? Something backwards-compatible. [Dalli PR where another error message would be added](https://github.com/petergoldstein/dalli/pull/1008) -- https://bugs.ruby-lang.org/

4 6

[ruby-core:118514] [Ruby master Bug#20620] singleton_method undefined for module using "extend self"
by dentarg (Patrik Ragnarsson) 03 Oct '24

03 Oct '24

Issue #20620 has been reported by dentarg (Patrik Ragnarsson). ---------------------------------------- Bug #20620: singleton_method undefined for module using "extend self" https://bugs.ruby-lang.org/issues/20620 * Author: dentarg (Patrik Ragnarsson) * Status: Open * ruby -v: ruby 3.4.0dev (2024-07-08T21:43:28Z master e500222de1) [x86_64-linux] * Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- Is this a bug? I expected `ExtendSelf.singleton_method(:foo)` to work when `ExtendSelf.singleton_methods` worked and `:foo` was in the list returned. ```ruby # singleton_method.rb class Klass def self.foo end end module ExtendSelf extend self def foo end end p RUBY_DESCRIPTION p "Klass" p Klass.singleton_methods # => [:foo] p Klass.singleton_method(:foo) # => #<Method: Klass.foo() singleton_method.rb:2> p "ExtendSelf" p ExtendSelf.singleton_methods # => [:foo] p ExtendSelf.singleton_method(:foo) # => singleton_method.rb:19:in `singleton_method': undefined singleton method `foo' for `ExtendSelf' (NameError) ``` ```shell $ docker run --rm -it -v $(pwd):/app -w /app rubylang/ruby:master-nightly-jammy Unable to find image 'rubylang/ruby:master-nightly-jammy' locally master-nightly-jammy: Pulling from rubylang/ruby ... Digest: sha256:922037b184b897786a26b2460f70a66139f87dce67f20ddf760cd4186790ed9f root@9807305c322a:/app# ruby -v ruby 3.4.0dev (2024-07-08T21:43:28Z master e500222de1) [x86_64-linux] root@9807305c322a:/app# ruby singleton_method.rb "ruby 3.4.0dev (2024-07-08T21:43:28Z master e500222de1) [x86_64-linux]" "Klass" [:foo] #<Method: Klass.foo() singleton_method.rb:2> "ExtendSelf" [:foo] singleton_method.rb:21:in 'Kernel#singleton_method': undefined singleton method 'foo' for 'ExtendSelf' (NameError) ``` -- https://bugs.ruby-lang.org/

3 4

[ruby-core:119239] [Ruby master Feature#20750] Expose ruby_thread_has_gvl_p in ruby/thread.h
by kbrock (Keenan Brock) 03 Oct '24

03 Oct '24

Issue #20750 has been reported by kbrock (Keenan Brock). ---------------------------------------- Feature #20750: Expose ruby_thread_has_gvl_p in ruby/thread.h https://bugs.ruby-lang.org/issues/20750 * Author: kbrock (Keenan Brock) * Status: Open ---------------------------------------- Hello All, I'm hoping we can make `ruby_thread_has_gvl_p` a public method and no longer experimental. I saw the following code in a gem that was not compiling with ruby 3.3: ``` c // int ruby_thread_has_gvl_p(void); // <== line of concern if (ruby_thread_has_gvl_p()) { method_call(&context); } else { rb_thread_call_with_gvl(method_call, &context); } ``` 400 unique projects on github added the line listed above to fix compilation. [1] Some of the projects detected the method first in `extconf.rb`, but a majority just referenced it. `ffi` used to have the detection code but dropped it since the method was in all supported ruby versions. It feels like this method is now part of the undocumented public interface. My suggestion is to add the method to the real public interface in `ruby/thread.h`. PR with possible solution: https://github.com/ruby/ruby/pull/11619 Also included a patch if that is easier Thank you for your consideration, Keenan Timeline: - Dec 30 2008 - `rb_thread_call_with_gvl` introduced via 9c04a06 [2] - Jan 12 2009 - `ruby_thread_has_gvl_p` introduced via 6f09fc2 [4] - Jul 18 2012 - `rb_thread_call_with_gvl` made public via e9a91d2 [3] Current references to code: `rb_thread_call_with_gvl` [5] `ruby_thread_has_gvl_p` [6]: [1]: https://github.com/search?q=ruby_thread_has_gvl_p+language%3AC++NOT+is%3Afo… [2]: https://github.com/ruby/ruby/commit/9c04a0647fb99f7554cb2e04385ddbb970631e02 [3]: https://github.com/ruby/ruby/commit/e9a91d2c95dfe22ad0487952f7a1053ef9a5fd16 [4]: https://github.com/ruby/ruby/commit/6f09fc2efd1915c4337ce6dded52a8a8771c3222 [5]: https://github.com/ruby/ruby/blob/master/thread.c#L1878 [6]: https://github.com/ruby/ruby/blob/master/thread.c#L1923 ---Files-------------------------------- 11618.patch (3.18 KB) -- https://bugs.ruby-lang.org/

3 7

[ruby-core:119331] [Ruby master Feature#20768] Add Hash#delete_at
by seanpdoyle (Sean Doyle) 01 Oct '24

01 Oct '24

Issue #20768 has been reported by seanpdoyle (Sean Doyle). ---------------------------------------- Feature #20768: Add Hash#delete_at https://bugs.ruby-lang.org/issues/20768 * Author: seanpdoyle (Sean Doyle) * Status: Open ---------------------------------------- Add `Hash#delete_at` to delete values from a list keyed by its arguments. The interface and return values draw inspiration from [Hash#values_at](https://docs.ruby-lang.org/en/3.3/Hash.html#method-i-values… and [Array#delete_at](https://docs.ruby-lang.org/en/3.3/Array.html#method-i-dele…. It can pair nicely with multiple assignment to deconstruct a `Hash` instance: ```ruby hash = { a: true, b: false } a, c = hash.delete_at(:a, :c) # => [ true, nil ] hash # => { b: false } ``` Similar outcomes can be achieved with rightward assignment: ```ruby hash = { a: true, b: false } hash => { a:, **rest } a # => true rest # => { b: false } ``` However, rightward assignment will raise an error when a key is missing, whereas `Hash#delete_at` could return `nil` or the `Hash#default_value`: ```ruby hash => { c: } # => raises NoMatchingPatternKeyError ``` Similarly, rightward assignment does not mutate the original `Hash` instance. In some circumstances, this is beneficial. However, others that require mutation would involve re-assigning the variable: ```ruby hash => { a:, **hash } a # => true hash # => { b:false } ``` Finally, a block can be passed in the same style as [Hash#delete](https://docs.ruby-lang.org/en/3.3/Hash.html#method-i-delete) to provide a default value: ```ruby attributes = { disabled: true, aria: { label: "label text" } } aria, data = attributes.delete_at(:aria, :data) { Hash.new } attributes # => { disabled: true } aria # => { label: "label text" } data # => {} ``` -- https://bugs.ruby-lang.org/

2 1

[ruby-core:119356] [Ruby master Bug#20773] CI of RHEL8 and Amazon Linux 2 are failed from Sep 26th
by hsbt (Hiroshi SHIBATA) 01 Oct '24

01 Oct '24

Issue #20773 has been reported by hsbt (Hiroshi SHIBATA). ---------------------------------------- Bug #20773: CI of RHEL8 and Amazon Linux 2 are failed from Sep 26th https://bugs.ruby-lang.org/issues/20773 * Author: hsbt (Hiroshi SHIBATA) * Status: Open * Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- RHEL8 and Amazon Linux 2 are failed with `Cannot allocate memory - fork(2)` from Sep 26th. * http://rubyci.s3.amazonaws.com/rhel8/ruby-master/log/20240926T093004Z.fail.… * http://rubyci.s3.amazonaws.com/amazon2/ruby-master/log/20240926T033004Z.fai… I'm not sure what's the root cause yet. Amazon Linux 2 is resolved with swapon by @mame. These are strange to increase to usage of memory only for some old distribution. -- https://bugs.ruby-lang.org/

1 1

[ruby-core:119329] [Ruby master Bug#20765] Unexpected node type in pattern matching expression: PM_IMPLICIT_REST_NODE evaluating `a=>*,`
by tompng (tomoya ishida) 30 Sep '24

30 Sep '24

Issue #20765 has been reported by tompng (tomoya ishida). ---------------------------------------- Bug #20765: Unexpected node type in pattern matching expression: PM_IMPLICIT_REST_NODE evaluating `a=>*,` https://bugs.ruby-lang.org/issues/20765 * Author: tompng (tomoya ishida) * Status: Open * ruby -v: ruby 3.4.0dev (2024-09-27T17:45:22Z master 027ef60500) +PRISM [x86_64-linux] * Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- ~~~ # ruby --parser=prism -e "a=>*," -e: [BUG] Unexpected node type in pattern matching expression: PM_IMPLICIT_REST_NODE # ruby --parser=parse.y -e "a=>*," -e:1: syntax error, unexpected end-of-input ~~~ -- https://bugs.ruby-lang.org/

3 2

[ruby-core:119353] [Ruby master Bug#20772] Test with -O3 is flaky
by hsbt (Hiroshi SHIBATA) 30 Sep '24

30 Sep '24

Issue #20772 has been reported by hsbt (Hiroshi SHIBATA). ---------------------------------------- Bug #20772: Test with -O3 is flaky https://bugs.ruby-lang.org/issues/20772 * Author: hsbt (Hiroshi SHIBATA) * Status: Open * Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- I enabled `-O3` build and those tests. But it failed with flaky status. https://github.com/ruby/ruby/actions/runs/11098648054/job/30831665071#step:… ``` [251/251] 53150=test_range worker 53144=test_euc_jp does not respond; SEGV is sent /github/workspace/src/tool/lib/test/unit/parallel.rb:82: [BUG] Segmentation fault at 0x000000000000cf93 ruby 3.4.0dev (2024-09-30T03:03:02Z master 3fe59b04d6) +PRISM [x86_64-linux] -- Control frame information ----------------------------------------------- c:0009 p:---- s:0055 e:000054 CFUNC :close me: called_id: close, type: cfunc owner class: IO self: (IO) c:0008 p:0039 s:0051 e:000050 RESCUE /github/workspace/src/tool/lib/test/unit/parallel.rb:82 me: called_id: _run_suite, type: iseq owner class: Test::Unit::Worker self: (Test::Unit::Worker)len:31 ptr:0x000056195a0f4d20 lvars: $!: (ThreadError)(embed) len:3 c:0007 p:0296 s:0047 E:002530 METHOD /github/workspace/src/tool/lib/test/unit/parallel.rb:83 me: called_id: _run_suite, type: iseq owner class: Test::Unit::Worker self: (Test::Unit::Worker)len:31 ptr:0x000056195a0f4d20 lvars: suite: TestEUC_JP type: T_SYMBOL test orig_testout: (IO) i: (IO) o: (IO) orig_stdin: (IO) orig_stdout: (IO) th: T_NIL e: T_NIL f: T_NIL s: T_NIL result: T_NIL c:0006 p:0007 s:0030 e:000029 BLOCK /github/workspace/src/tool/lib/test/unit/parallel.rb:24 [FINISH] me: called_id: _run_suites, type: iseq owner class: Test::Unit::Worker self: (Test::Unit::Worker)len:31 ptr:0x000056195a0f4d20 lvars: suite: TestEUC_JP c:0005 p:---- s:0026 e:000025 CFUNC :map me: called_id: map, type: cfunc owner class: Array self: (Array)[E ] len: 1 (embed) c:0004 p:0005 s:0022 e:000021 METHOD /github/workspace/src/tool/lib/test/unit/parallel.rb:23 me: called_id: _run_suites, type: iseq owner class: Test::Unit::Worker self: (Test::Unit::Worker)len:31 ptr:0x000056195a0f4d20 lvars: suites: (Array)[E ] len: 1 (embed) type: T_SYMBOL test c:0003 p:0210 s:0016 E:0011d0 METHOD /github/workspace/src/tool/lib/test/unit/parallel.rb:122 me: called_id: run, type: iseq owner class: Test::Unit::Worker self: (Test::Unit::Worker)len:31 ptr:0x000056195a0f4d20 lvars: args: [E ] len: 0 (embed) buf: (String) len: 60, capa: 135 "run /github/workspace/src/test/ruby/enc/test_euc_jp.rb test " suites: (Array)[E ] len: 59 (embed) err: T_NIL e: T_NIL trace: T_NIL c:0002 p:0051 s:0006 E:001360 EVAL /github/workspace/src/tool/lib/test/unit/parallel.rb:220 [FINISH] self: (embed) len:3 c:0001 p:0000 s:0003 E:000d50 DUMMY [FINISH] self: (embed) len:3 (snip) ``` -- https://bugs.ruby-lang.org/

1 0

[ruby-core:117781] [Ruby master Bug#20472] Ractor support for ** into hash literal
by kddnewton (Kevin Newton) 30 Sep '24

30 Sep '24

Issue #20472 has been reported by kddnewton (Kevin Newton). ---------------------------------------- Bug #20472: Ractor support for ** into hash literal https://bugs.ruby-lang.org/issues/20472 * Author: kddnewton (Kevin Newton) * Status: Open * Backport: 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN ---------------------------------------- ```ruby # shareable_constant_value: experimental_copy a = { "foo" => "bar" } A = { **a } ``` In this example, Ruby fails an assertion and crashes. I think we should either provide support for this, or we should explicitly provide a syntax error indicating that ** isn't allowed in constant writes when ractor pragmas are enabled. -- https://bugs.ruby-lang.org/

3 2