ruby-core

Download

ruby-core@ml.ruby-lang.org

August 2026

2 participants
181 discussions

[ruby-core:126223] [Ruby Bug#15598] Deadlock on mutual reference of autoloaded constants
by wanabe (_ wanabe) 02 Aug '26

02 Aug '26

Issue #15598 has been updated by wanabe (_ wanabe). This issue appears to have been corrected at https://github.com/ruby/ruby/commit/6fbc32b5d0da31535cccc0eca1853273313a0b52. ``` $ (git checkout 6fbc32b5d0da31535cccc0eca1853273313a0b52~; make -j miniruby) >/dev/null && ./miniruby -v base_thread_const.rb ; echo $? HEAD is now at 30e5e7c005f Revert "Fix jump buffer leak in setjmp handler in WASI builds" ruby 3.5.0dev (2025-04-01T16:11:01Z v3_5_0_preview1~146 30e5e7c005) +PRISM [x86_64-linux] base_thread_const.rb:5:in 'Thread#join': No live threads left. Deadlock? (fatal) 3 threads, 3 sleeps current:0x000064627f26fd10 main thread:0x000064627f200ad0 * #<Thread:0x00007c9089d2a668 sleep_forever> rb_thread_t:0x000064627f200ad0 native:0x00007c908a2a07c0 int:0 base_thread_const.rb:5:in 'Thread#join' base_thread_const.rb:5:in '<main>' * #<Thread:0x00007c9089d12ae0 base_thread_const.rb:3 sleep_forever> rb_thread_t:0x000064627f269ea0 native:0x00007c906ebbe6c0 int:0 mutex:0x000064627f26fef0 cond:1 depended by: tb_thread_id:0x000064627f200ad0 /home/wanabe/work/prog/ruby/ruby/tmp/master/a.rb:3:in '<class:A>' /home/wanabe/work/prog/ruby/ruby/tmp/master/a.rb:1:in '<top (required)>' base_thread_const.rb:3:in 'Kernel#require' base_thread_const.rb:3:in 'block in <main>' * #<Thread:0x00007c9089d129c8 base_thread_const.rb:4 sleep_forever> rb_thread_t:0x000064627f26fd10 native:0x00007c906e9bc6c0 int:0 /home/wanabe/work/prog/ruby/ruby/tmp/master/b.rb:3:in '<class:B>' /home/wanabe/work/prog/ruby/ruby/tmp/master/b.rb:1:in '<top (required)>' base_thread_const.rb:4:in 'Kernel#require' base_thread_const.rb:4:in 'block in <main>' from base_thread_const.rb:5:in '<main>' 1 $ (git checkout 6fbc32b5d0da31535cccc0eca1853273313a0b52; make -j miniruby) >/dev/null && ./miniruby -v base_thread_const.rb ; echo $? Previous HEAD position was 30e5e7c005f Revert "Fix jump buffer leak in setjmp handler in WASI builds" HEAD is now at 6fbc32b5d0d GCC defines __linux__, not __LINUX__ ruby 3.5.0dev (2025-04-01T16:11:01Z v3_5_0_preview1~146 30e5e7c005) +PRISM [x86_64-linux] ["/home/wanabe/work/prog/ruby/ruby/tmp/master/b.rb", 3, [:a1]] ["/home/wanabe/work/prog/ruby/ruby/tmp/master/a.rb", 3, [:b1, :b2]] 0 ``` And for reasons unknown, it depends on the parser. This problem still occurs when using parse.y. ``` $ for parser in prism parse.y; do ./miniruby -v --parser=$parser; for i in $(seq 1 1 1000); do ./miniruby -v --parser=$parser base_thread_const.rb || break; done > /dev/null; done ruby 4.1.0dev (2026-08-02T09:00:37Z :detached: 63c7beb2ef) +PRISM [x86_64-linux] ruby 4.1.0dev (2026-08-02T09:00:37Z :detached: 63c7beb2ef) [x86_64-linux] base_thread_const.rb:5:in 'Thread#join': No live threads left. Deadlock? (fatal) 3 threads, 3 sleeps current:0x00005f6d13cab8c0 main thread:0x00005f6cf8483400 * #<Thread:0x00007dea51d58310 sleep_forever> rb_thread_t:0x00005f6cf8483400 native:0x00007dea522c97c0 int:0 base_thread_const.rb:5:in 'Thread#join' base_thread_const.rb:5:in '<main>' * #<Thread:0x00007dea51c9fe00 base_thread_const.rb:3 sleep_forever> rb_thread_t:0x00005f6d13cab8c0 native:0x00007dea36fbe6c0 int:0 depended by: tb_thread_id:0x00005f6cf8483400 /home/wanabe/work/prog/ruby/ruby/tmp/master/a.rb:3:in '<class:A>' /home/wanabe/work/prog/ruby/ruby/tmp/master/a.rb:1:in '<top (required)>' base_thread_const.rb:3:in 'Kernel#require' base_thread_const.rb:3:in 'block in <main>' * #<Thread:0x00007dea51c9ff18 base_thread_const.rb:4 sleep_forever> rb_thread_t:0x00005f6d13cabfc0 native:0x00007dea36ebd6c0 int:0 mutex:2 cond:1 /home/wanabe/work/prog/ruby/ruby/tmp/master/b.rb:3:in '<class:B>' /home/wanabe/work/prog/ruby/ruby/tmp/master/b.rb:1:in '<top (required)>' base_thread_const.rb:4:in 'Kernel#require' base_thread_const.rb:4:in 'block in <main>' from base_thread_const.rb:5:in '<main>' ``` ---------------------------------------- Bug #15598: Deadlock on mutual reference of autoloaded constants https://bugs.ruby-lang.org/issues/15598#change-118305 * Author: akr (Akira Tanaka) * Status: Open * ruby -v: ruby 2.7.0dev (2019-02-11 trunk 67049) [x86_64-linux] * Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN ---------------------------------------- Mutual reference of autoloaded constants can cause deadlock sporadically. Assume A is defined in a.rb and it uses B at loading time. Also, B is defined in b.rb and it uses A at loading time. ``` % cat a.rb class A def a1() end p [__FILE__, __LINE__, B.instance_methods(false)] def a2() end end % cat b.rb class B def b1() end p [__FILE__, __LINE__, A.instance_methods(false)] def b2() end end ``` If they are loaded via autoload and constants are referenced sequentially, it works (no error, at least). However, incomplete A (which a2 is not defined) is appear in b.rb, though. ``` % cat base_seq.rb autoload :A, "./a" autoload :B, "./b" A B % ruby base_seq.rb ["/tmp/h/b.rb", 3, [:a1]] ["/tmp/h/a.rb", 3, [:b1, :b2]] ``` However, the constants are referenced in multi threads, deadlock can occur, or works like sequential version, sporadically. ``` % cat base_thread_const.rb autoload :A, "./a" autoload :B, "./b" t1 = Thread.new { A } t2 = Thread.new { B } t1.join t2.join % ruby base_thread_const.rb Traceback (most recent call last): 1: from base_thread_const.rb:5:in `<main>' base_thread_const.rb:5:in `join': No live threads left. Deadlock? (fatal) 3 threads, 3 sleeps current:0x000055f9e2fa1b00 main thread:0x000055f9e2ec14b0 * #<Thread:0x000055f9e2eef188 sleep_forever> rb_thread_t:0x000055f9e2ec14b0 native:0x00007f259bc54b40 int:0 base_thread_const.rb:5:in `join' base_thread_const.rb:5:in `<main>' * #<Thread:0x000055f9e31ece30@base_thread_const.rb:3 sleep_forever> rb_thread_t:0x000055f9e31403c0 native:0x00007f2597e99700 int:0 depended by: tb_thread_id:0x000055f9e2ec14b0 /tmp/h/a.rb:3:in `<class:A>' /tmp/h/a.rb:1:in `<top (required)>' /home/akr/ruby/o0/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:54:in `require' /home/akr/ruby/o0/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:54:in `require' base_thread_const.rb:3:in `block in <main>' * #<Thread:0x000055f9e31ecbb0@base_thread_const.rb:4 sleep_forever> rb_thread_t:0x000055f9e2fa1b00 native:0x00007f258ffff700 int:0 /tmp/h/b.rb:3:in `<class:B>' /tmp/h/b.rb:1:in `<top (required)>' /home/akr/ruby/o0/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:54:in `require' /home/akr/ruby/o0/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:54:in `require' base_thread_const.rb:4:in `block in <main>' % ruby base_thread_const.rb ["/tmp/h/b.rb", 3, [:a1]] ["/tmp/h/a.rb", 3, [:b1, :b2]] ``` Also, if "require" is used instead of constant references in the threads, deadlock can occur (sporadically) too. Note that incomplete A can appear in b.rb and incomplete B can appear in a.rb. The incompleteness vary. ``` % cat base_thread_require.rb autoload :A, "./a" autoload :B, "./b" t1 = Thread.new { require './a' } t2 = Thread.new { require './b' } t1.join t2.join % ruby base_thread_require.rb Traceback (most recent call last): 1: from base_thread_require.rb:5:in `<main>' base_thread_require.rb:5:in `join': No live threads left. Deadlock? (fatal) 3 threads, 3 sleeps current:0x00005591a27f5190 main thread:0x00005591a24264b0 * #<Thread:0x00005591a24531a0 sleep_forever> rb_thread_t:0x00005591a24264b0 native:0x00007feced36ab40 int:0 base_thread_require.rb:5:in `join' base_thread_require.rb:5:in `<main>' * #<Thread:0x00005591a2754cc8@base_thread_require.rb:3 sleep_forever> rb_thread_t:0x00005591a27f5190 native:0x00007fece95af700 int:0 depended by: tb_thread_id:0x00005591a24264b0 /tmp/h/a.rb:1:in `<top (required)>' /home/akr/ruby/o0/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:54:in `require' /home/akr/ruby/o0/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:54:in `require' base_thread_require.rb:3:in `block in <main>' * #<Thread:0x00005591a2754a98@base_thread_require.rb:4 sleep_forever> rb_thread_t:0x00005591a2506b00 native:0x00007fece13ad700 int:0 mutex:0x00005591a27f5190 cond:1 /home/akr/ruby/o0/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:54:in `require' /home/akr/ruby/o0/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:54:in `require' /tmp/h/b.rb:3:in `<class:B>' /tmp/h/b.rb:1:in `<top (required)>' /home/akr/ruby/o0/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:54:in `require' /home/akr/ruby/o0/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:54:in `require' base_thread_require.rb:4:in `block in <main>' % ruby base_thread_require.rb ["/tmp/h/b.rb", 3, []] ["/tmp/h/a.rb", 3, [:b1]] % repeat 100 (ruby base_thread_require.rb >& /tmp/z && cat /tmp/z) ["/tmp/h/a.rb", 3, []] ["/tmp/h/b.rb", 3, [:a1]] ["/tmp/h/a.rb", 3, []] ["/tmp/h/b.rb", 3, [:a1]] ["/tmp/h/a.rb", 3, []] ["/tmp/h/b.rb", 3, [:a1]] ["/tmp/h/b.rb", 3, []] ["/tmp/h/a.rb", 3, [:b1]] ["/tmp/h/b.rb", 3, [:a1]] ["/tmp/h/a.rb", 3, [:b1, :b2]] ["/tmp/h/b.rb", 3, [:a1]] ["/tmp/h/a.rb", 3, [:b1, :b2]] ["/tmp/h/b.rb", 3, [:a1]] ["/tmp/h/a.rb", 3, [:b1, :b2]] ["/tmp/h/a.rb", 3, []] ["/tmp/h/b.rb", 3, [:a1]] ["/tmp/h/a.rb", 3, []] ["/tmp/h/b.rb", 3, [:a1]] ["/tmp/h/a.rb", 3, []] ["/tmp/h/b.rb", 3, [:a1]] ["/tmp/h/a.rb", 3, []] ["/tmp/h/b.rb", 3, [:a1]] ["/tmp/h/a.rb", 3, []] ["/tmp/h/b.rb", 3, [:a1]] ["/tmp/h/a.rb", 3, []] ["/tmp/h/b.rb", 3, [:a1]] ["/tmp/h/a.rb", 3, []] ["/tmp/h/b.rb", 3, [:a1]] ["/tmp/h/b.rb", 3, [:a1]] ["/tmp/h/a.rb", 3, [:b1, :b2]] ["/tmp/h/a.rb", 3, []] ["/tmp/h/b.rb", 3, [:a1]] ["/tmp/h/a.rb", 3, []] ["/tmp/h/b.rb", 3, [:a1]] ["/tmp/h/a.rb", 3, []] ["/tmp/h/b.rb", 3, [:a1]] ["/tmp/h/a.rb", 3, [:b1]] ["/tmp/h/b.rb", 3, [:a1, :a2]] ["/tmp/h/b.rb", 3, [:a1]] ["/tmp/h/a.rb", 3, [:b1, :b2]] ["/tmp/h/a.rb", 3, []] ["/tmp/h/b.rb", 3, [:a1]] ["/tmp/h/a.rb", 3, []] ["/tmp/h/b.rb", 3, [:a1]] ["/tmp/h/a.rb", 3, []] ["/tmp/h/b.rb", 3, [:a1]] ``` I think there are several ways to solve this issue. - Prohibit mutual reference. I.e. raise an error at autoload constant reference currently loading. Since mutual reference causes incomplete definition, it is dangerous even with single thread. However, if real application uses such code, this is incompatible. - More coarse locking. Since the deadlock is caused because two threads lock the constants in different order: A to B and B to A. I think it is possible to fix this issue by locking whole autoloading procedure by single lock, namely "global autoload lock". Note that it should also be locked by "require" method if it load a file for autoload. -- https://bugs.ruby-lang.org/

1 0

Jump to page: